Re: [Wireshark-dev] address to string optimization

2015-02-07 Thread mmann78
Made a "first draft" at https://code.wireshark.org/review/7019/ -Original Message- From: Guy Harris To: Developer support list for Wireshark Sent: Fri, Jan 16, 2015 10:55 pm Subject: Re: [Wireshark-dev] address to string optimization On Jan 16, 2015, at 11:3

Re: [Wireshark-dev] address to string optimization

2015-01-16 Thread Guy Harris
On Jan 16, 2015, at 11:34 AM, mman...@netscape.net wrote: > I still like the idea of the address types being "centrally registered" (in > epan directory) and not put into the dissector code, mostly because many of > the address types are used in multiple dissector/protocols. Perhaps libwiresha

Re: [Wireshark-dev] address to string optimization

2015-01-16 Thread mmann78
ctors do this inconsistently because we still have separate functions for each (i.e. address_to_str() and get_ether_name()), and those are usually called within a printf style function themselves. -Original Message- From: Guy Harris To: Developer support list for Wireshark Sent: Fri,

Re: [Wireshark-dev] address to string optimization

2015-01-16 Thread Guy Harris
On Jan 16, 2015, at 6:04 AM, mman...@netscape.net wrote: > A few weeks ago I stumbled across the following comment in address_to_str.c: > > /*XXX FIXME the code below may be called very very frequently in the future. > optimize it for speed and get rid of the slow sprintfs */ > /* XXX - perha

[Wireshark-dev] address to string optimization

2015-01-16 Thread mmann78
A few weeks ago I stumbled across the following comment in address_to_str.c: /*XXX FIXME the code below may be called very very frequently in the future. optimize it for speed and get rid of the slow sprintfs */ /* XXX - perhaps we should have individual address types register a table of r