Re: [Wireshark-dev] Trying to submit a patch

2015-09-08 Thread Jeff Morriss
On 09/05/15 06:48, Alexis La Goutte wrote: On Fri, Sep 4, 2015 at 9:15 PM, John Dill mailto:john.d...@greenfieldeng.com>> wrote: In other instances, I just want to assign a label to an undissectable block of bytes in a packet that I do not want to be filtered on, where I'd use: p

Re: [Wireshark-dev] Trying to submit a patch

2015-09-05 Thread Alexis La Goutte
On Fri, Sep 4, 2015 at 9:15 PM, John Dill wrote: > > >Message: 3 > >Date: Tue, 1 Sep 2015 09:45:14 -0400 > >From: Hadriel Kaplan > >To: Developer support list for Wireshark > >Subject: Re: [Wireshark-dev] Trying to submit a patch > >Message-ID: &

Re: [Wireshark-dev] Trying to submit a patch

2015-09-04 Thread John Dill
>Message: 3 >Date: Tue, 1 Sep 2015 09:45:14 -0400 >From: Hadriel Kaplan >To: Developer support list for Wireshark >Subject: Re: [Wireshark-dev] Trying to submit a patch >Message-ID: > >Content-Type: text/plain; charset=UTF-8 > >I just tried pushing wi

Re: [Wireshark-dev] Trying to submit a patch

2015-09-01 Thread Hadriel Kaplan
I just tried pushing with https, and it works. But of course you'll still need a Change-ID and such. What *exact* error message are you seeing? Also, why would you submit something new into master-1.12? We only do bug fixes for 1.12, not new features. New features go in master (i.e., 1.99.x). -h

[Wireshark-dev] Trying to submit a patch

2015-09-01 Thread John Dill
I have finally got the time to port my changes to proto.h/proto.c over to the master-1.12 version of wireshark and I'm getting stuck trying to submit a patch for review. I was not able to clone using the ssh method to download the latest git repo, but I was able to clone using the https link.