Re: [Wireshark-dev] Some fields output nothing, when using tshark with -T fields

2008-01-22 Thread Sake Blok
On Tue, Jan 22, 2008 at 09:39:54AM +0100, Nils wrote: > > Yes, the fields will be added to the fields struct, but when > > proto_tree_get_node_field_values() goes through the fields, it > > uses get_node_field_value() to get the actual value. This function > > returned NULL when a fields was of typ

Re: [Wireshark-dev] Some fields output nothing, when using tshark with -T fields

2008-01-22 Thread Nils
> Yes, the fields will be added to the fields struct, but when > proto_tree_get_node_field_values() goes through the fields, it > uses get_node_field_value() to get the actual value. This function > returned NULL when a fields was of type FT_NONE. I committed a > patch that makes it return "1" inst

Re: [Wireshark-dev] Some fields output nothing, when using tshark with -T fields

2008-01-21 Thread Sake Blok
On Mon, Jan 21, 2008 at 10:07:22PM +0100, Nils wrote: > I had a look at the patch [1], which introduced -T fields, especially > at this file [2]. However I did not figure out why it outputs nothing > for some fields. As far as I can see, all the fields added with -e are > appended to the 'fields' s

Re: [Wireshark-dev] Some fields output nothing, when using tshark with -T fields

2008-01-21 Thread Nils
I had a look at the patch [1], which introduced -T fields, especially at this file [2]. However I did not figure out why it outputs nothing for some fields. As far as I can see, all the fields added with -e are appended to the 'fields' struct within output_fields_add(..), but I can't see where it g

Re: [Wireshark-dev] Some fields output nothing, when using tshark with -T fields

2008-01-18 Thread Sake Blok
On Fri, Jan 18, 2008 at 10:48:48AM +0100, Nils wrote: > Thanks a lot for your quick replay! > > > In case of the field "tcp.analysis.retransmission" I think there > > is room for improvement. Even when this field is in the packet, no > > output is given. That is because this field does not have a

Re: [Wireshark-dev] Some fields output nothing, when using tshark with -T fields

2008-01-18 Thread Nils
Thanks a lot for your quick replay! > In case of the field "tcp.analysis.retransmission" I think there > is room for improvement. Even when this field is in the packet, no > output is given. That is because this field does not have a value. > It is either present or not. Is this because it's type

Re: [Wireshark-dev] Some fields output nothing, when using tshark with -T fields

2008-01-17 Thread Sake Blok
On Thu, Jan 17, 2008 at 08:05:17PM +0100, Sake Blok wrote: > On Thu, Jan 17, 2008 at 04:19:52PM +0100, Nils wrote: > > In case of the field "tcp.analysis.retransmission" I think there > is room for improvement. Even when this field is in the packet, "Even when this field is in the packet" should

Re: [Wireshark-dev] Some fields output nothing, when using tshark with -T fields

2008-01-17 Thread Sake Blok
On Thu, Jan 17, 2008 at 04:19:52PM +0100, Nils wrote: > > Some fields output nothing, when tshark is used with the -T fields > option, for example tcp.analysis.retransmission [1] I first thought > that this is because it's type is 'None', then I saw that this is also > the case for other fields, l

[Wireshark-dev] Some fields output nothing, when using tshark with -T fields

2008-01-17 Thread Nils
Hello Some fields output nothing, when tshark is used with the -T fields option, for example tcp.analysis.retransmission [1] I first thought that this is because it's type is 'None', then I saw that this is also the case for other fields, like tcp.analysis.duplicate_ack_num. I had a look at the c