Re: [Wireshark-dev] RFC Try 2: Rework of Makefiles in asn1-directory

2007-09-25 Thread Kukosa, Tomas
> OK, committed. I'll start working on the remaining protocols > tonight, so > if you want to convert some yourself, go ahead, I'll do > what's left :-) > Hello Joerg, it fails somewhere (see buildbot): make[2]: Entering directory `/media/GeraldsHome/buildbot/bb-wireshark/trunk/ubuntu510x86/bu

Re: [Wireshark-dev] RFC Try 2: Rework of Makefiles in asn1-directory

2007-09-25 Thread Joerg Mayer
On Tue, Sep 25, 2007 at 11:59:22AM +0200, Kukosa, Tomas wrote: > It looks OK. > It could be important in some cases what is the order of ASN.1 input > files. > I think it could be solved when such a case occurs. OK, committed. I'll start working on the remaining protocols tonight, so if you want t

Re: [Wireshark-dev] RFC Try 2: Rework of Makefiles in asn1-directory

2007-09-25 Thread Kukosa, Tomas
> > > > The question is what should be the order if "$(ASN_FILE_LIST) > > $(EXT_ASN_FILE_LIST)" or "$(EXT_ASN_FILE_LIST) $(ASN_FILE_LIST)". > > In the past it was $(ASN..) $(EXT_ASN...). > > If it's OK I'll commit v2 plus this change. > It looks OK. It could be important in some cases what is

Re: [Wireshark-dev] RFC Try 2: Rework of Makefiles in asn1-directory

2007-09-25 Thread Joerg Mayer
Hi, On Tue, Sep 25, 2007 at 09:49:13AM +0200, Kukosa, Tomas wrote: > the $(EXT_ASN_FILE_LIST) should be used somewhere in the Makefile.inc > and Makefile.inc.nmake > Probably > $(PYTHON) "../../tools/asn2wrs.py" \ > $(A2W_FLAGS) \ > -p $(PROTOCOL_NAME) \ >

Re: [Wireshark-dev] RFC Try 2: Rework of Makefiles in asn1-directory

2007-09-25 Thread Kukosa, Tomas
[EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Joerg Mayer > Sent: Monday, September 24, 2007 4:04 PM > To: wireshark-dev@wireshark.org > Subject: [Wireshark-dev] RFC Try 2: Rework of Makefiles in > asn1-directory > > OK, I've committed the changes to asn2wrs

Re: [Wireshark-dev] RFC Try 2: Rework of Makefiles in asn1-directory

2007-09-24 Thread Joerg Mayer
On Mon, Sep 24, 2007 at 04:03:47PM +0200, Joerg Mayer wrote: > to (hopefully) accomodate Thomas' comments. That should be Tomas' of course. Sorry Joerg -- Joerg Mayer <[EMAIL PROTECTED]> We are stuck with technology when what we really want is just s

[Wireshark-dev] RFC Try 2: Rework of Makefiles in asn1-directory

2007-09-24 Thread Joerg Mayer
OK, I've committed the changes to asn2wrs and have updated the Makefiles to (hopefully) accomodate Thomas' comments. I'd like some feedback whether this has been tested on Windows, as I can only test on Linux. ciao Joerg -- Joerg Mayer <[EMAIL PROT