Re: [Wireshark-dev] Q re a possible bug for someone familiar with packet-ansi_637.c

2011-04-06 Thread Jaap Keuter
On Wed, 6 Apr 2011 14:31:03 + (UTC), Chris Maynard wrote: > Jaap Keuter writes: > >> That's the common way to show the application protocol in SIP message bodies. Most well known is Session Description Protocol in Session Initiation Protocol messages: SIP/SDP. > But dissect_ansi_637_trans_

Re: [Wireshark-dev] Q re a possible bug for someone familiar with packet-ansi_637.c

2011-04-06 Thread Chris Maynard
Jaap Keuter writes: > That's the common way to show the application protocol in SIP message bodies. > Most well known is Session Description Protocol in Session Initiation > Protocol > messages: SIP/SDP. But dissect_ansi_637_trans_app() calls col_set_str(), not col_append_str(), and I don't s

Re: [Wireshark-dev] Q re a possible bug for someone familiar with packet-ansi_637.c

2011-04-05 Thread Jaap Keuter
On 04/05/2011 03:49 PM, Chris Maynard wrote: Bill Meier writes: In the proto_reg_handoff_ansi_637() code the variable 'ansi_637_trans_app_handle' is set but never used. (Coverity 835). My suspicion is that this handle should be used in the following iso 'ansi_637_trans_handle': /* Diss

Re: [Wireshark-dev] Q re a possible bug for someone familiar with packet-ansi_637.c

2011-04-05 Thread Chris Maynard
Bill Meier writes: > In the proto_reg_handoff_ansi_637() code the variable > 'ansi_637_trans_app_handle' is set but never used. > (Coverity 835). > > My suspicion is that this handle should be used in the following iso > 'ansi_637_trans_handle': > > /* Dissect messages embedded in SIP */

[Wireshark-dev] Q re a possible bug for someone familiar with packet-ansi_637.c

2011-04-04 Thread Bill Meier
In the proto_reg_handoff_ansi_637() code the variable 'ansi_637_trans_app_handle' is set but never used. (Coverity 835). My suspicion is that this handle should be used in the following iso 'ansi_637_trans_handle': /* Dissect messages embedded in SIP */ dissector_add_string("media_type