Re: [Wireshark-dev] Protocol to tie Bugzilla entry to Gerrit change

On Aug 13, 2020, at 5:27 AM, Jaap Keuter wrote: > On 13 Aug 2020, at 09:37, Guy Harris wrote: > >> On Aug 13, 2020, at 12:24 AM, Jaap Keuter wrote: >> >>> For now(*) this is done as per >>> https://wiki.wireshark.org/Development/SubmittingPatches#Writing_a_Good_Commit_Message >> >> He's tal

Re: [Wireshark-dev] Protocol to tie Bugzilla entry to Gerrit change

> On 13 Aug 2020, at 09:37, Guy Harris wrote: > > On Aug 13, 2020, at 12:24 AM, Jaap Keuter wrote: > >> For now(*) this is done as per >> https://wiki.wireshark.org/Development/SubmittingPatches#Writing_a_Good_Commit_Message > > He's talking about comments in Gerrit, such as "this change bro

Re: [Wireshark-dev] Protocol to tie Bugzilla entry to Gerrit change

On Aug 12, 2020, at 11:05 AM, chuck c wrote: > What is protocol to tie a bug entry > (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16771) > to a Gerrit change (https://code.wireshark.org/review/#/c/31973/)? One way to do it would be to file the bug and then make a post-commit comment in

Re: [Wireshark-dev] Protocol to tie Bugzilla entry to Gerrit change

On Aug 13, 2020, at 12:24 AM, Jaap Keuter wrote: > For now(*) this is done as per > https://wiki.wireshark.org/Development/SubmittingPatches#Writing_a_Good_Commit_Message He's talking about comments in Gerrit, such as "this change broke XXX"; he's not talking about commit messages in Git.

Re: [Wireshark-dev] Protocol to tie Bugzilla entry to Gerrit change

Hi, For now(*) this is done as per https://wiki.wireshark.org/Development/SubmittingPatches#Writing_a_Good_Commit_Message (*) there’s a Big Move coming to a GitLab instance, this will Change Everything(tm

[Wireshark-dev] Protocol to tie Bugzilla entry to Gerrit change

What is protocol to tie a bug entry ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16771) to a Gerrit change (https://code.wireshark.org/review/#/c/31973/)? If only done in Bugzilla, will it languish out there till someone takes an interest? Or add a comment in Gerrit which I assume sends