Re: [Wireshark-dev] Patch Netflow v9 to decode Netflow options, and other fixes

2007-05-03 Thread Anders Broman
Committed revision 21672. Thanks Anders -Ursprungligt meddelande- Från: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] För Olivier MONTANUY Skickat: den 30 april 2007 18:12 Till: wireshark-dev@wireshark.org Ämne: Re: [Wireshark-dev] Patch Netflow v9 to decode Netflow options, and other fixes

Re: [Wireshark-dev] Patch Netflow v9 to decode Netflow options, and other fixes

2007-04-30 Thread Olivier MONTANUY
I agree that the hex decoding is a bit strange: I still didn't find the right way to do it. So submitted the patch again, this time without the hex decoding stuff. I also fixed the code so that it differs less from the original. Now is it possible to apply the patch? There are other fixes nee

Re: [Wireshark-dev] Patch Netflow v9 to decode Netflow options, and other fixes

2007-04-27 Thread Jaap Keuter
Hi, Patch looks good, not too sure about the to_hexadecimal though. Thanx, Jaap On Fri, 27 Apr 2007, Olivier MONTANUY wrote: > Hello, > > I opened a a bug report #1579 to signal that epan/dissectors/packet-netflow.c > currently cannot decode Netflow options, because it does not take into > acc

[Wireshark-dev] Patch Netflow v9 to decode Netflow options, and other fixes

2007-04-27 Thread Olivier MONTANUY
Hello, I opened a a bug report #1579 to signal that epan/dissectors/packet-netflow.c currently cannot decode Netflow options, because it does not take into account the option scope. Netflow options provide information that are needed to interpret the Netflow records, like the ifName, ifDescr an