Re: [Wireshark-dev] New dissector: PANA

2006-07-14 Thread ronnie sahlberg
checked in can you upload the/a capture file to the SampleCaptures page of the wireshark wiki so it gets pulled in to fuzztesting? please also create a wiki page for this protocol. it does not take much time. i made some changes to the code and strengthened the heuristics. is is very import

Re: [Wireshark-dev] New dissector: PANA

2006-07-05 Thread ronnie sahlberg
value_strings must be terminated with a {0,NULL} entry or else val_to_str and friends are likely to walk outside the array and segv. can you break the flags field out into its own subdissector that also populates the expansion line. see for example dissect_iui_flags() in packet-fcsb3.c can yo