Re: [Wireshark-dev] Kismet protocol dissector

2006-07-14 Thread ronnie sahlberg
hi checked in. i reindented your patch and changed some stuff like space between a function name and the '(' for the next patch, please send it as a unified diff against current svn instead of the entire file so it is easier to review. i made some changes as removing the spaces between the

Re: [Wireshark-dev] Kismet protocol dissector

2006-07-13 Thread Krzysztof Burghardt
> wiki.wireshark.org/SampleCaptures and then link to these captures [...] > can you move them to /SampleCaptures and link there from the protocol > page Sure, done. > You put the braces for compound statement differently from the rest of > wireshark coding style > which (most of the time/often)

Re: [Wireshark-dev] Kismet protocol dissector

2006-07-13 Thread ronnie sahlberg
Checked in. Nice work! Oh, on the wiki, i forgot to specify this before, sorry for that but we usually put all example capture on wiki.wireshark.org/SampleCaptures and then link to these captures from the protocol page instead of putting the actual capture on the protocol page. This pust all

Re: [Wireshark-dev] Kismet protocol dissector

2006-07-12 Thread ronnie sahlberg
Hi, Some comments 1, please create a WIKI page on wiki.wireshark.org for this protocol. Fill it out as much as possible to make it as nice and informative as possible for causal non-kismet expert users 2, upload the example traces to that wiki page. 3, you use "hidden" fields such as the hf_kis