Re: [Wireshark-dev] Interesting thing about "recent" changes in GHashTable

2013-08-14 Thread Jakub Zawadzki
Hi, On Tue, Aug 13, 2013 at 06:15:28PM -0400, Evan Huus wrote: > Not worth it in my opinion unless the memory savings are significant (I > suspect they are only in the range of a few-hundred KB). Yes, something like this. Exact numbers for few: proto_names21KB3 insertions(+),

Re: [Wireshark-dev] Interesting thing about "recent" changes in GHashTable

2013-08-13 Thread Evan Huus
Not worth it in my opinion unless the memory savings are significant (I suspect they are only in the range of a few-hundred KB). On Tue, Aug 13, 2013 at 1:35 PM, Jakub Zawadzki wrote: > On Tue, Aug 13, 2013 at 01:12:18PM -0400, Evan Huus wrote: > > Anyone building with a new enough glib will get

Re: [Wireshark-dev] Interesting thing about "recent" changes in GHashTable

2013-08-13 Thread Jakub Zawadzki
On Tue, Aug 13, 2013 at 01:12:18PM -0400, Evan Huus wrote: > Anyone building with a new enough glib will get this behaviour for free? So > I don't think it's worth backporting to older builds unless the memory > savings are really significant... I don't want to backport it, I was thinking about us

Re: [Wireshark-dev] Interesting thing about "recent" changes in GHashTable

2013-08-13 Thread Evan Huus
Anyone building with a new enough glib will get this behaviour for free? So I don't think it's worth backporting to older builds unless the memory savings are really significant... Very neat optimization though. On Tue, Aug 13, 2013 at 1:11 PM, Jakub Zawadzki wrote: > Hi, > > Looking for some s

[Wireshark-dev] Interesting thing about "recent" changes in GHashTable

2013-08-13 Thread Jakub Zawadzki
Hi, Looking for some stuff in glib sources, I had found that glib 2.30[1] has nice feature of GHashTable. If we pass the same pointer as key and value, memory usage is cut down by 1/3 (cool!). Implementation of it would be a little hacky, but maybe worthy? [1] Exactly speaking of this commit: