Re: [Wireshark-dev] Git-review (was: Re: Fix bug in GSM MAP, have problems with GIT)

2014-03-11 Thread Hadriel Kaplan
On Mar 11, 2014, at 3:01 PM, Guy Harris wrote: > > On Mar 11, 2014, at 11:18 AM, Hadriel Kaplan > wrote: > >> I see you have the 'pip install git-review' stuff on that page... fwiw, I've >> never gotten git-review to work on my Mac. I got it installed with pip, but >> issuing any 'git rev

Re: [Wireshark-dev] Git-review (was: Re: Fix bug in GSM MAP, have problems with GIT)

2014-03-11 Thread Guy Harris
On Mar 11, 2014, at 11:18 AM, Hadriel Kaplan wrote: > I see you have the 'pip install git-review' stuff on that page... fwiw, I've > never gotten git-review to work on my Mac. I got it installed with pip, but > issuing any 'git review' command doesn't work. I don't *think* it's a path > pro

[Wireshark-dev] Git-review (was: Re: Fix bug in GSM MAP, have problems with GIT)

2014-03-11 Thread Hadriel Kaplan
On Mar 11, 2014, at 1:59 PM, Evan Huus wrote: http://wiki.wireshark.org/Development/SubmittingPatches as a very bare-bones tutorial. Hopefully others will expand it as necessary. > > I've tried to answer a few of these with a new revision of the page. I see you have