> -Original Message-
> From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-
> boun...@wireshark.org] On Behalf Of Evan Huus
> Sent: den 25 augusti 2014 19:32
> To: Developer support list for Wireshark
> Subject: Re: [Wireshark-dev] Gerrit patches with t
On 25 August 2014 20:03, Joerg Mayer wrote:
> On Mon, Aug 25, 2014 at 06:06:15PM +0100, Graham Bloice wrote:
> > When reviewing some submissions on Gerrit, I've noted a few with trailing
> > whitespace. The git pre-commit hook always warns me of this, so how are
> > folks managing to do this? A
On Mon, Aug 25, 2014 at 06:06:15PM +0100, Graham Bloice wrote:
> When reviewing some submissions on Gerrit, I've noted a few with trailing
> whitespace. The git pre-commit hook always warns me of this, so how are
> folks managing to do this? Are they using clients that ignore the hook?
How about
On 8/25/2014 1:48 PM, Alexis La Goutte wrote:
Should we add some info then to the Dev Guide as to where to get the hook,
It's already in http://wiki.wireshark.org/Development/SubmittingPatches#Setup
We keep running into this problem - should the wiki page and the dev
guide be consolidated?
a
On Mon, Aug 25, 2014 at 7:32 PM, Evan Huus wrote:
> On Mon, Aug 25, 2014 at 1:21 PM, Graham Bloice
> wrote:
>> On 25 August 2014 18:17, Graham Bloice wrote:
>>>
>>> On 25 August 2014 18:11, Juan Jose Martin Carrascosa
>>> wrote:
I think that you are talking about my just committed cha
On Mon, Aug 25, 2014 at 1:21 PM, Graham Bloice
wrote:
> On 25 August 2014 18:17, Graham Bloice wrote:
>>
>> On 25 August 2014 18:11, Juan Jose Martin Carrascosa
>> wrote:
>>>
>>> I think that you are talking about my just committed changes. I just did
>>> it and I just checked in the website tha
On 25 August 2014 18:17, Graham Bloice wrote:
> On 25 August 2014 18:11, Juan Jose Martin Carrascosa
> wrote:
>
>> I think that you are talking about my just committed changes. I just did
>> it and I just checked in the website that it has the whitespaces...
>>
>> As Evan said, I don't have it i
On 25 August 2014 18:11, Juan Jose Martin Carrascosa wrote:
> I think that you are talking about my just committed changes. I just did
> it and I just checked in the website that it has the whitespaces...
>
> As Evan said, I don't have it installed by default and I wasn't really
> aware of the pr
I think that you are talking about my just committed changes. I just did it
and I just checked in the website that it has the whitespaces...
As Evan said, I don't have it installed by default and I wasn't really
aware of the process (even reading the doc a couple of times). I am really
sorry.
I w
When reviewing some submissions on Gerrit, I've noted a few with trailing
whitespace. The git pre-commit hook always warns me of this, so how are
folks managing to do this? Are they using clients that ignore the hook?
--
Graham Bloice
Probably they are simply not installing the hook - none of our tooling
sets it up by default that I'm aware of.
On Mon, Aug 25, 2014 at 1:06 PM, Graham Bloice
wrote:
> When reviewing some submissions on Gerrit, I've noted a few with trailing
> whitespace. The git pre-commit hook always warns me
11 matches
Mail list logo
