Re: [Wireshark-dev] Automatically Expiring Old Gerrit Reviews

2014-02-13 Thread Evan Huus
On Thu, Feb 13, 2014 at 12:36 PM, Hadriel Kaplan wrote: > > Speaking of old reviews, anything going on with the Michael Labedzki's > omnivorous-shark one? (https://code.wireshark.org/review/#/c/16) At one point he was talking with Michael Mann since they were working on closely-related (and poss

Re: [Wireshark-dev] Automatically Expiring Old Gerrit Reviews

2014-02-13 Thread Hadriel Kaplan
Speaking of old reviews, anything going on with the Michael Labedzki's omnivorous-shark one? (https://code.wireshark.org/review/#/c/16) I ask because I've implemented a feature whose code will change quite a bit if/when the omnivorous-shark one gets merged, so I've been waiting for that merge

Re: [Wireshark-dev] Automatically Expiring Old Gerrit Reviews

2014-02-12 Thread Evan Huus
On Wed, Feb 12, 2014 at 4:07 PM, Pascal Quantin wrote: > 2014-02-12 21:57 GMT+01:00 Evan Huus : > >> Been poking around how other projects use Gerrit and discovered that >> openstack has a cron job which automatically expires old reviews [1]. >> >> Seems like it might be a good idea, and doesn't s

Re: [Wireshark-dev] Automatically Expiring Old Gerrit Reviews

2014-02-12 Thread Pascal Quantin
2014-02-12 21:57 GMT+01:00 Evan Huus : > Been poking around how other projects use Gerrit and discovered that > openstack has a cron job which automatically expires old reviews [1]. > > Seems like it might be a good idea, and doesn't sound too hard to do. > Abandoned/expired reviews can easily be

[Wireshark-dev] Automatically Expiring Old Gerrit Reviews

2014-02-12 Thread Evan Huus
Been poking around how other projects use Gerrit and discovered that openstack has a cron job which automatically expires old reviews [1]. Seems like it might be a good idea, and doesn't sound too hard to do. Abandoned/expired reviews can easily be reopened. Thoughts? Evan [1] http://ci.openstac