Re: [Wireshark-dev] [REPOST][PATCH] update USB dissector

2007-03-22 Thread Charles Lepple
On 2/6/07, Paolo Abeni <[EMAIL PROTECTED]> wrote: > > Do you have a capture file with a USB memory stick with the new pcap > > link type you can share with me? > > I have updated the sample captures wiki page adding some captures with > the new data link type; you can find them here: > > http://wik

Re: [Wireshark-dev] [REPOST][PATCH] update USB dissector

2007-03-18 Thread Charles Lepple
On 1/30/07, Guy Harris <[EMAIL PROTECTED]> wrote: I also fixed some other issues that I saw when reading the capture - for example, some fields from the USB packet were being read in big-endian format rather than little-endian format, and control packets were being interpreted as standard request

Re: [Wireshark-dev] [REPOST][PATCH] update USB dissector

2007-02-06 Thread Paolo Abeni
On Tue, 2007-02-06 at 11:30 +1100, ronnie sahlberg wrote: > You also did BlueTooth for pcap? so could you update > http://wiki.wireshark.org/CaptureSetup/Bluetooth > since it appears to be a bit out of date:-) This is on my todo list, but, since some fix is still required on the libpcap side, fir

Re: [Wireshark-dev] [REPOST][PATCH] update USB dissector

2007-01-31 Thread Paolo Abeni
Hello, On Tue, 2007-01-30 at 12:19 -0800, Guy Harris wrote: > You might want to check to make sure that file (written out in > big-endian format) can be read by your little-endian machine; I've > attached that capture. It works also on my machine. > I modified the code to make the Linux-speci

Re: [Wireshark-dev] [REPOST][PATCH] update USB dissector

2007-01-30 Thread Guy Harris
Paolo Abeni wrote: On Fri, 2007-01-26 at 23:39 -0500, Charles Lepple wrote: One problem is that the proto_tree_add_* calls set the little_endian flag to true regardless of the endianness of the host. This is a bug. Thanks for pointing it out. The attached patch should solve it. I renew the

[Wireshark-dev] [REPOST][PATCH] update USB dissector (was: update wiretap and sub dissector)

2007-01-30 Thread Paolo Abeni
On Fri, 2007-01-26 at 23:39 -0500, Charles Lepple wrote: > One problem is that the proto_tree_add_* calls set the little_endian > flag to true regardless of the endianness of the host. This is a bug. Thanks for pointing it out. The attached patch should solve it. I renew the pledge for reviewing