Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-22 Thread Shaun Jackman
On 3/22/07, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > I have checked in the wiretap patch after doing the changes listed. Great! Thanks for doing the massaging necessary to check in the patch. Cheers, Shaun ___ Wireshark-dev mailing list Wireshark-de

Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-22 Thread ronnie sahlberg
Thanks. Checked in. On 3/22/07, Graham Bloice <[EMAIL PROTECTED]> wrote: > ronnie sahlberg wrote: > > Thanks. > > > > I have added two headers to mpeg.h hoping that msvc will find the > > missing definitions. > > > > Please try latest svn > > > > It found the definitions but was still picky ab

Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-22 Thread Graham Bloice
ronnie sahlberg wrote: > Thanks. > > I have added two headers to mpeg.h hoping that msvc will find the > missing definitions. > > Please try latest svn > It found the definitions but was still picky about some implicit casts. Attached are the changes required to allow compilation without war

Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-22 Thread ronnie sahlberg
Thanks. I have added two headers to mpeg.h hoping that msvc will find the missing definitions. Please try latest svn On 3/22/07, Graham Bloice <[EMAIL PROTECTED]> wrote: > ronnie sahlberg wrote: > > I have checked in the wiretap patch after doing the changes listed. > > > > > > The win32 bui

Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-22 Thread Graham Bloice
ronnie sahlberg wrote: > I have checked in the wiretap patch after doing the changes listed. > > The win32 build on MSVC 6.0 fails with the following errors: mpeg.c(47) : error C2065: 'off_t' : undeclared identifier mpeg.c(47) : error C2146: syntax error : missing ';' before identifier 'offset'

Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-22 Thread ronnie sahlberg
I have checked in the wiretap patch after doing the changes listed. On 3/21/07, Shaun Jackman <[EMAIL PROTECTED]> wrote: > On 3/20/07, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > > 1, shouldnt the defines MPA_MARSHAL_... really be called > > MPA_UNMARSHAL_... instead? > > Good point. > > > 2, do

Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-22 Thread Graham Bloice
Shaun Jackman wrote: >> 2, do you really need all these includes? >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> are all of these ones actually available on all platforms we support? > > At one point each of these includes was required. I'll do

Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-21 Thread Shaun Jackman
On 3/20/07, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > 1, shouldnt the defines MPA_MARSHAL_... really be called > MPA_UNMARSHAL_... instead? Good point. > 2, do you really need all these includes? > +#include > +#include > +#include > +#include > +#include > +#include > +#include > are a

Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-20 Thread ronnie sahlberg
1, shouldnt the defines MPA_MARSHAL_... really be called MPA_UNMARSHAL_... instead? 2, do you really need all these includes? +#include +#include +#include +#include +#include +#include +#include are all of these ones actually available on all platforms we support? 3, not all compilers w

Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-16 Thread Shaun Jackman
On 3/15/07, Jeff Morriss <[EMAIL PROTECTED]> wrote: Actually the patch isn't attached ;-) Grumble. =P 2007-03-15 Shaun Jackman <[EMAIL PROTECTED]> * wiretap/Makefile.common (NONGENERATED_C_FILES): Add mpeg.c. (NONGENERATED_HEADER_FILES): Add mpeg.h. * wiretap/file_access

Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-15 Thread Jeff Morriss
Actually the patch isn't attached ;-) Shaun Jackman wrote: > On 8/25/06, ronnie sahlberg <[EMAIL PROTECTED]> wrote: >> Can you add the GPL boilerplate to some of the files that are missing it. > > Done. > >> Why do you create a mpeg plugin directory? >> To me it looks like an normal dissector g

[Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-15 Thread Shaun Jackman
On 8/25/06, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > Can you add the GPL boilerplate to some of the files that are missing it. Done. > Why do you create a mpeg plugin directory? > To me it looks like an normal dissector generated by asn2wrs and as > such it is not a plugin. am i missing som

[Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2006-08-25 Thread Shaun Jackman
I've created an MPEG stream decoder for Wireshark. It's useful for decoding streaming audio. It currently supports MPEG-1, MPEG-2, MPEG-2.5 audio, layers 1, 2, 3. To test out the protocol decoder, the first half of the patch adds a wiretap file format to allow opening your favourite MPEG audio fil