Re: [Wireshark-dev] [PATCH]fix warnings

2007-03-22 Thread Joerg Mayer
On Thu, Mar 22, 2007 at 04:05:32PM +0100, Sebastien Tandel wrote: > same patch except that capture_*_pflog are stripped Committed revision 21120. -- Joerg Mayer <[EMAIL PROTECTED]> We are stuck with technology when what we really want is just stuff that

Re: [Wireshark-dev] [PATCH]fix warnings

2007-03-22 Thread Sebastien Tandel
same patch except that capture_*_pflog are stripped Joerg Mayer wrote: > On Thu, Mar 22, 2007 at 12:58:47PM +0100, Sebastien Tandel wrote: > >> As it's not a simple unused variable and I had no idea if these >> functions could ever be used again, I preferred to let them in the code. >> But if

Re: [Wireshark-dev] [PATCH]fix warnings

2007-03-22 Thread Joerg Mayer
On Thu, Mar 22, 2007 at 12:58:47PM +0100, Sebastien Tandel wrote: > As it's not a simple unused variable and I had no idea if these > functions could ever be used again, I preferred to let them in the code. > But if it's sure that they will never be used. I can delete them. Well, if someone really

Re: [Wireshark-dev] [PATCH]fix warnings

2007-03-22 Thread Sebastien Tandel
As it's not a simple unused variable and I had no idea if these functions could ever be used again, I preferred to let them in the code. But if it's sure that they will never be used. I can delete them. Regards, Sebastien Tandel Joerg Mayer wrote: > On Thu, Mar 22, 2007 at 01:54:19AM +0100, Se

Re: [Wireshark-dev] [PATCH]fix warnings

2007-03-21 Thread Joerg Mayer
On Thu, Mar 22, 2007 at 01:54:19AM +0100, Sebastien Tandel wrote: > packet-pflog.c > "ifdef __GCC_WARNING_NO_USE__" around capture_pflog and > capture_old_pflog which aren't used anymore in the code. Why not just delete them? Ciao Joerg -- Joerg Mayer

Re: [Wireshark-dev] [PATCH]fix warnings

2007-03-21 Thread Sebastien Tandel
one version gzipped ;) Sebastien Tandel wrote: > some warning fixes > > packet-http.c > set headers.content_length = 0 before the first potential use of it. > packet-kink.c > "ifdef kerberos" around one function declaration > packet-nbns.c > set headers.{dgm_length|pkt_offset|error_co

[Wireshark-dev] [PATCH]fix warnings II

2007-03-21 Thread Sebastien Tandel
some more fixes packet-ncp.c ncpiph.signature initialized and the following test changed and ncpiph.length = 0 packet-sip in_quoted_string unused variable packet-smb-common.c string_len initialized to 0 packet-smb-pipe.c ent_count initialized to 0 packet-smb.c subcmd unit

[Wireshark-dev] [PATCH]fix warnings

2007-03-21 Thread Sebastien Tandel
some warning fixes packet-http.c set headers.content_length = 0 before the first potential use of it. packet-kink.c "ifdef kerberos" around one function declaration packet-nbns.c set headers.{dgm_length|pkt_offset|error_code} = 0 packet-pflog.c "ifdef __GCC_WARNING_NO_USE__" around