Re: [Wireshark-dev] [PATCH] bugfix : ICMP unreachable and tcp seq not shown

2006-12-16 Thread Jeff Morriss
Sebastien Tandel wrote: > Hi Jeff, > > > Jeff Morriss wrote: > >> Sebastien Tandel wrote: >> >> >>> I am not sure it's broken ... >>> >>> ICMP and ICMPv6 are rather different ... >>> - ICMP states that you have to put the IP header + 64 bits of data >>> - ICMPv6 RFC states, and I quote,

Re: [Wireshark-dev] [PATCH] bugfix : ICMP unreachable and tcp seq not shown

2006-12-15 Thread Sebastien Tandel
Hi Jeff, Jeff Morriss wrote: > Sebastien Tandel wrote: > >> I am not sure it's broken ... >> >> ICMP and ICMPv6 are rather different ... >> - ICMP states that you have to put the IP header + 64 bits of data >> - ICMPv6 RFC states, and I quote, you have to put >> "As much of invoking packet as

Re: [Wireshark-dev] [PATCH] bugfix : ICMP unreachable and tcp seq not shown

2006-12-14 Thread Jeff Morriss
Sebastien Tandel wrote: > I am not sure it's broken ... > > ICMP and ICMPv6 are rather different ... > - ICMP states that you have to put the IP header + 64 bits of data > - ICMPv6 RFC states, and I quote, you have to put > "As much of invoking packet as will fit without the ICMPv6 packet > exce

Re: [Wireshark-dev] [PATCH] bugfix : ICMP unreachable and tcp seq not shown

2006-12-14 Thread Sebastien Tandel
I am not sure it's broken ... ICMP and ICMPv6 are rather different ... - ICMP states that you have to put the IP header + 64 bits of data - ICMPv6 RFC states, and I quote, you have to put "As much of invoking packet as will fit without the ICMPv6 packet exceeding the minimum IPv6 MTU [IPv6]" IPv

Re: [Wireshark-dev] [PATCH] bugfix : ICMP unreachable and tcp seq not shown

2006-12-14 Thread Jeff Morriss
Another question (that I don't have the time to research at the moment): does the same problem exist with IPv6? If so, your patch won't solve that problem (because ICMPv6 shows up as "icmpv6"). Sebastien Tandel wrote: > Here is a little trace created with hping3 :) > > > Stephen Fisher wrote:

Re: [Wireshark-dev] [PATCH] bugfix : ICMP unreachable and tcp seq not shown

2006-12-13 Thread Sebastien Tandel
Here is a little trace created with hping3 :) Stephen Fisher wrote: > On Tue, Dec 12, 2006 at 05:06:49PM +0100, Sebastien Tandel wrote: > > >> This patch should resolve the problem of the TCP seq number which >> is not shown when dissecting an ICMP Unreachable packet. >> > > >> I

Re: [Wireshark-dev] [PATCH] bugfix : ICMP unreachable and tcp seq not shown

2006-12-13 Thread Stephen Fisher
On Tue, Dec 12, 2006 at 05:06:49PM +0100, Sebastien Tandel wrote: > This patch should resolve the problem of the TCP seq number which > is not shown when dissecting an ICMP Unreachable packet. > It is related to the bug 595. Do you have a sample capture you can attach to bug 595 for us to

[Wireshark-dev] [PATCH] bugfix : ICMP unreachable and tcp seq not shown

2006-12-12 Thread Sebastien Tandel
Hi all, This patch should resolve the problem of the TCP seq number which is not shown when dissecting an ICMP Unreachable packet. In fact, the seq number is not added directly to the tree because of the seq analysis. However within an ICMP dissection we never reach the code where the seq num