Re: [Wireshark-dev] [PATCH] New plugin for Homeplug (ptvcursor)

2006-12-04 Thread Sebastien Tandel
Finally, ptvcursor was simple enough to do it right away :) Sebastien Sebastien Tandel wrote: > I've done the necessary changes for the regular dissector. > Concerning the ptvcursor, I will first see how it works ;) > > Sebastien > > Jaap Keuter wrote: > >> Hi, >> >> I've looked at the code. S

Re: [Wireshark-dev] [PATCH] New plugin for Homeplug

2006-12-04 Thread Sebastien Tandel
I've done the necessary changes for the regular dissector. Concerning the ptvcursor, I will first see how it works ;) Sebastien Jaap Keuter wrote: > Hi, > > I've looked at the code. Some things you can improve on. > 1. Get rid of the C++ style comments > 2. Make it into a regular dissector, get

Re: [Wireshark-dev] [PATCH] New plugin for Homeplug

2006-12-04 Thread Jaap Keuter
Hi, I've looked at the code. Some things you can improve on. 1. Get rid of the C++ style comments 2. Make it into a regular dissector, getting rid of all the plugin wiring. 3. Add the ether type to etypes.h i.s.o. defining it yourself. BTW: It's such a simple protocol you could consider using ptv