Re: [Wireshark-dev] [PATCH] Dissector hooks: Small and Simple additions

2007-03-05 Thread Shehjar Tikoo
Hi everyone Guy Harris wrote: > Also, can this be done with the existing tap mechanism, by searching > for particular fields in the generated protocol tree? Thanks. Now I have a basic tap working for me, which uses the generated protocol tree to to get the RPC starting offset and takes it from t

Re: [Wireshark-dev] [PATCH] Dissector hooks: Small and Simple additions

2007-03-05 Thread Guy Harris
On Mar 4, 2007, at 6:44 PM, Shehjar Tikoo wrote: > Thanks. I've been looking at the tap mechanism as a mechanism for the > anonymizer and I see that we'll have to add calls to > tap_queue_packet(..) in every packet-nfs.c:dissect_nfs_ > call to queue the message for the tap listener. No, we won't

Re: [Wireshark-dev] [PATCH] Dissector hooks: Small and Simple additions

2007-03-04 Thread Shehjar Tikoo
Hi Guy Harris wrote: > Also, can this be done with the existing tap mechanism, by searching > for particular fields in the generated protocol tree? Thanks. I've been looking at the tap mechanism as a mechanism for the anonymizer and I see that we'll have to add calls to tap_queue_packet(..) i

Re: [Wireshark-dev] [PATCH] Dissector hooks: Small and Simple additions

2007-03-01 Thread Shehjar Tikoo
Hi Guy Harris wrote: > On Mar 1, 2007, at 4:57 PM, Shehjar Tikoo wrote: > >> One drawback of a per-field hook could be that hooks which need a >> global view or state of the full message might not get access to >> the needed fields. > > Couldn't the private data passed to the hook be used to s

Re: [Wireshark-dev] [PATCH] Dissector hooks: Small and Simple additions

2007-03-01 Thread Guy Harris
On Mar 1, 2007, at 4:57 PM, Shehjar Tikoo wrote: > One drawback of a per-field hook could be that hooks which need a > global > view or state of the full message might not get access to the needed > fields. Couldn't the private data passed to the hook be used to store the kind of state neede

Re: [Wireshark-dev] [PATCH] Dissector hooks: Small and Simple additions

2007-03-01 Thread Shehjar Tikoo
Hi Sebastien Tandel wrote: > Couldn't we pass one of the fields in the private data? Firstly, within the per-field hook/callback, the knowledge about what the current field is ,will be provided by the hfindex arg, assuming the hook/callback gets called by one of the proto_tree_add functions and t

Re: [Wireshark-dev] [PATCH] Dissector hooks: Small and Simple additions

2007-03-01 Thread Sebastien Tandel
Hi, Couldn't we pass one of the fields in the private data? Regards, Sebastien Tandel > Guy Harris wrote: > >> On Feb 21, 2007, at 6:53 PM, Shehjar Tikoo wrote: >> >>> It brings in the dissector hooks feature discussed here a few weeks >>> back. Its a small patch that includes basic

Re: [Wireshark-dev] [PATCH] Dissector hooks: Small and Simple additions

2007-03-01 Thread Shehjar Tikoo
Guy Harris wrote: > On Feb 21, 2007, at 6:53 PM, Shehjar Tikoo wrote: >> It brings in the dissector hooks feature discussed here a few weeks >> back. Its a small patch that includes basic infra for hooks and a >> sample hook for the NFS dissector. >> >> Right now, the hook gets called(..using c

Re: [Wireshark-dev] [PATCH] Dissector hooks: Small and Simple additions

2007-02-27 Thread Guy Harris
On Feb 21, 2007, at 6:53 PM, Shehjar Tikoo wrote: > It brings in the dissector hooks feature discussed here a few weeks > back. Its a small patch that includes basic infra for hooks and a > sample hook for the NFS dissector. > > Right now, the hook gets called(..using call_dissector_hooks().

Re: [Wireshark-dev] [PATCH] Dissector hooks: Small and Simple additions

2007-02-27 Thread Shehjar Tikoo
Hi That thread is here: http://thread.gmane.org/gmane.network.wireshark.devel/3695 Here is my first post about what I am trying to do. http://thread.gmane.org/gmane.network.wireshark.devel/3464 Regards Shehjar Stephen Fisher wrote: > On Thu, Feb 22, 2007 at 01:53:29PM +1100, Shehjar Tikoo wrote

Re: [Wireshark-dev] [PATCH] Dissector hooks: Small and Simple additions

2007-02-27 Thread Stephen Fisher
On Thu, Feb 22, 2007 at 01:53:29PM +1100, Shehjar Tikoo wrote: > It brings in the dissector hooks feature discussed here a few weeks > back. Its a small patch that includes basic infra for hooks and a > sample hook for the NFS dissector. I'm sorry, I don't recall the messages talking about thi

[Wireshark-dev] [PATCH] Dissector hooks: Small and Simple additions

2007-02-21 Thread Shehjar Tikoo
Hi all Please see the attached diff for the changes I made to revision 20887 from the repository. It brings in the dissector hooks feature discussed here a few weeks back. Its a small patch that includes basic infra for hooks and a sample hook for the NFS dissector. Right now, the hook ge