Re: [Wireshark-dev] [PATCH] DMP - Fix for long SICs

2007-08-15 Thread Stig Bjørlykke
Den 24. jul. 2007 kl. 07.01 skrev BRUMBY, Ian: > Problem: The DMP dissector fails to correctly decode 4 character and > longer SICs. Checked in as r22512. -- Stig Bjørlykke ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wires

[Wireshark-dev] [PATCH] DMP - Fix for long SICs

2007-07-23 Thread BRUMBY, Ian
Problem: The DMP dissector fails to correctly decode 4 character and longer SICs. First reason: There is a 32 bit overflow in the following code: p = (gint) pow (multiplier, no_char - 1 - i); Multiplier is either 36.0 or 74.0, and "no_char" can be as high as 8. Second reason: An incorre