Re: [Wireshark-dev] Building OpenFlow 1.0 dissector for Wireshark 1.10.0 on Ubuntu 13.04

2013-07-10 Thread Sebastien Tandel
to handle the rather frequent changes in the spec and as such in the dissector code. Regards, Sebastien Tandel Sent from my iPhone On 10 juil. 2013, at 18:45, Anders Broman wrote: > Hi, > That plugin has newer been offered to Wireshark and we have no knowledge of > it. Any questions

Re: [Wireshark-dev] How to get absolute frame/packet index in buffer?

2007-10-18 Thread Sebastien Dubois
L PROTECTED]> > Date: Thu, 18 Oct 2007 12:38:36 -0700 Sebastien Dubois wrote: The protocol I'm trying to dissect has messages that include pointers that point to other element within the message. These pointers values are the offset from the start of the message I'm tryi

Re: [Wireshark-dev] How to get absolute frame/packet index in buffer?

2007-10-18 Thread Sebastien Dubois
D]> > Date: Thu, 18 Oct 2007 11:45:07 -0700 Sebastien Dubois wrote: I'm currently developping a plugin and I have a little question: Is it possible, from a given dissector, to get the number of bytes already dissected by lower-layer dissectors ? In other words, can I get the

[Wireshark-dev] How to get absolute frame/packet index in buffer?

2007-10-18 Thread Sebastien Dubois
point of view, for instance, the relative index to the start of the tvbuff passed to it is of course 0, which could be let's say index 50 relative to the absolute start of the ethernet frame/packet. So is there an API call/variable that I can check to get this index? Thanks in advance

Re: [Wireshark-dev] Plugin dissector registration order problem

2007-10-09 Thread Sebastien Dubois
Hi, Thanks for the reply. I was able to make my stuff work using heuristic dissectors, but I'll try what you recommend as well. Thx, /Sebastien _ Date: Tue, 9 Oct 2007 13:21:23 -0400 From: "Maynard, Chris" <[EMAIL PROTE

Re: [Wireshark-dev] Plugin dissector registration order problem

2007-10-05 Thread Sebastien Dubois
hx, /Sebas ---- Sebastien Dubois schrieb: Hi, I'm currently having problems trying to implement a new plugin as a sub-dissector to another plugin. The first plugin (let's call it foo_proto) registers itself and adds itself as a dissector that u

[Wireshark-dev] Plugin dissector registration order problem

2007-10-04 Thread Sebastien Dubois
registered when the second one (foo2) calls dissector_add on it. So, how does this work? How can you add a plugin dissector to another plugin dissector? Is it at all possible? Thx, /Sebastien ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] When will Wireshark 0.99.7 become a stable release

2007-08-22 Thread Sebastien Tandel
My organization will not permit 'beta' software to be installed on production computers. Since I want to have UNISTIM decoding, I need 0.99.7. or download the sources of 0.99.6 release and integrate the UNISTIM in it. (probably quicker) Regards, Sebast

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1741] Privilege separation patch

2007-08-15 Thread Sebastien Tandel
a BSDism, and has been picked up by other OSes, so it's not OS X-only; we should probably use it if available. Should the group set be changed *before* setting the effective user ID? ___ Wireshark-dev mailing list Wiresh

Re: [Wireshark-dev] bug in SHIM6 control message - UPD REQ and UPD ACK

2007-08-01 Thread Sebastien Tandel
correction done in rev 22438. thanks for the report. Regards, Sebastien Tandel On Aug 1, 2007, at 10:58 AM, [EMAIL PROTECTED] wrote: there is a mistacke in the assigned number of the update request and update ack shim6 control message. Accordingly to draft-ietf-shim6-proto-08 page 93 the

Re: [Wireshark-dev] bug in SHIM6 control message - UPD REQ and UPD ACK

2007-08-01 Thread Sebastien Tandel
Hi, I've spot it. I will correct it as soon as I have two minutes. ... but it is indeed better to file a bug report :) Regards, Sebastien Tandel On Aug 1, 2007, at 2:22 PM, Jaap Keuter wrote: Hi, Better file a bugreport on that. Thanx, Jaap On Wed, 1 Aug 2007 [EMAIL PROTECTED]

Re: [Wireshark-dev] tvb in a conversation

2007-07-27 Thread Sebastien Tandel
d Software EngineerPlaneetbaan 4 +31 (0)23 70743422132 HZ Hoofddorp ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev Regards, Sebast

Re: [Wireshark-dev] Err Duplicate protocol name "Mindspeed Comcerto API Header"!

2007-07-13 Thread Sebastien Tandel
I think you have to remove any proto_register_* and proto_reg_handoff_* related to your dissector from epan/dissectors/register.c /or/ do a "make maintainer-clean" Regards, Sebastien Tandel [EMAIL PROTECTED] a écrit : > Hi, > > I am in process to move and upgrade the CSME

Re: [Wireshark-dev] GPL license question

2007-07-12 Thread Sebastien Tandel
that non-GPL kernel module infringes the GPL license. ;) http://thread.gmane.org/gmane.linux.kernel/475654/focus=475796 Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] GPL license question

2007-07-12 Thread Sebastien Tandel
ut of the generic dumb plugin and would write the result of the dissection in the other file. This way the independent executable could be then non-GPL. Is it really useful? That's another question. But at least, you're pretty sure that the FSF won&#x

Re: [Wireshark-dev] GPL license question

2007-07-11 Thread Sebastien Tandel
reshark API, we might start again this discussion but I doubt you can write a functional wireshark plugin dissector without linking to libwireshark. Regards, Sebastien Tandel [EMAIL PROTECTED] wrote: > > [EMAIL PROTECTED] wrote on 07/11/2007 01:16:26 PM: > >> Hi, >> &

Re: [Wireshark-dev] GPL license question

2007-07-11 Thread Sebastien Tandel
.. without your permission :) Regards, Sebastien Tandel Jon Andersen wrote: > I'm concerned about the requirements of the GPLv2 license. > > If I write a plugin for Wireshark, which compiles to a plugin DLL only, > and then I distribute the plugin DLL, am I required by the GPL

Re: [Wireshark-dev] size of wireshark installation files

2007-07-10 Thread Sebastien Tandel
backtrace command: > gdb tshark >>run >>backtrace >>q > It Will give you the file and the line that cause the assert to fail. > > Once you removed all the calls that make asserts fail, Tshark should run > properly. Sounds a possible

Re: [Wireshark-dev] [Wireshark-users] Lua compile problems

2007-07-09 Thread Sebastien Tandel
7;ll check this one. One question though : Can we imagine enabling lua option by default if found on the system? Regards, Sebastien Tandel Luis EG Ontanon wrote: > can you try --with-lua=/usr/ > > On 7/9/07, Piers Kittel <[EMAIL PROTECTED]> wrote: >> Hello Jaap and Luis, >

Re: [Wireshark-dev] how to disable dissectors when I build TShark ?

2007-07-03 Thread Sebastien Tandel
roblem, I would like to know if there is another way. I agree with you that it should be possible but someone has to spend some time to resolve these "historical dependencies" problems first. ;) Regards, Sebastien Tandel ___ Wireshark-dev mail

Re: [Wireshark-dev] Wireshark conference

2007-06-30 Thread Sebastien Tandel
we'll have at our disposal. Maybe we should think about the goals of this hackathon before it starts. Regards, Sebastien Tandel On Jun 30, 2007, at 7:22 AM, Ulf Lamping wrote: > Gerald Combs schrieb: >> This is entirely hypothetical, but if someone were to host a 3-day

Re: [Wireshark-dev] [Wireshark-commits] rev 22127: /trunk/ /trunk/: configure.in

2007-06-21 Thread Sebastien Tandel
Hi Steve, It should be fixed in rev22157. Could you confirm it is fixed? Regards, Sebastien Tandel On 19 Jun 2007, at 00:34, Stephen Fisher wrote: Could you do some more testing for this change? It seems to have stopped the inclusion of IPSec ESP support in my Wireshark builds using the

Re: [Wireshark-dev] patch for BGP MDT decods

2007-06-09 Thread Sebastien Tandel
Hi, Do yo intend to implement the connector attribute? Regards, Sebastien Tandel On 04 Jun 2007, at 13:27, Aamer Akhter wrote: Joerg, Thanks for catching this. It was a typo. Revised diff attached. "Joerg Mayer" <[EMAIL PROTECTED]> wrote in message news:<[EMAIL PR

Re: [Wireshark-dev] [PATCH] Fix compilation failures on x86_64-unknown-linux-gnu

2007-05-29 Thread Sebastien Tandel
sorry for the inconvenience. Regards, Sebastien Tandel On 29 May 2007, at 05:39, Jeff Morriss wrote: Guy Harris wrote: Jeff Morriss wrote: Problem is that how you print 64-bit numbers varies. %llu doesn't always work ...and neither does "long long" as a data type. (

Re: [Wireshark-dev] [PATCH] Fix compilation failures on x86_64-unknown-linux-gnu

2007-05-28 Thread Sebastien Tandel
checked in rev 21975. Thanks! Regards, Sebastien Tandel On 24 May 2007, at 09:47, David Howells wrote: Fix compilation failures when building wireshark-0.99.6-SVN-21916 on an x86_64-unknown-linux-gnu target with gcc version 4.1.2 20070403 (Red Hat 4.1.2-8). The failures fall into two

[Wireshark-dev] Dissector Generator

2007-05-22 Thread Sebastien Tandel
C Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] wireshark help needed

2007-05-22 Thread Sebastien Tandel
I indeed haven't been spammed personally and did not understand as it while reading your mail. That's definitely not a way to get an answer. Regards, Sebastien Tandel On 22 May 2007, at 14:58, Richard van der Hoff wrote: Sebastien Tandel wrote: On the other hand, I don'

Re: [Wireshark-dev] wireshark help needed

2007-05-22 Thread Sebastien Tandel
in a database. Regards, Sebastien Tandel On 22 May 2007, at 12:23, Richard van der Hoff wrote: cedrik helou wrote: We are a group of 3 Lebanese computer engineering students; we are working on a project concerning the development of wireshark. We are facing difficulties finding the wir

Re: [Wireshark-dev] [Wireshark-commits] rev 21821: /trunk/ /trunk/: configure.in /trunk/wiretap/: configure.in

2007-05-19 Thread Sebastien Tandel
ese warnings (I've had to find and prepare a solaris 9 before :)), I've disabled temporarily cast-align warnings. Of course, there is no problem for me to put it in extra warnings temporarily :) Regards, Sebastien Tandel On 19 May 2007, at 04:32, Joerg Mayer wrote: On Fri,

Re: [Wireshark-dev] [PATCH] Improved support for MIPv4

2007-05-18 Thread Sebastien Tandel
. That's what I wanted to point out. Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [PATCH] Improved support for MIPv4

2007-05-18 Thread Sebastien Tandel
re doesn't seem to be anything at all about > Mobile IP on the wiki ;-) Maybe it's time to put something then :) >> - Have you fuzz tested your changes? > > No, sorry. I haven't had the time or resources to do that. That's not too much resources ... simply run f

Re: [Wireshark-dev] [PATCH] Improved support for MIPv4

2007-05-16 Thread Sebastien Tandel
a display length field of 1. Some questions : - Do you have traces you can share? If so, can you put them on the captures wiki page? - Is there a description on the wiki page? - Have you fuzz tested your changes? Regards, Sebastien Tandel On 16 May 2007, at 05:21, Ville Nuorvala wrote

Re: [Wireshark-dev] pcap_breakloop and MacOSX

2007-04-22 Thread Sebastien Tandel
e of course), the pcap header for the version 0.7 along with the library /and/ also the pcap library version 0.8. But everyone in this situation may redirect libpcap.so towards libpcap.so.0.8. I know it's completely silly and should be the most rare case but I've already seen a FAQ guide

Re: [Wireshark-dev] pcap_breakloop and MacOSX

2007-04-20 Thread Sebastien Tandel
anyone have a better warning text? Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] pcap_breakloop and MacOSX

2007-04-14 Thread Sebastien Tandel
Hi, the ./configure on MacOSX finds the function pcap_breakloop but when arriving at compiling capture_loop.c, gcc tells that it is an implicit declaration. Is there some header file missing? (pcap.h is included) Regards, Sebastien Tandel

[Wireshark-dev] lex on ubuntu buildbot

2007-04-14 Thread Sebastien Tandel
Hi, does anyone know what's the lexer (and version) used on the ubuntu buildbot machine? Regards, Sebastien Tandel ___ Wireshark-dev mailing list [EMAIL PROTECTED] http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] wireshark compilation on Unix

2007-04-13 Thread Sebastien Tandel
s, hoping there won't be any :) In case of emergency, though, ./configure --without-warnings-as-errors should help you Regards, Sebastien Tandel ___ Wireshark-dev mailing list [EMAIL PROTECTED] http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] packet-ssl

2007-04-12 Thread Sebastien Tandel
Hi, there are a few unused parameters in process_ssl_payload function. Is there someone working on it and wanting to use them in a /very/ near future? For now, I let these parameters with the _U_ flag (but only for a few days :)). Regards, Sebastien Tandel

Re: [Wireshark-dev] [PATCH][UPDATE] analyzing SHIM6 protocol

2007-04-12 Thread Sebastien Tandel
our thesis? :)) Regards, Sebastien Tandel Matthijs Mekking wrote: > Hello, > > > - in hf_register_info, there are two items of the same name : > > hf_ipv6_shim6_opt_len > > This is fixed in the source and in the patch. > > > - you should create an helper funct

Re: [Wireshark-dev] packet-sqloracle.c

2007-04-12 Thread Sebastien Tandel
ach itself on a field which does not exist and which should be defined in packet-tns but isn't. As I really don't know this protocol related to oracle I can't help more. Regards, Sebastien Tandel ___ Wireshark-dev mailing list [EMAIL P

Re: [Wireshark-dev] plugin / wireshark versions

2007-04-12 Thread Sebastien Tandel
Hi, > Should be possible to reuse a plugin dll with multiple version of wireshark? > possible but take a look at guy's explanation on the subject http://www.wireshark.org/lists/wireshark-dev/200701/msg03851.html Regards, Sebas

[Wireshark-dev] win32 step-by-step guide inaccurate

2007-04-12 Thread Sebastien Tandel
hon24 repo. It's therefore mandatory to install python2.4 if we want to continue the installation. Maybe both versions of python should be tested avoiding imposing python2.5 to the ones who don't want to upgrade now. Regards, Sebastien Tandel _

Re: [Wireshark-dev] Protocol for DRDA / DB2

2007-04-03 Thread Sebastien Tandel
Hi, commit as rev21331. Thanks. Regards, Sebastien Tandel metatech wrote: > Hi Sebastien, > > Here is a re-submission of my new DRDA dissector with your comments > addressed. > For the compiler warnings, I removed them all, at least what MSVC6 is > reporting. If your com

Re: [Wireshark-dev] [Wireshark-commits] rev 21328: /trunk/epan/dissectors/ /trunk/epan/dissectors/: Makefile.nmake

2007-04-03 Thread Sebastien Tandel
thx for the Ytpo xFi. Regards, Sebastien Tandel [EMAIL PROTECTED] wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=21328 > > User: lego > Date: 2007/04/03 08:52 PM > > Log: > xFi a Ytpo > > Directory: /trunk/epan/dissectors/ > C

Re: [Wireshark-dev] Dissector over Ethernet

2007-04-03 Thread Sebastien Tandel
proto_tree_add_[uint|string|...] whenever possible. Regards, Sebastien Tandel CANDIA, Fabrice wrote: > Thanks Abhik, ARP dissector is exactly what I need ! > > > -Message d'origine- > De : [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] la part de Abhik Sarkar > Envo

Re: [Wireshark-dev] File in makefile not in SVN

2007-04-03 Thread Sebastien Tandel
sorry, the review of the 'non-patch' of packet-drda.c where I've had to change the Makefile. Regards, Sebastien Tandel Anders Broman wrote: > Hi, > packet-drda.c is missing from SVN but included in latest commit of > makefile.common.

Re: [Wireshark-dev] [Patch] pragma warning

2007-04-03 Thread Sebastien Tandel
Now these changes are in the svn tree. Note that I've moved some dissectors from DISSECTOR_SRC to CLEAN_DISSECTOR_SRC but there are many others which could already be moved to CLEAN_DISSECTOR_SRC. Regards, Sebastien Tandel >> I made it partly for the Unix side. (Makefile

Re: [Wireshark-dev] [PATCH] Fix for bug 1136 : tcp-checksum 0xffff

2007-04-01 Thread Sebastien Tandel
It has been committed in rev21295. Thanks. Regards, Sebastien Tandel Sake Blok wrote: > Hi Sebastien, > > >> seems good :) >> > > :) > > >> Last doubt anyway, your msg 'maybe caused etc...' seems a lot of >> explanation for

Re: [Wireshark-dev] [PATCH] Fix for bug 598

2007-04-01 Thread Sebastien Tandel
It has been committed as rev21277 by wmeier. Regards, Sebastien Tandel Sake Blok wrote: > Hi, > > I have written a patch for bug 598 (getting 2 linefeeds when copying > data from the "follow tcp stream" display). It seems GTK is converting > all CR's to LF's

Re: [Wireshark-dev] [PATCH] Fix for bug 1136 : tcp-checksum 0xffff

2007-04-01 Thread Sebastien Tandel
Hi Sake, seems good :) Last doubt anyway, your msg 'maybe caused etc...' seems a lot of explanation for me at the place you've put it. What do you think of the same message in the following subtree (sister node of tcp.bad_cksum and tcp.good_cksum) or in the expert item? Reg

Re: [Wireshark-dev] Protocol for DRDA / DB2

2007-04-01 Thread Sebastien Tandel
a *patch* ;) svn add epan/dissectors/packet-drda.c svn diff | gzip > packet-drda.diff.gz It will also include the modifications made in the Makefile.common Regards, Sebastien Tandel metatech wrote: > Hello, > > In attachment you will find a dissector for the DRDA protocol. > This is t

Re: [Wireshark-dev] [PATCH] Fix for bug 1136 : tcp-checksum 0xffff

2007-03-31 Thread Sebastien Tandel
Hi Sake, IMO, it would be better to create an expert item associated to this specific incorrect checksum. Regards, Sebastien Tandel Sake Blok wrote: > Hi, > > I did some research to tcp-checksum 0x. This checksum should not > appear in tcp-headers. RFC 1624 explains th

Re: [Wireshark-dev] Filter does not work on current svn version

2007-03-30 Thread Sebastien Tandel
s" on the svn, could you test please? Regards, Sebastien Tandel Anders Broman (AL/EAB) wrote: > Hi, > Applying a filter in the current build results in: > 13:13:01 Err Per-packet memory corrupted. > > > Press any key to ex

Re: [Wireshark-dev] Mobile IPv6

2007-03-29 Thread Sebastien Tandel
just a precision, the counter of mobile IPv6 is not incremented at all for the unknown option. Sebastien Tandel wrote: > Hi, > > >I found a strange (to me) thing in the code of the IPv6 dissector. In > the options decode function (dissect_opts), there are two "tvb offset&

[Wireshark-dev] Mobile IPv6

2007-03-29 Thread Sebastien Tandel
own option). Does anybody know whether this behavior is really accurate? Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-28 Thread Sebastien Tandel
;t generate warning anymore, we have to move the filename dissector from DISSECTOR_SRC to CLEAN_DISSECTOR_SRC in epan/dissectors/Makefile.common. You can define specific cflags with, for example, libpidldissectors_la_CFLAGS. The problem is that I really don't know how to do this for Makefile.n

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-28 Thread Sebastien Tandel
stead be to > remove them completely from epan/dissectors and make asn part of the > build process. > All these dissectors have their own makefile down in asn/* where one > can set additional or different compiler flags compared to those used > by the normal epan/dissectors. > These a

[Wireshark-dev] packet-amqp.c

2007-03-28 Thread Sebastien Tandel
Permissions have not been correctly set on packet-amqp.c Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] [PATCH] bunch of warnings fixes

2007-03-26 Thread Sebastien Tandel
cket-wbxml packet-who packet-x11 packet-x25 packet-xdmcp packet-xml packet-yhoo Regards, Sebastien Tandel rev21208-dissectors-warnings-fixes.diff.gz Description: application/gzip patch-per-file.tar.gz Description: application/gzip ___ Wireshark-dev ma

Re: [Wireshark-dev] [Wireshark-commits] rev 21195: /trunk/ /trunk/: configure.in

2007-03-26 Thread Sebastien Tandel
Note that '==' is not portable on BSD unix. Jeff Morriss wrote: > Thanks & sorry for the trouble. Unfortunately something was stripping > the []'s out of the test in "configure.in" so the resulting "configure" > just had "if $? == 0 ;" which didn't work. I just checked in a new > version wh

Re: [Wireshark-dev] [Wireshark-commits] rev 21195: /trunk/ /trunk/: configure.in

2007-03-25 Thread Sebastien Tandel
> Me and automake/configure are not on friendly terms. > Is there someone who is on friendly terms with them? ;) ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] [PATCH] dissectors warnings fix

2007-03-23 Thread Sebastien Tandel
patch fixing warnings for the following dissectors : packet-3ga11.c packet-aim-buddylist.c packet-aim-chat.c packet-aim-messaging.c packet-aim-signon.c packet-ajp13.c 3ga11-aim-ajp13-warnings-fix.diff.gz Description: application/gzip _

[Wireshark-dev] [PATCH] ASN1 plugins warnings fixes

2007-03-23 Thread Sebastien Tandel
Hi, fixes gcc warnings and get rid of declaration after statements Regards, Sebastien Tandel plugin-asn1.diff.gz Description: application/gzip ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo

Re: [Wireshark-dev] ASN1 warning question

2007-03-23 Thread Sebastien Tandel
> The only problem seems to be that it is a guchar and > the 6th argument to proto_tree_add_string_format() expects a char. > Which parameter do you mean putting strlen(octets) in? > Right. I don't know why I've seen it as the length parameter. Reg

[Wireshark-dev] ASN1 warning question

2007-03-23 Thread Sebastien Tandel
s) of proto_tree_add_string_format is the guchar array we have converted with showoctets. Is it correct? Don't we have to put it to strlen(octets)? (it appears that octets has to be NULL-teminated). Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wir

Re: [Wireshark-dev] [PATCH] ./configure --with-warnings-as-errors

2007-03-23 Thread Sebastien Tandel
Then there are others in the list : bad RVALS declaration unused variables strict aliasing warning fix Regards, Sebastien Tandel Stephen Fisher wrote: > On Fri, Mar 23, 2007 at 07:04:38PM +0100, Sebastien Tandel wrote: > > >> I've posted a patch (subject : P

Re: [Wireshark-dev] [PATCH] Plugins Warnings

2007-03-23 Thread Sebastien Tandel
Stephen Fisher wrote: > On Fri, Mar 23, 2007 at 05:33:41PM +0100, Sebastien Tandel wrote: > > >> First patch fixes warning of profinet and megaco plugins to compile >> again with gcc-4.1.2. >> > > Committed as SVN revision 21155. Thanks for your help! &g

Re: [Wireshark-dev] [PATCH] ./configure --with-warnings-as-errors

2007-03-23 Thread Sebastien Tandel
I've posted a patch (subject : Plugins Warnings) for fixing warnings in profinet and megaco. If you won't integrate it, please say it that I stop loosing my time. Regards, Sebastien Tandel Stephen Fisher wrote: > On Fri, Mar 23, 2007 at 05:32:12PM +0100, Sebastien

[Wireshark-dev] [PATCH] Plugins Warnings

2007-03-23 Thread Sebastien Tandel
it be changed to guint in the structure _ASN1_SCK and in the aforementioned functions? Regards, Sebastien Tandel profinet-megaco.diff.gz Description: application/gzip ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshar

[Wireshark-dev] [PATCH] ./configure --with-warnings-as-errors

2007-03-23 Thread Sebastien Tandel
een replaced by HAVE_WARNINGS_AS_ERRORS. With this switch, people won't suffer from unexpected warnings when downloading svn sources during the transition time ;) Regards, Sebastien Tandel configure-warnings-as-errors.diff.gz Description: application/gzip _

Re: [Wireshark-dev] [PATCH][UPDATE] analyzing SHIM6 protocol

2007-03-22 Thread Sebastien Tandel
FT_IPv6. Regards, Sebastien Tandel Matthijs Mekking wrote: > Thanks for the advice. I have attached a new patch, were you can apply > shim6 elements as filter easier. > > more info at www.pletterpet.nl/shim6/ > > Regards, > > Matthijs Mekking > [EMAIL PROTECTED] >

Re: [Wireshark-dev] [PATCH][UPDATE] analyzing SHIM6 protocol

2007-03-22 Thread Sebastien Tandel
Hi, your patch is malformed line 63. You've probably deleted some hf_items or some comments directly in the patch but that must be reflected in the "accounting numbers" of the patch format ;) Regards, Sebastien Tandel Matthijs Mekking wrote: > Thanks for the advice. I h

Re: [Wireshark-dev] My postings are getting lost

2007-03-22 Thread Sebastien Tandel
Hi, You may post it on the bugzilla. http://bugs.wireshark.org/bugzilla/ Regards, Sebastien Tandel Bill Fassler wrote: > I have repeatedly tried to post a response to Joerg Mayer regarding decoding > traffic thru OpenVPN. Although I provided a one packet sample, Joerg > requeste

Re: [Wireshark-dev] [PATCH] bad RVALS declaration

2007-03-22 Thread Sebastien Tandel
what a shame, even the comment was copy pasted :-p patch with accurate comment and declaration. Regards, Sebastien Tandel Sebastien Tandel wrote: > copy paste hit again, here is a patch with the accurate declaration of > RVALS in proto.h > Thx gcc-4.1.2 for finding new ways of g

[Wireshark-dev] [PATCH] bad RVALS declaration

2007-03-22 Thread Sebastien Tandel
copy paste hit again, here is a patch with the accurate declaration of RVALS in proto.h Thx gcc-4.1.2 for finding new ways of generating strict aliasing warnings :) Regards, Sebastien Tandel rvals-strict-aliasing.diff.gz Description: application/gzip

[Wireshark-dev] [PATCH] unused variables

2007-03-22 Thread Sebastien Tandel
stripped away some unused variables/parameters + in prefs.c suggestion of parentheses makes gcc happy Regards, Sebastien Tandel unused-variables.diff.gz Description: application/gzip ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http

Re: [Wireshark-dev] [PATCH]fix warnings

2007-03-22 Thread Sebastien Tandel
same patch except that capture_*_pflog are stripped Joerg Mayer wrote: > On Thu, Mar 22, 2007 at 12:58:47PM +0100, Sebastien Tandel wrote: > >> As it's not a simple unused variable and I had no idea if these >> functions could ever be used again, I preferred to let them

[Wireshark-dev] [PATCH] strict aliasing warning fix

2007-03-22 Thread Sebastien Tandel
patch for (void**) castings generating strict aliasing warning. Simply cast with (void*) Regards, Sebastien Tandel type-punned.diff.gz Description: application/gzip ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org

Re: [Wireshark-dev] [PATCH]fix warnings

2007-03-22 Thread Sebastien Tandel
As it's not a simple unused variable and I had no idea if these functions could ever be used again, I preferred to let them in the code. But if it's sure that they will never be used. I can delete them. Regards, Sebastien Tandel Joerg Mayer wrote: > On Thu, Mar 22, 2007 at 01:

[Wireshark-dev] [PATCH] ipv6 dissector update

2007-03-21 Thread Sebastien Tandel
expert info for invalid jumbo value and invalid router alert length. - correction of invalid jumbo payload length - get rid of variable declaration in a block Regards, Sebastien Tandel dissector-ipv6.diff.gz Description: application/gzip ___ Wireshark

Re: [Wireshark-dev] [PATCH]fix warnings

2007-03-21 Thread Sebastien Tandel
one version gzipped ;) Sebastien Tandel wrote: > some warning fixes > > packet-http.c > set headers.content_length = 0 before the first potential use of it. > packet-kink.c > "ifdef kerberos" around one function declaration > packet-nbns.c >

[Wireshark-dev] [PATCH]fix warnings II

2007-03-21 Thread Sebastien Tandel
some more fixes packet-ncp.c ncpiph.signature initialized and the following test changed and ncpiph.length = 0 packet-sip in_quoted_string unused variable packet-smb-common.c string_len initialized to 0 packet-smb-pipe.c ent_count initialized to 0 packet-smb.c subcmd unit

[Wireshark-dev] [PATCH]fix warnings

2007-03-21 Thread Sebastien Tandel
ARNING_NO_USE__" around capture_pflog and capture_old_pflog which aren't used anymore in the code. Regards, Sebastien Tandel Index: epan/dissectors/packet-nbns.c === --- epan/dissectors/packet-nbns.c (révision 21097) +++ epan

Re: [Wireshark-dev] Prevent compiler warnings by using "stop on warnings"/"treat warnings as errors" compiler option?

2007-03-20 Thread Sebastien Tandel
5 until gcc-4.1.2 and for several platforms (32 or 64bits) : Linux (Debian, Fedora, CentOS, Ubuntu?), Solaris, Mac OS X and Windows (Cygwin). maybe we've not been confronted to all the tricky gcc warnings ;) Regards, Sebastien Tandel Joerg Mayer wrote: > On Tue, Mar 20, 2007 at 01:01

Re: [Wireshark-dev] [PATCH] analyzing SHIM6 protocol

2007-03-20 Thread Sebastien Tandel
I think most the proto_tree_add_text could be replaced by proto_tree_add_item which could allow (i.e. at least Sébastien Barré ;)) to perform an easy search on specific items. ;) Regards, Sebastien Tandel Matthijs Mekking wrote: > Hello, > > The last two months I have been working o

Re: [Wireshark-dev] Prevent compiler warnings by using "stop on warnings"/"treat warnings as errors" compiler option?

2007-03-19 Thread Sebastien Tandel
ich inspects use of "dangerous" C functions taking into account only the set of changes induced by the patch. (available in the last version). We could extend it easily for wireshark purposes (like inspecting if the patch is using classic memory allocation functions or deprecated wireshark

Re: [Wireshark-dev] crypt-sha1

2007-03-16 Thread Sebastien Tandel
> The wiki page has been updated. Maybe we should have a > > svn diff | gzip | send-the-patch-to-bugzilla > > pipeline. :) What a great idea! :-D Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wir

Re: [Wireshark-dev] crypt-sha1

2007-03-16 Thread Sebastien Tandel
I've never said there was a lot of changes ;) Concerning the compressed patches, I will keep in mind for the next time. However, if you want to avoid receiving others text patches, it should be mentioned in the doc ;) http://wiki.wireshark.org/SendingFilesToWireshark#patches Regards, Seba

Re: [Wireshark-dev] crypt-sha1

2007-03-16 Thread Sebastien Tandel
Thanks for the answer. And here is the patch to change guint -> guint32 in the hmac function. Regards, Sebastien Tandel Luis Ontanon wrote: > If they are in the hmac code that's probably my fault when I put it > back in the repo. > > I don't think it will be causing a

[Wireshark-dev] crypt-sha1

2007-03-16 Thread Sebastien Tandel
guint instead of guint32? Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] [PATCH][UPDATE] ptvcursor and subtrees

2007-03-14 Thread Sebastien Tandel
Hi, Series of three patches concerning the creation of subtrees via the ptvcursor API : 1) ptvcursor-subtrees.diff : Update to get rid of potential memory leaks with g_renew but also with g_new in ptvcursor_new(). New features supported by ptvcursor API : - ptvcursor_push_subtree(), ptvcur

Re: [Wireshark-dev] Re : nmake -distclean failing

2007-03-12 Thread Sebastien Tandel
long ... Is there something else to notice before this fatal rm command? Regards, Sebastien Tandel Thibault Cogoluenhès wrote: > Hi, > >I had the same problem. The problem is the cmd.exe from windows > 2000. The length of the command in the cmd.exe from XP can be longer > th

Re: [Wireshark-dev] Query regarding raw socket sending and receiving

2007-03-12 Thread Sebastien Tandel
Hi, I fear you're not on the accurate mailing-list for these questions ... google these keywords 'unix network programming' or buy 'Unix network programming' by Stevens, Prentice-Hall Regards, Sebastien Tandel sara vanan wrote: > Dear Sir, > > I am doing

Re: [Wireshark-dev] [PATCH][UPDATE] ptvcursor : one step further?

2007-03-11 Thread Sebastien Tandel
>> I've taking a look at emem.c and it clearly doesn't attach information >> about the chunk of memory being allocated. Then ep_realloc may only be >> the "allocate new, copy" solution. >> > > Without that information, how do you know how much to copy (if you don't > pass the old size explic

Re: [Wireshark-dev] [PATCH][UPDATE] ptvcursor : one step further?

2007-03-11 Thread Sebastien Tandel
out the chunk of memory being allocated. Then ep_realloc may only be the "allocate new, copy" solution. Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [PATCH][UPDATE] ptvcursor : one step further?

2007-03-11 Thread Sebastien Tandel
anyway, having a ep_realloc could be interesting simply for the coherence with existing memory allocation libraries. Even if it only does "allocate new, copy". (without speaking of potential user's bugs :)) >> Jeff Morriss wrote: >> >>> Sebastien Tandel w

Re: [Wireshark-dev] [PATCH][UPDATE] ptvcursor : one step further?

2007-03-11 Thread Sebastien Tandel
ter the existing item? Which could be in practice slower than the "dumb" solution : always "allocate new, copy". > So, no, I don't see any reason not to implement ep_realloc() We may start with the simplest solution "allocate new, copy". What do you think of it? Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [PATCH][UPDATE] ptvcursor : one step further?

2007-03-11 Thread Sebastien Tandel
of the complexity to implement one either ... Regards, Sebastien Tandel Jeff Morriss wrote: > Sebastien Tandel wrote: > >> Hi, >> >> I've updated the patch for ptvcursor taking into account the ideas of Guy. >> >> Features supported by ptvcursor

Re: [Wireshark-dev] Query on status of patches

2007-03-11 Thread Sebastien Tandel
all this "community thing" is not /only/ a coding party but also a philosophical idea for the well-being of the humanity, isn't it? :-D Regards, Sebastien Tandel Jaap Keuter wrote: > Hi, > > I can see your frustration. You like to be appreciated for the work done > on cre

Re: [Wireshark-dev] Compile error on FC4 (since rev 20951)

2007-03-08 Thread Sebastien Tandel
Hi, the following should help : http://www.wireshark.org/lists/wireshark-dev/200703/msg00028.html Regards, Sebastien Tandel Sake Blok wrote: > Hi All, > > Does anyone else have problems compiling Wireshark on FC4? Since > revision 20951 I get the following errors: > > rm -f

  1   2   >