Re: [Wireshark-dev] Failed pipeline for nvmeof_getlog_page | wireshark | 3a8e09ef

2021-03-31 Thread ronnie sahlberg
It seems like you already know what is wrong and how to solve this. Why not just change your patch so it does not trigger this compiler error/warning? Maybe the compiler is overly sensitive here? Who knows. Why is this a problem for wireshark developers? Do this: * fix your code so it does not t

Re: [Wireshark-dev] Is there a way to easily go to the next packet that satisfies a filter string without filtering the packets

2021-03-20 Thread ronnie sahlberg
Doesn't wireshark already have this? CTRL-F and then type in the filter string then click "Find" and it will cycle through the packets that are matching. On Sun, Mar 21, 2021 at 7:18 AM Richard Sharpe wrote: > > Hi folks, > > I use Wireshark a great deal in my job because I am always looking at

Re: [Wireshark-dev] [Outreachy] Internship blog 2020

2020-12-03 Thread ronnie sahlberg
Just a followup to clarify, Take [1] and [2] as good suggestions, then look at other dissectors and mimic them. We are pretty flexible and forgiving when it comes to style and as long as you mostly match what other dissectors look like no one will object. On Fri, Dec 4, 2020 at 1:28 PM ronnie

Re: [Wireshark-dev] [Outreachy] Internship blog 2020

2020-12-03 Thread ronnie sahlberg
On Fri, Dec 4, 2020 at 12:47 PM Jonathan Nieder wrote: > > Hi Joey, > > Joey Salazar wrote: > > > Very happy to be joining for this winter's internship! A short blog > > entry on the beginning of this journey here: https://jsal.home.blog/ > > > > A new entry every 2 weeks, check it out! > > > > Th

Re: [Wireshark-dev] Packet Diagram shows only raw bytes of a subtree instead of individual fields

2020-11-30 Thread ronnie sahlberg
On Tue, Dec 1, 2020 at 7:51 AM Gerald Combs wrote: > > On 11/26/20 11:03 AM, John Thacker wrote: > > > > On Thu, Nov 26, 2020 at 1:19 PM Maynard, Christopher via Wireshark-dev > > mailto:wireshark-dev@wireshark.org>> wrote: > > > > Many protocols contain subtrees, such as a header with variou

Re: [Wireshark-dev] Joint project with Git for outreachy

2020-09-21 Thread ronnie sahlberg
esome so whomever ends up being the intern or whatever doing it, I will be happy to help them get it going and have a successfull project that they can remember with joy and be proud of. regards ronnie sahlberg On Mon, Sep 21, 2020 at 2:17 AM Emily Shaffer wrote: > > On Sat, Sep 19, 2020 at

Re: [Wireshark-dev] Joint project with Git for outreachy

2020-09-19 Thread ronnie sahlberg
cloud file server :-) ) best regards Ronnie Sahlberg On Sat, Sep 19, 2020 at 8:21 AM Jonathan Nieder wrote: > > Hi wiresharkers, > > Outreachy <https://www.outreachy.org/> is a program similar to the > Google Summer of Code, providing internships to work on open source >

Re: [Wireshark-dev] Code of Conduct for our community

2020-08-05 Thread ronnie sahlberg
I agree, The samba one is much more comfortable. On Thu, Aug 6, 2020 at 3:07 AM Richard Sharpe wrote: > > On Wed, Aug 5, 2020 at 8:49 AM Uli Heilmeier wrote: > > > > All, > > > > As discussed in the last Remote Developer Den meeting I see a Code of > > Conduct (CoC) as helpful for our communit

Re: [Wireshark-dev] Bzip2 support

2019-06-26 Thread ronnie sahlberg
On Thu, Jun 27, 2019 at 7:17 AM Guy Harris wrote: > > On Jun 26, 2019, at 2:03 PM, Jaap Keuter wrote: > > > On 26 Jun 2019, at 19:41, Guy Harris wrote: > > > >> It could probably be done (note that for decompressing capture files that > >> would require the ability to do random access I/O, > >

Re: [Wireshark-dev] Something that would be useful in Wireshark when dealing with dropped packets

2018-12-30 Thread ronnie sahlberg
That is a really good idea, but instead of you having to manually search for where the next pdu starts, it would be possible to teach wireshark to do this automatically. We already track the PDU boundaries for SMB as well as a bunch other protocols so we know where a pdu starts/stops, most of the

Re: [Wireshark-dev] [pcap-ng-format] Proposal for storing decryption secrets in a pcapng block

2018-10-06 Thread ronnie sahlberg
What Guy said. On Fri, Oct 5, 2018 at 4:11 PM Guy Harris wrote: > > On Sep 30, 2018, at 10:47 AM, Peter Wu wrote: > > > Requirements for block placement: > > - No requirement. Producers are allowed to write the block anywhere. > > Disadvantages for consumers: requires a two-pass scan to collect

Re: [Wireshark-dev] compilation problem

2017-09-12 Thread ronnie sahlberg
Add "-I.." to your compiler flags. On Tue, Sep 12, 2017 at 7:12 PM, Sadik Sikder wrote: > Hello all > i am trying to compile a file like packet-ssl-utils.c. the compilation > command is below > > ssikder@ssikder:~/Desktop/wireshark_source_code/epan/dissectors$ gcc -o foo > packet-ssl-utils.c `l

Re: [Wireshark-dev] Wireshark may get ISN wrong

2014-11-17 Thread ronnie sahlberg
You can just disable relative sequence numbers in the preferences for tcp. On Mon, Nov 17, 2014 at 9:38 AM, Matt wrote: > Hi, > > I use wireshark to examinate some traces generated by a network > simulator (ns3 www.nsnam.org) which set the ISN to 0 (no randomization > yet). > As wireshark assume

Re: [Wireshark-dev] Conflicts: field in commit messages

2014-10-06 Thread ronnie sahlberg
My 5 cent : I think they should be removed. On Mon, Oct 6, 2014 at 12:03 PM, Bálint Réczey wrote: > Hi All, > > I usually leave the "Conflicts: ..." in the commit message after > resolving conflicts to document that the merge was not automatic. > Should I continue doings so you prefer removin

Re: [Wireshark-dev] Qt License Change

2014-08-20 Thread ronnie sahlberg
I think the biggest gotcha with LGPLv3 is that it is no longer compatible with GPLv2 only code. Wireshark does not have any GPLv2only code right? If not, we should be ok. On Wed, Aug 20, 2014 at 9:31 AM, Evan Huus wrote: > http://blog.qt.digia.com/blog/2014/08/20/adding-lgpl-v3-to-qt/ > > I don't

Re: [Wireshark-dev] How can Wireshark improve

2014-04-25 Thread ronnie sahlberg
On Sat, Apr 19, 2014 at 12:48 PM, Guy Harris wrote: > > On Apr 19, 2014, at 12:24 PM, Richard Sharpe > wrote: > >> One think I would like to be able to do is "Show me all the SMB2 >> requests where the smb2.flags.is_response == true && smb2.nt_status != >> NT_STATUS_SUCCESS" > > Presumably you m

Re: [Wireshark-dev] Heuristic check of T.125 dissector

2014-02-25 Thread ronnie sahlberg
dissector is useful to others, then if it is based on reverse engineering instead of official documentation, include it. An incomplete, reverse engineered, dissector is better than no dissector at all. ronnie sahlberg On Tue, Feb 25, 2014 at 8:51 AM, Thomas Wiens wrote: > >> Withou

Re: [Wireshark-dev] Add a capability to disable/enable a dissector table ?

2014-02-21 Thread ronnie sahlberg
sgtm On Fri, Feb 21, 2014 at 10:37 AM, Bill Meier wrote: > It seems to me that it would be nice to be able to disable/enable specific > dissector and heuristic tables. > > For example, this would be useful when investigating tcp level issues > for which tcp payload dissection is not interesting.

Re: [Wireshark-dev] Last few license header questions

2014-02-05 Thread ronnie sahlberg
On Wed, Feb 5, 2014 at 12:54 PM, Evan Huus wrote: > The buildbot is down to reporting only 13 files with license header > problems. Let's get them cleaned up and finally have that step pass :) > > --- > > 'diameter/dictionary.dtd' > 'wimaxasncp/dictionary.dtd' > > These two DTD files both appear t

Re: [Wireshark-dev] snow3g dissector in violation of GPLv2+

2014-01-15 Thread ronnie sahlberg
On Wed, Jan 15, 2014 at 3:10 PM, Joerg Mayer wrote: > commit b01a99c385bc80566cff9134f93b5d4680dd5a58 > Author: Martin Mathieson > Date: Tue Jan 14 11:09:47 2014 + > > Provide hook for calling EEA1 implementation (Snow3G). Implementation > not supplied due to licensing conditions. TO

Re: [Wireshark-dev] Thoughts on disabling an old dissector

2013-12-18 Thread ronnie sahlberg
I think we should keep the dissector but either rename it to *_legacy or something like someone suggested or control it via a preference. We have similar situations for other protocols already that can be used to highlught some of the options : In iSCSI we already have a preference (that defaults

Re: [Wireshark-dev] Idea for faster dissection on second pas

2013-10-10 Thread ronnie sahlberg
That would be a good additions, but I always tried to do something like : as soon as the heuristic dissector found a match then it would explicitely register itself as the dissector for the conversation. Perhaps we can make something like that automatic? Similarly to the current discussion some di

Re: [Wireshark-dev] Wireshark PIDL generated dissectors

2013-10-07 Thread ronnie sahlberg
, Oct 7, 2013 at 1:57 PM, Guy Harris wrote: > > On Oct 3, 2013, at 8:04 PM, ronnie sahlberg wrote: > >> There is very little overlap between samba needs and wireshark needs for >> PIDL. >> It is probably better to continue running two separate forks of PIDL, >> on

Re: [Wireshark-dev] Wireshark PIDL generated dissectors

2013-10-03 Thread ronnie sahlberg
do the work? On Thu, Oct 3, 2013 at 7:58 PM, Andrew Bartlett wrote: > On Thu, 2013-10-03 at 19:44 -0700, ronnie sahlberg wrote: >> Cool. >> And we contact you when samba-PIDL no longer can generate compileable >> wireshark dissectors? > > Contacting the Samba Team would s

Re: [Wireshark-dev] Wireshark PIDL generated dissectors

2013-10-03 Thread ronnie sahlberg
These are probably better maintained by wireshark than samba. I may be able to try taking a look at your patch during the weekend. Please ping me if I forget. On Tue, Oct 1, 2013 at 7:55 AM, wrote: > The check_col function in the Wireshark source has been deprecated for > awhile, but never offic

Re: [Wireshark-dev] Wireshark PIDL generated dissectors

2013-10-03 Thread ronnie sahlberg
Cool. And we contact you when samba-PIDL no longer can generate compileable wireshark dissectors? On Thu, Oct 3, 2013 at 7:13 PM, Andrew Bartlett wrote: > On Tue, 2013-10-01 at 10:55 -0400, mman...@netscape.net wrote: >> The check_col function in the Wireshark source has been deprecated for >>

Re: [Wireshark-dev] OID list usage

2013-09-12 Thread ronnie sahlberg
Which oid list are you referring to exactly ? On Thu, Sep 12, 2013 at 12:18 AM, Bart J. Smit wrote: > Hi, > > I am working on a FOSS project (http://github.com/bartsmit/bedtime) and I > would like to incorporate information from your OID list. Currently the > relevant script (re)populates a data

Re: [Wireshark-dev] Seaching in the data pane would be useful ...

2013-08-09 Thread ronnie sahlberg
On Fri, Aug 9, 2013 at 9:02 AM, Richard Sharpe wrote: > On Fri, Aug 9, 2013 at 8:52 AM, Christopher Maynard > wrote: >> Richard Sharpe writes: >> >>> I can across a capture yesterday where there were DNS queries for a >>> KDC in a Windows AD environment. The query returned 230 KDCs! >>> >>> Sear

Re: [Wireshark-dev] Seaching in the data pane would be useful ...

2013-08-09 Thread ronnie sahlberg
r ip.addr==1.2.3.4 would find the first ip.addr field and highlight it but CTDL-F DisplayFilter ip.addr==1.2.3.4 && tcp would not work and would just jump to the matching packet, just like today That should be po

Re: [Wireshark-dev] using C++, was: Notes from Sharkfest '13

2013-06-21 Thread ronnie sahlberg
Technically you could use smart pointers, or other types too. But beware the performance impact, and do get numbers before changing. Ethereal/Wireshark does an enormous amount of small allocations and frees. One of my primary goals when we added the first emem allocators were performance. Make

Re: [Wireshark-dev] Jurassic packets

2013-06-13 Thread ronnie sahlberg
Can you try loading an NFS trace on it? I recall that in the old days, sniffers usually could not decode the NFS replies since they did not keep enough state around between request/response to identify what kind of response packet it was. On Thu, Jun 13, 2013 at 11:09 AM, Gerald Combs wrote:

Re: [Wireshark-dev] epan/dissectors/dcerpc/idl2wrs.c?

2013-06-01 Thread ronnie sahlberg
I say Delete it. It is the original proof of concept hack I did before we switched to PIDL. I abandoned this for PIDL in 2005 and should have deleted it then. On Sat, Jun 1, 2013 at 3:03 PM, Guy Harris wrote: > Is that a functional translator from some flavor of DCE RPC IDL (OSF, > Microsof

Re: [Wireshark-dev] Extract bytes from a tvbuff_t

2013-05-25 Thread ronnie sahlberg
fwrite(extracted, sizeof(extracted), 1, file) extracted is a pointer so sizeof(extracted) is the size of pointers on your platform. Often 4 on 32-bit platforms and 8 on 64-bit. You need something like this : fwrite(extracted, tvb_get_length(tvb, 0), 1, file) On Sat, May 25, 2013 at 1:42 PM, Ri

Re: [Wireshark-dev] Copying TVBs for Reassembly [Was: Filebacked-tvbuffs : GSoC'13]

2013-04-18 Thread ronnie sahlberg
I dont think composite tvbs actually work. or at least they didnt work when we originally wrote the reassembly code. On Thu, Apr 18, 2013 at 12:14 PM, Evan Huus wrote: > This is a tangential issue that has always confused me. > > Why do we malloc+memcpy data for reassembly when we already hav

Re: [Wireshark-dev] SRP dissector for wireshark

2013-03-05 Thread ronnie sahlberg
SCSI dissection in wireshark is a bit different than most other protocols. There is no real protocol handler, instead you call out directly to the "dissect CDB", "dissect data-in" "dissect data-out" "dissect sense" etc. In order to do this you also need to collect some additional metadata and tra

Re: [Wireshark-dev] Packet Loss due to Disk Contention with Running Dumpcap in a high packet rate environment

2012-12-12 Thread ronnie sahlberg
fs metadata. And should allow you to capture at near the peak sequential write speed of your spindle. regards ronnie sahlberg On Wed, Dec 12, 2012 at 11:33 AM, John Powell wrote: > Hi Everyone, > > I am using DUMPCAP to capture packets in a high packet rate environment. > &g

wireshark-dev@wireshark.org

2012-05-30 Thread ronnie sahlberg
hf_smb_volume_guid shouldnt this be a FT_GUID ? Can you try making it FT_GUID and see if it works? On Thu, May 31, 2012 at 1:57 PM, Richard Sharpe wrote: > Hi, > > Attached is a patch to handle extended responses for NTCreate&X > requests for CIFS. > > I have tested this patch with captures I

Re: [Wireshark-dev] Conversation tracking

2012-05-11 Thread ronnie sahlberg
Tobias, below On Sat, May 12, 2012 at 2:25 AM, Tobias Weiss wrote: > > > Thanks for your quick replies (Jeff & Lars). > > I guess I have to explain my real problem in more detail. I want to implement > a dissector for a quite old protocol that has 2 stages. The packets of the > first stage have

Re: [Wireshark-dev] Regarding wireshark design

2012-05-10 Thread ronnie sahlberg
ers like phy/Mac layer. & Where do I find that code section where > we accessing raw buffers. > > Regards > Anand > > -Original Message- > From: wireshark-dev-boun...@wireshark.org > [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of ronnie sahlberg >

Re: [Wireshark-dev] Regarding wireshark design

2012-05-10 Thread ronnie sahlberg
There are READMEs in the doc subdirectory. README.developer is a good starting point. Otherwise, most of the code is pretty straightforward so it shouldnt be too hard to just read it. On Thu, May 10, 2012 at 8:52 PM, Singh, Anand wrote: > Hi, > >   Can anyone give me thorough

Re: [Wireshark-dev] Wireshark compile options

2012-03-04 Thread ronnie sahlberg
CFLAGS="-pg" ./configure should do the trick On Sun, Mar 4, 2012 at 3:14 PM, James dsouza wrote: > Hello, > >     I am new to Wireshark and want to use Wireshark with gprof which > requires it to be compiled with -pg option. Where should this option be > added so gcc > would build it with this

Re: [Wireshark-dev] Wireshark SCSI dissectors for new transports

2012-02-28 Thread ronnie sahlberg
n, dataout, response/sense) scsi * } if your transport also supports multiple datain/out blobs for a single task, in order to reassemble the data we would also need a offset/length for each datain/out blob. regards ronnie sahlberg On Tue, Feb 28, 2012 at 8:59 PM, Stefan Hajnoczi wrote: > Wi

Re: [Wireshark-dev] Ronnie's Wireshark presentation / attaching files to the Presentations page on the wiki

2012-01-18 Thread ronnie sahlberg
I am ok with putting the presentation on the wiki. On Thu, Jan 19, 2012 at 1:37 AM, Jeff Morriss wrote: > Hi Ronnie, Gerald, et al, > > This page on the wiki: > > http://wiki.wireshark.org/Presentations > > Points, among other things, to a presentation Ronnie made back in 2008 > showing some of

Re: [Wireshark-dev] Is it still ok to create hidden items ?

2011-10-31 Thread ronnie sahlberg
quot;tricky". Unless your protocol is IP, TCP or UDP, unless the user can "see" the filter variable in the decode pane it pretty much does not exist. regards ronnie sahlberg On Mon, Oct 31, 2011 at 9:10 PM, Roland Knall wrote: > Hi > > Ok, always ready to learn som

Re: [Wireshark-dev] Is it still ok to create hidden items ?

2011-10-27 Thread ronnie sahlberg
a "list of all filterable items". So see it as "if they show up in the dissect pane, this is how you tell the users 'these fields exist, you can filter on them'" If they dont show up in the disset pane, no one will know about them or use them, i.e. they dont exist

Re: [Wireshark-dev] [PATCH] Re: Freeing memory of se_alloc'ated object

2011-05-02 Thread ronnie sahlberg
pass data like this to it too. Then when before releasing all the se_ memory, just have it walk the list of callbacks and invoke them in turn first. regards ronnie sahlberg On Tue, May 3, 2011 at 8:31 AM, Max wrote: > 2011/5/2 Guy Harris : >> >> A separate "cleanup"

Re: [Wireshark-dev] Portable Linux Wireshark with custom dissectors - possible ?

2011-03-08 Thread ronnie sahlberg
wireshark libraries. But you cant use plugins like that so your custom dissectors have to be built in as normal dissectors. regards ronnie sahlberg On Wed, Mar 9, 2011 at 12:20 PM, Dan White wrote: > I have been tasked to come up with a Wireshark configuration that can sit on > a USB thumb

Re: [Wireshark-dev] Query

2010-12-30 Thread ronnie sahlberg
rfc 791 and 792 On Fri, Dec 31, 2010 at 4:52 PM, prathiba meenu wrote: > Hi, > Could you please tell what are all the things needed to calculate checkum of > ICMP and ICMPv6? > > -- > Thanks & Regards, > Prathiba.H > > ___ >

Re: [Wireshark-dev] UDP desegmentation - how to?

2010-12-22 Thread ronnie sahlberg
Fragmented UDP packets are reassembled in the IP layer. See the preferences for IP and enable the reassembly. This should reassemble fragmented Kerberos over UDP packets. regards ronnie sahlberg On Wed, Dec 22, 2010 at 7:58 PM, Kaul wrote: > Can I use something like tcp_dissect_pdus() for

Re: [Wireshark-dev] Thinking of some changes to packet-scsi.c ...

2010-12-04 Thread ronnie sahlberg
me time, and to have something to generate data to test with, they could at the same time enhance dbench.samba.org and its iscsi backend to be able to generate such i/o. regards ronnie sahlberg On Sun, Dec 5, 2010 at 9:45 AM, Richard Sharpe wrote: > On Sat, Dec 4, 2010 at 6:29 AM, Chris May

Re: [Wireshark-dev] [Wireshark-commits] rev 34269: /trunk/tools/ /trunk/tools/: make-sminmpec.pl

2010-09-28 Thread ronnie sahlberg
Yeah, there is a whole bunch of references to it. Since it was static in the generated file and declared extern in the header file this makes it not compile on some systems On Tue, Sep 28, 2010 at 9:20 PM, Bill Meier wrote: > sahlb...@wireshark.org wrote: > > http://anonsvn.wireshark.org/viewvc

Re: [Wireshark-dev] wireshark decode as..??

2010-03-22 Thread ronnie sahlberg
change it to if (!initialized) { data_handle = find_dissector("data"); helen_handle = create_dissector_handle(dissect_helen, proto_helen); for (i = 0; i < 25; i++) { dissector_add("udp.port", ports[i], helen_handle); } } Yo

Re: [Wireshark-dev] INTERLINK dissector plugin added

2010-03-16 Thread ronnie sahlberg
On Tue, Mar 16, 2010 at 8:13 PM, Joerg Mayer wrote: > On Tue, Mar 16, 2010 at 08:16:44AM +0100, Dr. Uwe Girlich wrote: >> I just added (with revision 32202) a new dissector plugin: INTERLINK (yes, I >> know, a too general name but that's what it is called by BMW). This protocol >> is >> used in B

Re: [Wireshark-dev] preliminary code submission

2010-02-10 Thread ronnie sahlberg
are also some sections I think might be problematic and which would require a more detailed analysis. Possible to re-licence it under GPLv2 or maybe one of the other licences that have been verified to be compatible and has the blessing of the gpl folks? regards ronnie sahlberg On Thu, Feb

Re: [Wireshark-dev] Some random patches I use...

2010-02-04 Thread ronnie sahlberg
metze great patches, as usual. applied, thanks. On Sat, Jan 30, 2010 at 1:10 AM, Stefan (metze) Metzmacher wrote: > Hi, > > I'm using a few patches in my private git branch of wireshark. > It would be nice if they could go upstream. > > metze > > __

Re: [Wireshark-dev] packet-kerberos.c: hand-written or ASN.1?

2010-01-27 Thread ronnie sahlberg
ouch, it is partially machinegenerated! when did that happen ? :-) On Wed, Jan 27, 2010 at 7:30 PM, ronnie sahlberg wrote: > packet-kerberos.c is handwritten. > > packet-kerberos contains a whoole lot more than just rfc1510 > (it even handles a pre rfc version of 1510 wit

Re: [Wireshark-dev] packet-kerberos.c: hand-written or ASN.1?

2010-01-27 Thread ronnie sahlberg
is worth it to move it to machinegenerated code. (and if doing so, we would have to use a modified asn anyway, to not break packetcable) I think it is best if you just enhance the hf fields, one by one, as you find them too terse. regards ronnie sahlberg On Wed, Jan 27, 2010 at 6:25 PM

Re: [Wireshark-dev] [PATCH] LIBNDR_FLAG_NOALIGN support in wireshark and PIDL

2010-01-19 Thread ronnie sahlberg
Wed, 2010-01-20 at 08:50 +1100, ronnie sahlberg wrote: >> Can you send me your new di->no_align patch and Ill check it in right >> now. >> >> I started applying it yesterday but modified it (to ensure we always >> initialize di->no_align in get_next_di(), but will re

Re: [Wireshark-dev] [PATCH] LIBNDR_FLAG_NOALIGN support in wireshark and PIDL

2010-01-19 Thread ronnie sahlberg
right now, in anticipation of adding the pidl patches later. On Wed, Jan 20, 2010 at 1:58 AM, Julien Kerihuel wrote: > On Tue, 2010-01-19 at 13:44 +1300, Jelmer Vernooij wrote: > > On Tue, 2010-01-19 at 11:13 +1100, ronnie sahlberg wrote: > > The wireshark patch for this i

Re: [Wireshark-dev] [PATCH] LIBNDR_FLAG_NOALIGN support in wireshark and PIDL

2010-01-18 Thread ronnie sahlberg
The wireshark patch for this is fine. I can apply these two patches to wireshark if you want me to. Is the pidl patch ok with the upstream pidl maintainer (jelmer?) ? On Tue, Jan 19, 2010 at 1:25 AM, Julien Kerihuel wrote: > Hi Lists, > > Prior submitting the wireshark's part of this patch o

Re: [Wireshark-dev] Erroneous data in TCP display

2009-11-16 Thread ronnie sahlberg
the window size during the syn phase did have a semantic meaning. Fortunately no one is using t-tcp any more and if someone does, they shouldnt. regards ronnie sahlberg On Tue, Nov 17, 2009 at 6:50 AM, Ed Franks wrote: > I'm a developer for a TCP/IP stack.  I have been getting

Re: [Wireshark-dev] How about moving from svn to git?

2009-11-08 Thread ronnie sahlberg
On Mon, Nov 9, 2009 at 10:31 AM, Guy Harris wrote: > > On Nov 7, 2009, at 3:08 AM, Joerg Mayer wrote: > >> this is just something that went through my mind yesterday while >> working >> on the third patch on the same files and without a chance to commit >> between the patches. If there is one thin

Re: [Wireshark-dev] Help with ASN based dissector

2009-09-01 Thread ronnie sahlberg
It might be possible to create a ANS.1/BER description that is compatible with both encodings. FooBar ::= SEQUENCE OF { kludge KludgeFooBar } KludgeFooBar ::= CHOICE { item1 [0] IA5String item2 [1] INTEGER } I think this might work and should be able to decode both types of encoding. It

Re: [Wireshark-dev] Wireshark's ISN handling

2009-08-17 Thread ronnie sahlberg
It does happen from time to time. Most commonly when you have a retransmitted packet early in the trace that has a sequence number "before" the first packet seen. In that case those retransmitted packets just get a negative sequence number (~ -2 billion something). You get used to it and it is no

Re: [Wireshark-dev] krb5 dcerpc decryption

2009-07-28 Thread ronnie sahlberg
> http://anonsvn.wireshark.org/viewvc/trunk/tools/pidl/lib/Parse/Pidl/Wireshar > k/ > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=28961 > > Regards > Anders > -Ursprungligt meddelande- > Från: wireshark-dev-boun...@wireshark.org > [mailto:wireshark-dev-boun.

Re: [Wireshark-dev] krb5 dcerpc decryption

2009-07-27 Thread ronnie sahlberg
ementing this code inside wireshark. The pidl command line to generate a ws dissector looks like this : pidl lsa.idl --ws-parser regards ronnie sahlberg On Sat, Jul 25, 2009 at 6:47 PM, Stefan (metze) Metzmacher wrote: > Hi Ronnie, > > could you please apply this patch > http://gitwe

Re: [Wireshark-dev] Parsing array and its size in EcDoRpcExt2

2009-04-27 Thread ronnie sahlberg
ray size "length" is actually not encoded at the head of the array but much earlier in the byse-sequence. It is actually encoded at the head of the encapsulating structure) regards ronnie sahlberg On Tue, Apr 28, 2009 at 10:32 AM, Harsha wrote: > On Mon, Apr 27, 2009 at 3:38 PM,

Re: [Wireshark-dev] one possible way to speed up filtering

2009-03-22 Thread ronnie sahlberg
Another way to greatly speed up filtering would be to pick up and clomplete the work to make it possible to use ep_* memory for all field types when dissecting a packet. When wireshark dissects a packet it performs a massive amount of malloc()/free(). This was partially addressed when I added the

Re: [Wireshark-dev] reasebling packets - dissector question

2009-02-23 Thread ronnie sahlberg
>but i noticed that the TCP checksum test fails That may be an issue. Try disabling TCP checksum validation in the preferences for TCP. By default, TCP reassembly will ignore all packets with a checksum failure or "short" packets. (i.e. packets captures with a snaplen smaller than the ethernet mt

Re: [Wireshark-dev] [Wireshark-commits] rev 25368: /trunk/ /trunk/epan/crypt/: Makefile.common Makefile.nmake /trunk/epan/: addr_resolv.c emem.c /trunk/gtk/: Makefile.common Makefile.nmake /trunk/: Ma

2008-05-23 Thread ronnie sahlberg
why did you remote wireshark-tap-register.c from the makefile? wireshark doesnt build under linux without this file. On Fri, May 23, 2008 at 3:55 PM, <[EMAIL PROTECTED]> wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=25368 > > User: etxrab > Date: 2008/05/22 10:55 PM >

Re: [Wireshark-dev] jumping tcp packets

2008-04-03 Thread ronnie sahlberg
You would only be able to see the packets that you are fast enough to capture, process and write to disk. In particular for high speed networks it is an unfortunate fact-of-life that you wont be able to capture packets and write them to disk at the same speed as the packets arrive at the nic and t

Re: [Wireshark-dev] ethernet over USB

2008-02-04 Thread ronnie sahlberg
Hi. I think you are comparing apples to oranges here. SnoopyPro is a USB capture tool and it captures the various layers of the USB protocol. When used for EthernetOverUSB several layers above the USB layer is where you will find Ethernet frames. So with SnoopyPro you are capturing USB frames

Re: [Wireshark-dev] RPC RQUOTA protocol

2007-11-30 Thread ronnie sahlberg
As jaap said, the interface description for ONC-RPC services can often be found in /usr/include/rpcsvc Here is a link to an interface description that defines both version 1 and version2 of rquota http://ninna.tom.sfc.keio.ac.jp/sa/sources/quota-tools/rquota.x It should be fairly straightforward

Re: [Wireshark-dev] Trouble adding an ASN.1 based dissector

2007-11-24 Thread ronnie sahlberg
If Im not mistaken T124 is encoded with aligned PER while T125 is BER so oyu also need to change the flags to asn2wrs to generate a PER dissector. You then also need to look at how other PER dissectors set whether it is aligned or unaligned PER from the template file. On Nov 24, 2007 8:26 PM

Re: [Wireshark-dev] proto_filter_names hash collision

2007-11-20 Thread ronnie sahlberg
or rather a pe-tree On Nov 21, 2007 9:45 AM, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > Instead of creating a hash and store it in a hashtable > wouldnt it be better/faster to just store the names as the strings as > is in a se-tree instead. > That should be much faster. >

Re: [Wireshark-dev] proto_filter_names hash collision

2007-11-20 Thread ronnie sahlberg
Instead of creating a hash and store it in a hashtable wouldnt it be better/faster to just store the names as the strings as is in a se-tree instead. That should be much faster. On Nov 21, 2007 8:13 AM, Guy Harris <[EMAIL PROTECTED]> wrote: > > Kukosa, Tomas wrote: > > It seems that we have reach

Re: [Wireshark-dev] Is there a good way of handling bitfields with different bitmask offsets ?

2007-11-13 Thread ronnie sahlberg
Not tested! grab the hfinfo structure and modify the fields at runtime : header_field_info *hfinfo; hfinfo = proto_registrar_get_nth(hf_index); hfinfo->bitmask = new bitmask hfinfo->bitshift = new bit shift very ugly. it could work. please do not contribute any code to wireshark that does a

Re: [Wireshark-dev] New Dissector: LLRP

2007-11-06 Thread ronnie sahlberg
Please add a page to the wiki for this protocol with some screenshot and samplecaptures. See http://wiki.wireshark.org/WakeOnLAN for an excellent example on what a wikipage should look like. On Nov 7, 2007 1:42 AM, Matt Poduska <[EMAIL PROTECTED]> wrote: > I've submitted a new dissector to be co

Re: [Wireshark-dev] More ITU-T standards available

2007-11-05 Thread ronnie sahlberg
Dont thank me. Im just a messenger. Send an email to ITU-T and thank them. On Nov 5, 2007 6:30 PM, Abhik Sarkar <[EMAIL PROTECTED]> wrote: > Brilliant news indeed! Thanks Ronnie! > > > > On Nov 5, 2007 11:09 AM, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > >

[Wireshark-dev] More ITU-T standards available

2007-11-04 Thread ronnie sahlberg
List, people with telco protocol interests Some really good news: http://www.itu.int/ITU-T/newslog/Free+Access+For+All+To+ITUT+Standards.aspx http://www.itu.int/ITU-T/publications/recs.html ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org htt

Re: [Wireshark-dev] decoding Remote Desktop Protocol

2007-10-29 Thread ronnie sahlberg
MTrq/MTcf from T.125 ? On 10/26/07, Kukosa, Tomas <[EMAIL PROTECTED]> wrote: > > I can look if asn2wrs could generate at least some usefull code for > T.128 Legacy mode. > > > > -Original Message- > > From: [EMAIL PROTECTED] > > [mailto:[EMAIL PROT

Re: [Wireshark-dev] decoding Remote Desktop Protocol

2007-10-28 Thread ronnie sahlberg
I have commited an initial and very limited X.224 dissector that registers TPKT on port 3389 and makes TPKT spawn off this port into X.224 instead. The X.224 dissector is very incomplete and only really dissects CR/CC/DT and only for class 0. But it is good enough for now as a start to decode up t

Re: [Wireshark-dev] decoding Remote Desktop Protocol

2007-10-24 Thread ronnie sahlberg
X.224 is documented here : http://www.itu.int/rec/T-REC-X.224-199511-I/en On 10/25/07, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > Please start a wiki page and add as many example captures as possible > and interested people can start chipping in. > > Maybe the rdesktop peopl

Re: [Wireshark-dev] decoding Remote Desktop Protocol

2007-10-24 Thread ronnie sahlberg
l use. > > So, no joy there. I bow to your wisdom. > > -Jason > > On 10/24/07, ronnie sahlberg wrote: > > > The parser files are plain-text with no sort of licensing information > > > in them. How likely is it that I would get in trouble for posting > > &

Re: [Wireshark-dev] decoding Remote Desktop Protocol

2007-10-24 Thread ronnie sahlberg
> The parser files are plain-text with no sort of licensing information > in them. How likely is it that I would get in trouble for posting > them to this list? I'll do some more reading before venturing into > that. Please DON'T ! The files are still copyrighted. since the rdesktop tool can co

Re: [Wireshark-dev] decoding Remote Desktop Protocol

2007-10-24 Thread ronnie sahlberg
I think RDP is just using T.126 with some extra extensions. As far as I recall it is using the old legacy encoding and not ASN PER. I did find some documentation about this a long time ago but never had any traces/nor real interest in implementing it. It should be possible to find the T.126 famil

Re: [Wireshark-dev] Adding CFM plugin and requesting review.

2007-10-10 Thread ronnie sahlberg
some comments 1, the libfile should be a header file packet-cmf.h with the usual boilerplates included 2, all value strings must be terminated with a {0,NULL} entry or else you risk reading beyond the end of the array. 3, get rid of theif (proto_cfm == -1) { this function should only be

Re: [Wireshark-dev] FTAM ASN.1 copyright

2007-10-10 Thread ronnie sahlberg
Since it is an ASN file, and since it is freely downloadable from their website as i read hte section below we should be ok : http://www.itu.int/ITU-T/ipr/ # ITU-T Software Copyright Guidelines [Download Word or PDF file] 2.2 Software that should not raise any IPR issues when includin

Re: [Wireshark-dev] Single TCP segment having multiple PDUs not working

2007-09-27 Thread ronnie sahlberg
try using tcp_dissect_pdus() to handle the case with pdus transported ontop of tcp it will take care of this for you automatically On 9/28/07, Zongjun <[EMAIL PROTECTED]> wrote: > Hey guys, > > According to my capture, I don't have situations where ONE PDU spans over > multiple TCP segment. In st

Re: [Wireshark-dev] Steps to port wireshark to windows xp, vista and solaris

2007-09-25 Thread ronnie sahlberg
send your dissectors to the mailing list and someone will review it and give suggestions on what is portable and what needs fixing. once the dissector is in the mainline codebase it will be built and verified on windows hosts that are part of the buildfarm On 9/25/07, [EMAIL PROTECTED] <[EMAIL P

Re: [Wireshark-dev] Strip Ethernet broadcast / locally administered flags from address before doing manufacturer name resolvings?

2007-08-17 Thread ronnie sahlberg
On 8/17/07, Sake Blok <[EMAIL PROTECTED]> wrote: > On Wed, Aug 15, 2007 at 04:26:23PM +0200, Joerg Mayer wrote: > > On Wed, Aug 15, 2007 at 03:31:08PM +0200, Sake Blok wrote: > > > I can't imagine myself situations where you locally assign an > > > address and still be interested in the manufacturo

Re: [Wireshark-dev] Strip Ethernet broadcast / locally administered flags from address before doing manufacturer name resolvings?

2007-08-14 Thread ronnie sahlberg
On 8/15/07, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > Sounds good. > > In particular doing this for the LocallyAdministrated would make sense > since many active/passive cluster implementations pick a MAC address > to represent the active node by > taking the MAC addre

Re: [Wireshark-dev] Strip Ethernet broadcast / locally administered flags from address before doing manufacturer name resolvings?

2007-08-14 Thread ronnie sahlberg
Sounds good. In particular doing this for the LocallyAdministrated would make sense since many active/passive cluster implementations pick a MAC address to represent the active node by taking the MAC address of the primary NIC of the primary node and then setting the locally administrated bit, to

Re: [Wireshark-dev] TCP Reassembly issues

2007-07-10 Thread ronnie sahlberg
On 7/10/07, Graham Bloice <[EMAIL PROTECTED]> wrote: > DNP application message fragments are carried in a transport layer which has > a > single byte header containing a 6 bit sequence number (tr_seq, 0-63) and two > flags, first (tr_fir) and final (tr_fin). > > A single fragment message will have

Re: [Wireshark-dev] Run-time error (samr.hnd disappeared)

2007-07-09 Thread ronnie sahlberg
i temporarily disabled sidsnooping for now. sidsnooping was an idea i had a long time ago but i never finished properly. it would be nice if it were enhanced in the future to actually look at most of the dcerpc commands where sids are mapped and used it. it would also be nice with a small gui wh

Re: [Wireshark-dev] Beginner article for custom dissector now on Code Project

2007-07-01 Thread ronnie sahlberg
You need to terminate the value_string with a {0,NULL} entry to tell wireshark where it ends. Othervise you risk reading beyond the end which will cause a segfault. On 7/1/07, Ken Thompson <[EMAIL PROTECTED]> wrote: > I've recently published a beginner article on creating a custom > dissector. T

Re: [Wireshark-dev] WiMAX and M2M plugin code

2007-05-21 Thread ronnie sahlberg
Do you have any example captures we can use to fuzz test the dissector with? On 5/18/07, Harvey, Michael <[EMAIL PROTECTED]> wrote: > Here is the code for the WiMAX and M2M plugins. These are not supplied > as patches but as plugin subdirectories. > > Since WiMAX is a wireless protocol, we creat

Re: [Wireshark-dev] [Wireshark-commits] rev21705:/trunk//trunk/plugins/asn1/:asn1.hpacket-asn1.c/trunk/epan/dissectors/:packet-MAP_DialoguePDU.cpacket-acp133.cpacket-acse.cpacket-ansi_map.c packet-ber

2007-05-07 Thread ronnie sahlberg
Is it really worth it to asn2wsr'ify the kerberos dissector? First, the dissector currently handles two different versions of kerberos, both the "standard" 1510 ASN but also the slightly different ASN used by packetcable. Second, the dissector as it is today is almost complete and dissects virtua

Re: [Wireshark-dev] [Wireshark-commits] rev 21644: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-per.c

2007-05-02 Thread ronnie sahlberg
it broke SUSE Linux :-) not windows On 5/2/07, Kukosa, Tomas <[EMAIL PROTECTED]> wrote: > Hi, > > I would fix it but I have to wail till result from builbot is available > as do not have non-Windows environment. > > T. > > > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL

Re: [Wireshark-dev] Fwd: FW: [PATCH] New protocol dissector - Kingfisher

2007-04-30 Thread ronnie sahlberg
can you please provide some example captures we can test the dissector with you also have to terminate the value_string with a {0,NULL} entry or it may SEGV if you receive a corrupted packet. On 4/18/07, Rob Casey <[EMAIL PROTECTED]> wrote: > Re-sent from Google mail due to local mail server is

  1   2   3   4   >