Re: [Wireshark-dev] [PATCH] Improved support for MIPv4

2007-05-23 Thread Ville Nuorvala
On 5/18/07, Sebastien Tandel <[EMAIL PROTECTED]> wrote: > That's not too much resources ... simply run for a few passes > > tools/fuzztest.sh mip1.cap mip2.cap mip3.cap Oh, now your question makes sense! I hadn't noticed the script. The script ran on a test capture for a few thousand passes with

Re: [Wireshark-dev] [PATCH] Improved support for MIPv4

2007-05-18 Thread Ville Nuorvala
On 5/16/07, Sebastien Tandel <[EMAIL PROTECTED]> wrote: > Hi, > > Some quick comments : > 1) please use proto_tree_add_item whenever possible. Don't use > tvb_get_* if you don't intend to use the retrieved value for another > purpose than inserting it in the tree. Ok. I just used it to convert

Re: [Wireshark-dev] [PATCH] Improved support for MIPv4

2007-05-18 Thread Ville Nuorvala
On 5/16/07, Jaap Keuter <[EMAIL PROTECTED]> wrote: > Hi, > > Some additional notes: > > + {REGISTRATION_REVOCATION, "Registration Revocation"}, > + {REGISTRATION_REVOCATION, "Registration Revocation Acknowledgement"}, > > The second one misses _ACKNOWLEDGEMENT in the symbol Oops, how did I miss

Re: [Wireshark-dev] [PATCH] Improved support for MIPv4

2007-05-16 Thread Ville Nuorvala
(working copy) @@ -1,6 +1,7 @@ /* packet-mip.c * Routines for Mobile IP dissection * Copyright 2000, Stefan Raab <[EMAIL PROTECTED]> + * Copyright 2007, Ville Nuorvala <[EMAIL PROTECTED]> * * $Id$ * @@ -48,6 +49,7 @@ static int hf_mip_g = -1; static int hf_mip_v = -1;

[Wireshark-dev] [PATCH] Improved support for MIPv4

2007-05-16 Thread Ville Nuorvala
Hello, attached is a patch that adds support for the following RFCs (and RFC-to-be): RFC 3519 Mobile IP Traversal of Network Address Translation (NAT) Devices RFC 3543 Registration Revocation in Mobile IPv4 RFC 4433 Mobile IPv4 Dynamic Home Agent (HA) Assignment (including the not yet publishe