Re: [Wireshark-dev] can't compile wireshark version 4.0

2022-10-20 Thread Stig Bjørlykke
an never be less than zero. > It's documented as char here: https://doc.qt.io/qt-6/qbytearray.html#at I never had any issues compiling this code on my RPi. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing l

Re: [Wireshark-dev] On MR 4428

2021-10-06 Thread Stig Bjørlykke
mewhere. Maybe we need to reconsider inclusion of the MR in > release-3.4 > This issue is already fixed in MR . Maybe we should add a sanity check to the Debian builder? -- Stig Bjørlykke ___ Sent

Re: [Wireshark-dev] Compilation on Windows taking a very long time?

2021-10-04 Thread Stig Bjørlykke
rs a build of all (or many) ui/qt/*.cpp files. This does not happen in the release-3.4 branch. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev U

Re: [Wireshark-dev] ISO 7816 vs GSM SIM dissector

2021-08-27 Thread Stig Bjørlykke
Thank you Pascal and Martin. I will update the gsm_sim dissector for my needs for now, merging these two looks like a complex and time consuming task. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives

[Wireshark-dev] ISO 7816 vs GSM SIM dissector

2021-08-18 Thread Stig Bjørlykke
Hi, Does anyone know the difference between the ISO 7816 dissector and the GSM SIM dissector? For me it looks like they are handling the same PDUs, but both are incomplete in different ways. -- Stig Bjørlykke ___ Sent via

Re: [Wireshark-dev] Unregistered header fields in packet-fcdns.c

2019-09-10 Thread Stig Bjørlykke
Hi Christian, Do you have a sample capture file to show this issue? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https

Re: [Wireshark-dev] Qt issue with first section not movable

2019-09-03 Thread Stig Bjørlykke
d. Not being able to move the first column is strange and inconsistent behaviour in Wireshark. That’s what I think. Stig -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org

Re: [Wireshark-dev] macOS dark mode in 3.0.0

2019-03-21 Thread Stig Bjørlykke
nce -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-

Re: [Wireshark-dev] macOS dark mode in 3.0.0

2019-03-21 Thread Stig Bjørlykke
report: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15511 -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wiresha

Re: [Wireshark-dev] Overriding a builtin dissector

2018-04-26 Thread Stig Bjørlykke
On Thu, Apr 26, 2018 at 10:13 PM, Dario Lombardo wrote: > What about using proto_deregister_protocol? This function was designed to work with reloading Lua plugins and I don't know how well it will work for disabling builtin dissectors. -- Stig B

Re: [Wireshark-dev] 2.5.0, 2.6, and 3.0 release planning

2018-02-03 Thread Stig Bjørlykke
ing tree item as it does in 2.4. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/optio

Re: [Wireshark-dev] ThreadSanitizer issue in RecentFileStatus()

2018-02-03 Thread Stig Bjørlykke
d=1194099, running) created by main thread at: #0 pthread_create (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a34d) #1 QThread::start(QThread::Priority) (QtCore:x86_64+0x2b5cb) #2 main wireshark-qt.cpp:667 (Wireshark:x86_64+0x1000366cd) SUMMARY: ThreadSanitizer: data race qstring.h:9

[Wireshark-dev] ThreadSanitizer issue in RecentFileStatus()

2018-02-02 Thread Stig Bjørlykke
x_dynamic.dylib:x86_64h+0x2a34d) #1 QThread::start(QThread::Priority) :8575760 (QtCore:x86_64+0x2b5cb) #2 main wireshark-qt.cpp:667 (Wireshark:x86_64+0x100036bcd) SUMMARY: ThreadSanitizer: data race qstring.h:906 in QString::QString(QString const&)

Re: [Wireshark-dev] Broken build on osx

2018-02-02 Thread Stig Bjørlykke
On Fri, Feb 2, 2018 at 9:36 AM, Dario Lombardo wrote: > Few commits ago (I guess from 142c035), my osx build stopped working on > travis. Are you building without Lua support? Try this change: https://code.wireshark.org/review/25556 -- Stig Bjø

Re: [Wireshark-dev] 2.5.0 release on January 16

2018-01-17 Thread Stig Bjørlykke
On Wed, Jan 17, 2018 at 2:05 AM, Gerald Combs wrote: > On 1/13/18 4:16 AM, Stig Bjørlykke wrote: >> - Qt: Missing string translations after source code was moved to >> utils/models/manager/widgets subdirectories > > Do you know what's missing? This shouldn't

Re: [Wireshark-dev] 2.5.0 release on January 16

2018-01-13 Thread Stig Bjørlykke
d in https://code.wireshark.org/review/24570/ -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wir

Re: [Wireshark-dev] Compiling with or without extcap

2018-01-06 Thread Stig Bjørlykke
run a "Refresh Interfaces" to load/unload extcap interfaces without having to manually restart or "Refresh Interfaces". -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https

Re: [Wireshark-dev] 2.5.0 release on January 16

2018-01-06 Thread Stig Bjørlykke
Running with TSan on macOS shows some thread issues during startup which should have been fixed before this release. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org

Re: [Wireshark-dev] File load timing

2017-11-14 Thread Stig Bjørlykke
On Tue, Nov 14, 2017 at 10:14 AM, Paul Offord wrote: > I don't get that option on WS 2.4.0 or 2.4.2 on Windows: > > It's not possible to turn off "Load time" in version 2.4.x, currently only in the development

Re: [Wireshark-dev] File load timing

2017-11-13 Thread Stig Bjørlykke
ead the constantly updated release notes. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/opt

Re: [Wireshark-dev] File load timing

2017-11-11 Thread Stig Bjørlykke
On Sat, Nov 11, 2017 at 7:28 PM, Paul Offord wrote: > While we are on the subject of stuff disappearing, what's happened to the > file load timing thing in the status line? It's default turned off. Preferences -> Appearance -> Layout -> Status Bar settings -> Sh

Re: [Wireshark-dev] Who did this to master?

2017-11-08 Thread Stig Bjørlykke
'create_master_security_keys' [-Werror=implicit-function-declaration] > create_master_security_keys(rec); Try this fix: https://code.wireshark.org/review/#/c/24296 -- Stig Bjørlykke ___ Sent via:Wires

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-10 Thread Stig Bjørlykke
correct. Right? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mail

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-02 Thread Stig Bjørlykke
op level would also be wrong because it's not a protocol. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.

Re: [Wireshark-dev] Go to Qt 5.9 on Windows build bots?

2017-06-14 Thread Stig Bjørlykke
On Wed, Jun 14, 2017 at 1:49 PM, Anders Broman wrote: > I think Stig has tried it on MAC OS too if we want to update that too. I even committed fixes to the Qt code in 5.9 to allow us to use -Wshorten-64-to-32 for C++. I have not seen any issues so far. -- Stig Bjørly

Re: [Wireshark-dev] wireshark 2.2.7 compilation failure on ubuntu 16.04.2

2017-06-02 Thread Stig Bjørlykke
ple_dialog.cpp until the next release. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev

[Wireshark-dev] CMake COMMON_WARN_FLAGS -Wframe-larger-than=16384

2017-05-07 Thread Stig Bjørlykke
/main_window.cpp:23: /Users/stig/Development/wireshark-xcode/ui/qt/ui_main_window.h:355:10: error: stack frame size of 16760 bytes in function 'Ui_MainWindow::setupUi' [-Werror,-Wframe-larger-than=] void setupUi(QMainWindow *MainWindow) ^ 1 error generated. -- Stig

Re: [Wireshark-dev] Adding decryption keys at "runtime" (dissection time)

2017-03-24 Thread Stig Bjørlykke
g dissection. Remember that a UAT can be part of a profile and the profile can be changed during capture. I don't know if this will work out-of-the-box (because the modified UAT will not be saved and changing profile will redissect), but it has to be tested with the selected implementation. -

Re: [Wireshark-dev] Extcap version

2017-02-27 Thread Stig Bjørlykke
erent > intefaces of the same extcap. What about removing the help in the interface? "help" is set in info but used from interface, if you remember this bug: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13218 -- Stig Bjørlykke __

Re: [Wireshark-dev] extcap slowing down start of WS

2017-01-03 Thread Stig Bjørlykke
uot;Refresh Interfaces". -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] proto.h extension (unit strings)

2016-12-16 Thread Stig Bjørlykke
On Fri, Dec 16, 2016 at 4:14 PM, Michael Mann wrote: > Also wanted to mention that I think Stig volunteered to add support on the > Lua end (another area that I'm not familiar enough with to add support). > Yes, I will have a look at the Lua support. --

Re: [Wireshark-dev] Highlight fields

2016-02-23 Thread Stig Bjørlykke
r, so this could be common functionality. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/op

Re: [Wireshark-dev] Mac Build Error

2016-01-20 Thread Stig Bjørlykke
AGS > -Wl,--as-needed > > This is more like fixing the symptom, right? The real issue here is that CMake finds support for the flags while building with Xcode does not. -- Stig Bjørlykke ___ Sent via:Wi

Re: [Wireshark-dev] Mac Build Error

2016-01-20 Thread Stig Bjørlykke
r this would be nice. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailt

Re: [Wireshark-dev] Mac Build Error

2016-01-19 Thread Stig Bjørlykke
On Wed, Jan 20, 2016 at 3:28 AM, David Morsberger wrote: > I am trying to create support and possibly instructions for Xcode. > The only issue I have with using Xcode is https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11816 -- Stig Bjø

Re: [Wireshark-dev] Mac Build Error

2016-01-18 Thread Stig Bjørlykke
directory instead of the source directory. Is there a simple way to clean out my source directory so I can truly start > from scratch? > You can safely delete all files listed as ignored because they are generated. --

Re: [Wireshark-dev] Mac Build Error

2016-01-17 Thread Stig Bjørlykke
On Mon, Jan 18, 2016 at 6:27 AM, David Morsberger wrote: > I have been unable to resolve the following build errors on my Mac with > 10.11. > Maybe you have a outdated declare_wslua.h in your source directory? Try deleting this. -- Stig

[Wireshark-dev] Use ~/Library/Preferences/ for configuration files on OS X.

2015-10-19 Thread Stig Bjørlykke
Hi. We have currently changed to use XDG_CONFIG_HOME/wireshark for configuration files where this is appropriate. Should we also switch to using ~/Library/Preferences/Wireshark on OS X? -- Stig Bjørlykke ___ Sent via

[Wireshark-dev] Reload Lua plugins

2015-08-12 Thread Stig Bjørlykke
/automated/ [2] https://bugs.wireshark.org/bugzilla/ -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options

Re: [Wireshark-dev] enum preferences vs Go Fish

2015-04-06 Thread Stig Bjørlykke
nvenience. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark

Re: [Wireshark-dev] enum preferences vs Go Fish

2015-04-04 Thread Stig Bjørlykke
entry to be highlighted. 4. My Wireshark does hang after changing the decode-as for P_Mul while having a capture file loaded. I don't know if this is related to your patch. -- Stig Bjørlykke ___ Sent via:W

Re: [Wireshark-dev] enum preferences vs Go Fish

2015-04-04 Thread Stig Bjørlykke
sers will think about the global "Decode As" when trying to configure P_Mul (or any other protocol). Is this possible with the decode-as changes? Or do we have to implement something more? -- Stig Bjørlykke

Re: [Wireshark-dev] [Wireshark-commits] rev 44812: /trunk/ /trunk/: configure.ac version_info.c

2014-10-21 Thread Stig Bjørlykke
PropertyListCreateFromStream() if we don't have > CFPropertyListCreateWithStream(). Now that OS X Yosemite is released we also should check for this in CMake. -- Stig Bjørlykke ___ Sent via:Wireshark

Re: [Wireshark-dev] Thanks for the Manual

2014-10-15 Thread Stig Bjørlykke
in the next release. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mail

Re: [Wireshark-dev] [Wireshark-commits] rev 44802: /trunk/epan/ /trunk/epan/dissectors/: packet-6lowpan.c packet-atalk.c packet-bacapp.c packet-batadv.c packet-ber.c packet-btobex.c packet-capwap.c pa

2014-06-20 Thread Stig Bjørlykke
n I ask is because I was thinking about this when implementing reassembled.length, but found the existing field (hf_fragments) sufficient for all practical use. And yes, I know this question is a bit late :) -- Stig Bjørlykke

Re: [Wireshark-dev] epan/dissectors/packet-ssl-utils.h fails compilation at commit b642a280cb74b94e62

2014-04-11 Thread Stig Bjørlykke
On Fri, Apr 11, 2014 at 9:27 PM, Shu Shen wrote: > It appears this latest change has mishandled the case when both > HAVE_LIBGNUTLS and HAVE_LIBGCRYPT are undefined. I'm sorry about that. I'll fix in a short moment. --

Re: [Wireshark-dev] [Wireshark-commits] rev 53090: /trunk/ /trunk/asn1/acse/: acse.cnf packet-acse-template.c /trunk/asn1/cmip/: cmip.cnf packet-cmip-template.c /trunk/asn1/disp/: packet-disp-template

2014-01-10 Thread Stig Bjørlykke
On Fri, Jan 10, 2014 at 12:56 PM, Stig Bjørlykke wrote: > This commit introduced a bug where I always get > "[Malformed Packet: PRES]" in X.400 traffic. Reassembly in RTSE is a bit special. The reassembly is done when receiving a SES "MAJOR SYNC POINT", as this indica

Re: [Wireshark-dev] [Wireshark-commits] rev 53090: /trunk/ /trunk/asn1/acse/: acse.cnf packet-acse-template.c /trunk/asn1/cmip/: cmip.cnf packet-cmip-template.c /trunk/asn1/disp/: packet-disp-template

2014-01-10 Thread Stig Bjørlykke
nfo->private data is. This commit introduced a bug where I always get "[Malformed Packet: PRES]" in X.400 traffic. Have a look at this sample capture, frame 20: http://wiki.wireshark.org/SampleCaptures?action

Re: [Wireshark-dev] [Wireshark-commits] rev 54310: /trunk/epan/wslua/ /trunk/epan/wslua/: wslua_tvb.c

2013-12-20 Thread Stig Bjørlykke
he default value "ENC_ASCII|ENC_NA" ? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mai

Re: [Wireshark-dev] [Wireshark-commits] rev 51775: /trunk/tools/ /trunk/tools/: asn2wrs.py

2013-09-05 Thread Stig Bjørlykke
Issues should be fixed in revision 51776. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark

Re: [Wireshark-dev] [Wireshark-commits] rev 51775: /trunk/tools/ /trunk/tools/: asn2wrs.py

2013-09-05 Thread Stig Bjørlykke
tors CMP.asn */ -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wiresh

Re: [Wireshark-dev] [Wireshark-commits] rev 50560: /trunk/ /trunk/packaging/macosx/Resources/bin/: wireshark /trunk/packaging/macosx/: osx-app.sh /trunk/: configure.ac

2013-07-29 Thread Stig Bjørlykke
s_bpf > group, and the user who installs Wireshark is put into that group. Removing --enable-setuid-install from my configure was the solution. Thank you. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] [Wireshark-commits] rev 50560: /trunk/ /trunk/packaging/macosx/Resources/bin/: wireshark /trunk/packaging/macosx/: osx-app.sh /trunk/: configure.ac

2013-07-29 Thread Stig Bjørlykke
ning dumpcap from /opt/local/bin, which makes dumpcap unusable for wireshark: dyld: warning, LC_RPATH @executable_path/../lib in /opt/local/bin/dumpcap being ignored in restricted program because of @executable_path I don't get the warning when running from build dir. -

Re: [Wireshark-dev] [Wireshark-commits] rev 50935: /trunk/epan/ /trunk/epan/dissectors/: packet-collectd.c /trunk/epan/: proto.c proto.h value_string.c value_string.h

2013-07-28 Thread Stig Bjørlykke
"Value: Something (Value: 42)" The correct entry should be (like it is for 32-bit): "Value: Something (42)" The bug is in fill_label_number64(), where the format should be without the leading "%s: " an

[Wireshark-dev] GTK warnings with 1.10.0

2013-06-07 Thread Stig Bjørlykke
wireshark:30153): Gtk-CRITICAL **: void gtk_combo_box_set_active(GtkComboBox *, gint): assertion `GTK_IS_COMBO_BOX (combo_box)' failed -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://ww

Re: [Wireshark-dev] Lua converting a UINT64 to hex

2012-11-20 Thread Stig Bjørlykke
s = string.format("%X", tostring(data.value)) -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://w

Re: [Wireshark-dev] [Wireshark-commits] rev 44290: /trunk/ui/gtk/ /trunk/ui/gtk/: capture_dlg.c cfilter_combo_utils.h

2012-08-23 Thread Stig Bjørlykke
x27;m all happy again. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mail

Re: [Wireshark-dev] Warnings when loading preferences

2012-08-01 Thread Stig Bjørlykke
On Wed, Aug 1, 2012 at 3:38 PM, Anders Broman wrote: > And as a consequence we have a few of these cluttering up the code, should > those live forever or > Can the be removed after a suitable amount of time? We should at least support one major upgrade :) -- Stig

Re: [Wireshark-dev] Warnings when loading preferences

2012-08-01 Thread Stig Bjørlykke
On Wed, Aug 1, 2012 at 3:29 PM, wrote: > Technically the prefences aren't "obsolete", they are just renamed for > (internally) optimized code. We already handle a lot of renamed preferences in set_pref().

Re: [Wireshark-dev] Warnings when loading preferences

2012-08-01 Thread Stig Bjørlykke
of giving warnings. We also mark removed dissector preferences (prefs_register_obsolete_preference) and protocols (prefs_register_protocol_obsolete) as obsolete. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing l

[Wireshark-dev] Warnings when loading preferences

2012-08-01 Thread Stig Bjørlykke
applying your preferences once should remove this warning) 12:33:02 Warn /Users/stig/.wireshark/preferences line 249: No such preference "packet_list.display_hidden_proto_items" (applying your preferences once should r

Re: [Wireshark-dev] [Wireshark-commits] rev 41242: /trunk/ /trunk/ui/gtk/: edit_packet_comment_dlg.c edit_packet_comment_dlg.h main_statusbar.c /trunk/: file.c file.h summary.c /trunk/wiretap/: wtap.c

2012-02-29 Thread Stig Bjørlykke
et comment, with a matching color? Some notes are important while some are just for info or clarification. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark

Re: [Wireshark-dev] dumpcap does not recognize option "-t" (usethreads)

2011-11-09 Thread Stig Bjørlykke
Hi. I committed a corrected fix in revision 39775. Joerg: did your grep ever finish? ;) -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe

Re: [Wireshark-dev] Making threads mandatory

2011-11-07 Thread Stig Bjørlykke
On Mon, Nov 7, 2011 at 9:13 PM, Gerald Combs wrote: > Is there any reason we shouldn't remove the thread options from > configure.in and CMakeOptions.txt along with USE_THREADS and hard-code > thread support? Sounds reasonable to me. --

Re: [Wireshark-dev] Wireshark 1.6.3 won't run without threads support

2011-11-04 Thread Stig Bjørlykke
27;m using autotools and GLib 2.22.2 (and other older libraries). I works with GLib 2.28.8 and other updated libraries. Wireshark is linked with libgthread on both machines. But g_mutex_new() requires g_thread_init() so if we don't init I suppose someo

Re: [Wireshark-dev] Ordinary LUA dissector.

2011-11-04 Thread Stig Bjørlykke
his patch. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark

[Wireshark-dev] Wireshark 1.6.3 won't run without threads support

2011-11-03 Thread Stig Bjørlykke
us? Or do I miss something? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] Is "tcp.len < -1" a valid display filter?

2011-10-28 Thread Stig Bjørlykke
On Fri, Oct 28, 2011 at 7:06 PM, Stephen Fisher wrote: > On Fri, Oct 28, 2011 at 09:00:59AM +0200, Stig Bjørlykke wrote: >> The previously attached patch does check for signed/unsigned issues, >> and will mark the filter as bad/red. I think it would be nice to check >> a

Re: [Wireshark-dev] Is "tcp.len < -1" a valid display filter?

2011-10-28 Thread Stig Bjørlykke
f they are valid for the given field. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

[Wireshark-dev] Is "tcp.len < -1" a valid display filter?

2011-10-26 Thread Stig Bjørlykke
ed long value in the obvious manner". I suppose this means that the value is casted from signed to unsigned without a warning. The attached patch fixes this, but can we do this check in a simpler manner? -- Stig Bjørlykke signed-unsigned-integ

Re: [Wireshark-dev] [Wireshark-commits] rev 39559: /trunk/epan/ /trunk/epan/: proto.c

2011-10-25 Thread Stig Bjørlykke
On Tue, Oct 25, 2011 at 8:43 PM, Jeff Morriss wrote: > If that's done we may as well let in BASE_HEX and BASE_OCT too. Do you think? This would abandon the sign on negative values, and may not be what the user expects? -- Stig B

Re: [Wireshark-dev] [Wireshark-commits] rev 39559: /trunk/epan/ /trunk/epan/: proto.c

2011-10-25 Thread Stig Bjørlykke
On Tue, Oct 25, 2011 at 7:56 PM, Guy Harris wrote: > We should probably allow BASE_HEX_DEC as well. I was thinking about it. It may make as much sense as allowing BASE_DEC_HEX. -- Stig Bjørlykke ___ Sent

Re: [Wireshark-dev] [Wireshark-commits] rev 39559: /trunk/epan/ /trunk/epan/: proto.c

2011-10-25 Thread Stig Bjørlykke
On Tue, Oct 25, 2011 at 6:48 PM, Guy Harris wrote: > > On Oct 25, 2011, at 9:40 AM, Stig Bjørlykke wrote: > >> I was thinking more like "-1 (0x)", which would be the case for >> DEC_HEX. > > That's BASE_DEC_HEX; if that's what they wanted,

Re: [Wireshark-dev] [Wireshark-commits] rev 39559: /trunk/epan/ /trunk/epan/: proto.c

2011-10-25 Thread Stig Bjørlykke
On Tue, Oct 25, 2011 at 6:21 PM, Guy Harris wrote: >> Log: >> Allow signed integers displayed as DEC_HEX. > > So should a 32-bit -1 be displayed as 0x or -0x1? I was thinking more like "-1 (0x)", which would be the case for D

Re: [Wireshark-dev] [Wireshark-commits] rev 39495: /trunk/ /trunk/gtk/: capture_dlg.c capture_dlg.h capture_if_dlg.c capture_if_dlg.h main.c main.h main_welcome.c main_welcome.h prefs_capture.c /trunk

2011-10-20 Thread Stig Bjørlykke
wrong interface. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wi

Re: [Wireshark-dev] FW: [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu-10.04-x64

2011-10-10 Thread Stig Bjørlykke
On Mon, Oct 10, 2011 at 10:45 AM, Anders Broman wrote: > Could some one try this patch? Committed in revision 39334. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.

Re: [Wireshark-dev] [Wireshark-commits] rev 39318: /trunk/epan/ /trunk/epan/: filesystem.c

2011-10-09 Thread Stig Bjørlykke
d not do any harm. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:w

Re: [Wireshark-dev] [Wireshark-commits] rev 39280: /trunk/ /trunk/epan/dissectors/: packet-ipv6.c /trunk/docbook/: release-notes.xml /trunk/epan/: geoip_db.c geoip_db.h libwireshark.def /trunk/gtk/: h

2011-10-05 Thread Stig Bjørlykke
On Thu, Oct 6, 2011 at 12:27 AM, wrote: >  Add GeoIP IPv6 database support. Tested with GeoIP 1.4.7, but older >  versions *should* be supported. My GeoIP 1.4.7 does not have GEOIP_NETSPEED_EDITION_V6, but it does have all the others. -- Stig Bjø

Re: [Wireshark-dev] Wireshark dissectors implementation with LUA

2011-10-01 Thread Stig Bjørlykke
On Sat, Oct 1, 2011 at 10:59 AM, Helge Kruse wrote: > Where do I find good samples or tutorials to get a glimpse of Lua dissectors? You can have a look at this presentation: http://sharkfest.wireshark.org/sharkfest.09/DT06_Bjorlykke_Lua%20Scripting%20in%20Wireshark.pdf -- Stig Bjørly

Re: [Wireshark-dev] [Wireshark-commits] rev 39149: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-daap.c packet-dcp-etsi.c packet-dec-bpdu.c packet-dec-dnart.c packet-dhcp-failover.c packet-d

2011-09-26 Thread Stig Bjørlykke
as left on purpose, because we do not need this calculations if not having COL_INFO. Should we really remove all occurrences of check_col? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.w

Re: [Wireshark-dev] [Wireshark-commits] rev 38937: / /trunk/epan/: CMakeLists.txt Makefile.common filter_expressions.c filter_expressions.h libwireshark.def prefs.c prefs.h /trunk/gtk/: CMakeLists.txt

2011-09-08 Thread Stig Bjørlykke
I did not intend to commit changes in services. Do we need to execute make-services.pl during a regular build? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists

[Wireshark-dev] Built-in dissector depends on a plugin dissector in 1.6.x

2011-09-07 Thread Stig Bjørlykke
changed to be a built-in dissector. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] RFC: Add fallback path to get_datafile_dir

2011-09-06 Thread Stig Bjørlykke
On Mon, Aug 29, 2011 at 8:48 PM, Joerg Mayer wrote: > I think I haven't built Wireshark in tree for a few years. Are you able to build docbook out of tree? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mail

Re: [Wireshark-dev] Win buildbot

2011-08-31 Thread Stig Bjørlykke
oblems for now. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wire

Re: [Wireshark-dev] Win buildbot

2011-08-31 Thread Stig Bjørlykke
On Wed, Aug 31, 2011 at 1:22 PM, Anders Broman wrote: > Should we use function calls instead of macros accesing "local" data > structures? Good idea, I'll try that. -- Stig Bjørlykke ___ Sent

[Wireshark-dev] Win buildbot

2011-08-31 Thread Stig Bjørlykke
Hi, Anyone able to help with the win32/win64 build problems? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org

Re: [Wireshark-dev] [Wireshark-commits] rev 38800: /trunk/ /trunk/epan/crc/: Makefile.am Makefile.common Makefile.nmake crc-16-plain.c crc-16-plain.h /trunk/epan/crypt/: airpdcap.c airpdcap_wep.c /tru

2011-08-30 Thread Stig Bjørlykke
I have reverted the crc move for now. I have to split the crc files into crc and crc_tvb routines, I think. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists

Re: [Wireshark-dev] _STAT_H in epan/stat_cmd_args.h

2011-08-23 Thread Stig Bjørlykke
On Tue, Aug 23, 2011 at 3:12 PM, Gisle Vanem wrote: > Would you please rename the guard like this: Sure, fixed in r38686. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:h

Re: [Wireshark-dev] [Wireshark-commits] rev 38640: /trunk/ /trunk/epan/: enterprise-numbers /trunk/: manuf services

2011-08-23 Thread Stig Bjørlykke
On Tue, Aug 23, 2011 at 12:47 PM, Jaap Keuter wrote: > No we don't: > "This registry is also available in plain text." But the format has changed, so we need to rewrite the parsing routines. And the user may have a personal services file in the old format.

Re: [Wireshark-dev] Complete the switch to UIManager driven menubar?

2011-08-23 Thread Stig Bjørlykke
On Tue, Aug 23, 2011 at 12:15 PM, Anders Broman wrote: > Pre existing ones, or caused by the switch? Didn't there use to be a LUA tab > under tools? We used to have Tools -> Lua -> Console, Evaluate, Manual, Wiki -

Re: [Wireshark-dev] Complete the switch to UIManager driven menubar?

2011-08-23 Thread Stig Bjørlykke
On Tue, Aug 23, 2011 at 10:19 AM, Anders Broman wrote: > I think all menus work now with MAIN_MENU_USE_UIMANAGER, LUA? The Lua menus are not available due to issues in funnel_stat.c -- Stig Bjørlykke ___ Sent

[Wireshark-dev] Remove support for libpcre?

2011-08-23 Thread Stig Bjørlykke
Hi, Now that we require GLib 2.14 (which includes GRegex) we don't need libpcre. Should we remove the support for libpcre completely? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:

Re: [Wireshark-dev] [Wireshark-commits] rev 38673: /trunk/gtk/ /trunk/gtk/: io_stat.c

2011-08-23 Thread Stig Bjørlykke
the whole data set, not only the displayed ones. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/

Re: [Wireshark-dev] [Wireshark-commits] rev 38640: /trunk/ /trunk/epan/: enterprise-numbers /trunk/: manuf services

2011-08-21 Thread Stig Bjørlykke
On Sun, Aug 21, 2011 at 4:04 PM, wrote: > Directory: /trunk/ >  Changes    Path          Action >  +104602 -17320 services      Modified Whops, IANA changed the file format. -- Stig Bjørlykke ___ Sent via:

Re: [Wireshark-dev] gtk/capture_dlg.h

2011-08-20 Thread Stig Bjørlykke
On Sat, Aug 20, 2011 at 9:22 PM, Gisle Vanem wrote: > Building w/o HAVE_PCAP_REMOTE or HAVE_PCAP_SETSAMPLING, I > got this error from MSVC: What about the attached patch? -- Stig Bjørlykke have-pcap-remote.patch Description: Binar

Re: [Wireshark-dev] [Patch] wsutil/file_util.c

2011-08-17 Thread Stig Bjørlykke
On Wed, Aug 17, 2011 at 9:40 PM, Gisle Vanem wrote: > Here is another patch for a missing WINAPI: Committed r38592. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.

Re: [Wireshark-dev] localtime_r() in gtk/timeshift_dlg.c

2011-08-16 Thread Stig Bjørlykke
t use localtime, check the return value and then copy the values. Like in revision 38569. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: htt

Re: [Wireshark-dev] [Wireshark-commits] rev 38555: /trunk/gtk/ /trunk/gtk/: capture_dlg.c

2011-08-16 Thread Stig Bjørlykke
On Tue, Aug 16, 2011 at 12:03 PM, wrote: > Log: >  Using enabled/disabled instead of yes/no seems to be more descriptive. Or maybe a checkbox? Which you can click to toggle the setting? -- Stig Bjørlykke ___ Se

Re: [Wireshark-dev] [Wireshark-commits] rev 38522: /trunk/gtk/ /trunk/gtk/: capture_dlg.c

2011-08-15 Thread Stig Bjørlykke
en starting capture. Going into the interface settings and pressing Ok sets correct link-layer for the device. This only happens for interfaces which does not have link-layer 'Ethernet', as this is the link-layer used by default.

Re: [Wireshark-dev] [Wireshark-commits] rev 37487: / /trunk/epan/dissectors/: Makefile.common packet-opensafety.c /trunk/epan/: CMakeLists.txt /trunk/: AUTHORS

2011-08-14 Thread Stig Bjørlykke
tocolName); col_clear(pinfo->cinfo,COL_INFO); } Coverity complains (in CID 1246) that some other functions will fail (dereferences it) if pinfo == NULL. Is this comment still valid? If so I think we have to rewrite the code som pinfo never is NULL. -- St

  1   2   3   4   5   6   7   >