Re: [Wireshark-dev] New WiMAX OFDMA PHY SAP dissector

2008-07-21 Thread Stephen Croll
On Sat, Jul 19, 2008 at 1:38 AM, Jaap Keuter <[EMAIL PROTECTED]> wrote: > You can imagine that reviewing a 360kB patch takes a while. Together with > the > other patches in the queue, that is a lot of work we mostly do in our spare > time. > Sorry, I didn't mean to rush anyone. I just wanted to

[Wireshark-dev] New WiMAX OFDMA PHY SAP dissector

2008-07-18 Thread Stephen Croll
I submitted a new dissector for the WiMAX OFDMA PHY SAP protocol early last week and I haven't received any feedback on it yet. For reference, it's bug 2695: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2695 -- Steve Croll ___ Wireshark-dev mailin

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1848] New WiMAX ASN Protocol (WMXA) Dissector

2007-10-07 Thread Stephen Croll
Martin Mathieson wrote: > Have you looked at this new submission in detail, or tried it out? >Does it handle anything that is missing from the current one we have, > or handle something in a better way? > I don't actually work with WiMAX, and haven't asked colleagues who > do to play with this n

Re: [Wireshark-dev] WiMAX ASN Control Protocol dissector submission status?

2007-09-07 Thread Stephen Croll
Martin Mathieson wrote: > This dissector has already been useful to us, thanks again for posting it. > You're welcome. > (2) I'd probably add more expert items to report more things like: > - length fields not being consistent with that implied by type of TLV > - unknown tlv codes >

Re: [Wireshark-dev] WiMAX ASN Control Protocol dissector submission status?

2007-09-06 Thread Stephen Croll
Wen Cheng wrote: > Great job Stephen. I'm a wimax tester, I really like your tool. But I > think the display pattern of TLVs is not very good from a tester point > of view. May I help to do some improvment work? What specifically don't you like? Can you provide examples of how TLVs are currently

Re: [Wireshark-dev] WiMAX ASN Control Protocol dissector submission status?

2007-09-06 Thread Stephen Croll
How about the following workaround? Please note that I do not have access to a Windows development environment, but this patch has been tested on a Fedora 7 Linux host. pika.localdomain:~/mobileMetrics/wireshark/svnWork/latest 0:22> svn diff Index: plugins/wimaxasncp/packet-wimaxasncp.c =

[Wireshark-dev] WiMAX ASN Control Protocol dissector submission status?

2007-09-06 Thread Stephen Croll
Just checking on the submission status of the WiMAX ASN Control Protocol dissector. Is there anything further I need to do to have it accepted/committed? For reference, the ticket is: Bugzilla Bug 1811 New WiMAX ASN Control Protocol (WIMAXASNCP) Dissector http://bugs.wireshark.org/bugzill