Re: [Wireshark-dev] [PATCH] wiretap: Add MPEG PES.

2007-08-24 Thread Shaun Jackman
w the PES dissector usually works, you should try using wireshark to open an MPEG PES file: the first few megs of a DVD VOB file should do. Cheers, Shaun On 8/6/07, Shaun Jackman <[EMAIL PROTECTED]> wrote: > On 8/6/07, Luis EG Ontanon <[EMAIL PROTECTED]> wrote: > > The patch

[Wireshark-dev] Bugzilla error: Insecure dependency in exec

2007-08-19 Thread Shaun Jackman
I saw the following error when I added an attachment to a bug. Cheers, Shaun Software error: Insecure dependency in exec while running with -T switch at /usr/local/lib/perl5/site_perl/5.8.8/Mail/Mailer/sendmail.pm line 16, line 1. For help, please send mail to the webmaster (webmaster[AT]wires

Re: [Wireshark-dev] [PATCH] Further improvements to the MPEG decoder

2007-08-19 Thread Shaun Jackman
Please apply or provide comments. Thanks, Shaun On 8/9/07, Shaun Jackman <[EMAIL PROTECTED]> wrote: > This patch adds SCR, PTS, and DTS decoding to the MPEG PES decoder. > > Cheers, > Shaun > > 2007-08-09 Shaun Jackman <[EMAIL PROTECTED]> > > *

[Wireshark-dev] [PATCH] Further improvements to the MPEG decoder

2007-08-09 Thread Shaun Jackman
This patch adds SCR, PTS, and DTS decoding to the MPEG PES decoder. Cheers, Shaun 2007-08-09 Shaun Jackman <[EMAIL PROTECTED]> * asn1/mpeg/packet-mpeg-pes-template.c: Improved decoding of PES extension header and Pack header. Decode SCR, PTS, and DTS. * asn1/mpe

Re: [Wireshark-dev] [PATCH] wiretap: Add MPEG PES.

2007-08-06 Thread Shaun Jackman
On 8/6/07, Luis EG Ontanon <[EMAIL PROTECTED]> wrote: > The patch is just to be able to open files with PES encoding. > It doesn't add nothing to decoding. The decoder is already written. It's in epan/dissectors/packet-mpeg-pes.c. However, the decoder is only currently hooked for being able to ope

[Wireshark-dev] [PATCH] wiretap: Add MPEG PES.

2007-08-05 Thread Shaun Jackman
This patch adds MPEG PES (packetized elementary stream) to the list of magic types in wiretap/mpeg.c. Cheers, Shaun 2007-08-05 Shaun Jackman <[EMAIL PROTECTED]> * wiretap/mpeg.c (magic): Add MPEG PES. Index: wiretap/

Re: [Wireshark-dev] [PATCH 2/2] asn1: New MPEG dissector

2007-03-22 Thread Shaun Jackman
On 3/22/07, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > modified and checked in Thanks again, Ronnie! Cheers, Shaun ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-22 Thread Shaun Jackman
On 3/22/07, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > I have checked in the wiretap patch after doing the changes listed. Great! Thanks for doing the massaging necessary to check in the patch. Cheers, Shaun ___ Wireshark-dev mailing list Wireshark-de

Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-21 Thread Shaun Jackman
On 3/20/07, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > 1, shouldnt the defines MPA_MARSHAL_... really be called > MPA_UNMARSHAL_... instead? Good point. > 2, do you really need all these includes? > +#include > +#include > +#include > +#include > +#include > +#include > +#include > are a

Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-16 Thread Shaun Jackman
On 3/15/07, Jeff Morriss <[EMAIL PROTECTED]> wrote: Actually the patch isn't attached ;-) Grumble. =P 2007-03-15 Shaun Jackman <[EMAIL PROTECTED]> * wiretap/Makefile.common (NONGENERATED_C_FILES): Add mpeg.c. (NONGENERATED_HEADER_FILES): Add mpeg.h.

[Wireshark-dev] [PATCH 2/2] asn1: New MPEG dissector

2007-03-15 Thread Shaun Jackman
On 8/25/06, Shaun Jackman <[EMAIL PROTECTED]> wrote: > 2, dont read straight into a bitfield struct. > c does not define the packing order or padding of fields in a bitfield > and this would be nonportable. > please change to read into an array of char and then add code to >

[Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-15 Thread Shaun Jackman
in. am i missing something? The MPEG dissector is no longer a plugin. The updated patch is attached! Cheers, Shaun 2007-03-15 Shaun Jackman <[EMAIL PROTECTED]> * wiretap/Makefile.common (NONGENERATED_C_FILES): Add mpeg.c. (NONGENERATED_HEADER_FILES): Add mpeg.h.

Re: [Wireshark-dev] Heuristic dissector for "wtap_encap"

2006-12-23 Thread Shaun Jackman
On 12/23/06, Shaun Jackman <[EMAIL PROTECTED]> wrote: > Is it possible to register a heuristic dissector for a particular > "wtap_encap" type? I came up with a solution. I registered one normal dissector against the specific "wtap_encap" type and all the o

[Wireshark-dev] Heuristic dissector for "wtap_encap"

2006-12-23 Thread Shaun Jackman
Is it possible to register a heuristic dissector for a particular "wtap_encap" type? I added a wtap MPEG file type, WTAP_ENCAP_MPEG. Now I want to add two different dissectors, one for MPEG PES (a normal MPEG video file), and one for MP3 (MPEG 1 layer 3 audio). So, I called... dissector_ad

Re: [Wireshark-dev] Why replace ntohl() with g_ntohl()?

2006-11-25 Thread Shaun Jackman
On 11/24/06, Jeff Morriss <[EMAIL PROTECTED]> wrote: > But why do all that autoconf work at all when glib has already done it > and is guaranteed to provide a g_ntohl()? Because one method obfuscates the source code, and the other doesn't. autoconf solves this problem the correct way, by fixing th

[Wireshark-dev] Why replace ntohl() with g_ntohl()?

2006-11-16 Thread Shaun Jackman
This task seems to be a fundamentally broken idea. Why use a funky g_ntohl -- or any g_xxx function for that matter -- when there's a perfectly good, standard library function, namely ntohl? If a particular architecture doesn't provide ntohl, one may use autoconf to detect this case and provide nt

Re: [Wireshark-dev] [PATCH] acn: Add DMX streaming protocol (E1.31)

2006-10-26 Thread Shaun Jackman
On 10/26/06, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > we have batteling dissectors > > two dissectors enter, one dissector leaves > > maybe you and Bill can work on merging the two dissectors into one > single one that contains all the enhancements? My dissector included only the work necessar

[Wireshark-dev] [PATCH] AUTHORS: Shaun Jackman

2006-10-25 Thread Shaun Jackman
This patch brings my email address and list of work up to date. Cheers, Shaun Index: AUTHORS === --- AUTHORS (revision 19609) +++ AUTHORS (working copy) @@ -2205,8 +2205,10 @@ Exception logic fixes } -Shaun Jackman

Re: [Wireshark-dev] [PATCH] plugins/rdm: Update to ANSI E1.20-2006

2006-10-19 Thread Shaun Jackman
On 10/18/06, Shaun Jackman <[EMAIL PROTECTED]> wrote: > On 10/18/06, Jaap Keuter <[EMAIL PROTECTED]> wrote: > > Hi, > > > > Checked in. Revision 19596. > > > > Thanx, > > Jaap > > Great! Thanks. In revision 19610, the empty

Re: [Wireshark-dev] Duplicate dissector rdm

2006-10-19 Thread Shaun Jackman
On 10/19/06, Stephen Fisher <[EMAIL PROTECTED]> wrote: > Ever since RDM became a normal dissector, I am getting this message when > running from the latest SVN: > > 10:44:35 Err Duplicate protocol name "Remote Device > Management"! This might be caused by an inappropriate plugin or a > de

Re: [Wireshark-dev] [PATCH] plugins/rdm: Update to ANSI E1.20-2006

2006-10-18 Thread Shaun Jackman
On 10/18/06, Jaap Keuter <[EMAIL PROTECTED]> wrote: > Hi, > > Checked in. Revision 19596. > > Thanx, > Jaap Great! Thanks. Cheers, Shaun ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [PATCH] plugins/rdm: Update to ANSI E1.20-2006

2006-10-17 Thread Shaun Jackman
On 10/14/06, Shaun Jackman <[EMAIL PROTECTED]> wrote: ... > > > 3. Now that it became an ANSI standard it's time to move this plugin to > > > the regular dissectors. > > > > Okay. Will do. > > Cool. I'll send a new patch up some time next wee

Re: [Wireshark-dev] [PATCH] plugins/rdm: Update to ANSI E1.20-2006

2006-10-14 Thread Shaun Jackman
On 10/14/06, Jaap Keuter <[EMAIL PROTECTED]> wrote: > On Sat, 14 Oct 2006, Shaun Jackman wrote: ... > > > 2. Please keep the original Wireshark (C) in place and the GPL clause > > > intact. > > > > I removed the section of the licensing information that gave

Re: [Wireshark-dev] [PATCH] plugins/rdm: Update to ANSI E1.20-2006

2006-10-14 Thread Shaun Jackman
On 10/14/06, Shaun Jackman <[EMAIL PROTECTED]> wrote: > Hello Japp, Sorry, Jaap. In haste, I misspelled your name. Cheers, Shaun ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [PATCH] plugins/rdm: Update to ANSI E1.20-2006

2006-10-14 Thread Shaun Jackman
Hello Japp, On 10/14/06, Jaap Keuter <[EMAIL PROTECTED]> wrote: > Hi, > > Some remarks: > 1. The patch doesn't apply cleanly to the HEAD Grumble. I'll re-diff. > 2. Please keep the original Wireshark (C) in place and the GPL clause > intact. I removed the section of the licensing information th

Re: [Wireshark-dev] [PATCH] plugins/rdm: Update to ANSI E1.20-2006

2006-10-14 Thread Shaun Jackman
On 9/30/06, Shaun Jackman <[EMAIL PROTECTED]> wrote: The RDM protocol has been accepted as ANSI standard E1.20-2006. The following patch updates the decoder to that spec. Please apply. Cheers, Shaun 2006-09-30 Shaun Jackman <[EMAIL PROTECTED]> * plugins/rdm/moduleinf

[Wireshark-dev] [PATCH] plugins/rdm: Update to ANSI E1.20-2006

2006-09-30 Thread Shaun Jackman
The RDM protocol has been accepted as ANSI standard E1.20-2006. The following patch updates the decoder to that spec. Please apply. Cheers, Shaun 2006-09-30 Shaun Jackman <[EMAIL PROTECTED]> * plugins/rdm/moduleinfo.h (VERSION): Bump to 0.1.0. * plugins/rdm/packet

Re: [Wireshark-dev] asn1: New MPEG dissector

2006-08-25 Thread Shaun Jackman
en add code to manually unmarshall it into the fields of the bitfield Not yet done. Cheers, Shaun Signed-off-by: Shaun Jackman <[EMAIL PROTECTED]> 2006-08-25 Shaun Jackman <[EMAIL PROTECTED]> * wiretap/Makefile.common (NONGENERATED_C_FILES): Add mpeg.c. (NONGENE

Re: [Wireshark-dev] asn1: New MPEG dissector

2006-08-25 Thread Shaun Jackman
On 8/25/06, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > Can you change the wiretap reader file to > 1, add a GPL banner Will do. > in the wiretap files > 1, dont read sizeof unsigned bytes > unsigned may differ between platforms and compilershardcode the > exact number of bytes to read inst

Re: [Wireshark-dev] [PATCH 2/2] plugins: New MPEG dissector

2006-08-25 Thread Shaun Jackman
On 8/25/06, Mike Duigou <[EMAIL PROTECTED]> wrote: > Cool dissector! > > You may want to register your dissector as part of the growing mime > media type dissector type table. This would allow any dissector which > generically handles mime content to dissect mpeg data. It's pretty easy > to add med

[Wireshark-dev] [PATCH 2/2] asn1: New MPEG dissector

2006-08-25 Thread Shaun Jackman
This patch posts only the asn1 portion of the previous MPEG patch. It omits the plugins/mpeg/* portion. It also adds a GPL license to the two new files. Cheers, Shaun Signed-off-by: Shaun Jackman <[EMAIL PROTECTED]> 2006-08-25 Shaun Jackman <[EMAIL PROTECTED]> * asn1/m

Re: [Wireshark-dev] wiretap: New MPEG file format

2006-08-25 Thread Shaun Jackman
On 8/25/06, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > Can you add the GPL boilerplate to some of the files that are missing it. Yes. Can do. > Why do you create a mpeg plugin directory? > To me it looks like an normal dissector generated by asn2wrs and as > such it is not a plugin. am i miss

[Wireshark-dev] [PATCH 2/2] plugins: New MPEG dissector

2006-08-25 Thread Shaun Jackman
MPEG audio file (mp3 for example). The second half of the patch adds the protocol decoder. This patch is generated against wireshark 0.99.2. Cheers, Shaun Signed-off-by: Shaun Jackman <[EMAIL PROTECTED]> 2006-08-25 Shaun Jackman <[EMAIL PROTECTED]> * asn1/mpeg/Makefile: Ne

[Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2006-08-25 Thread Shaun Jackman
MPEG audio file (mp3 for example). The second half of the patch adds the protocol decoder. This patch is generated against wireshark 0.99.2. Cheers, Shaun Signed-off-by: Shaun Jackman <[EMAIL PROTECTED]> 2006-08-25 Shaun Jackman <[EMAIL PROTECTED]> * wiretap/Makefile.common