Hi,
I think that in this case there is no need for a conversion macro, since
we are not dealing with arrays but with pointers to value_string_ext.
By the way, are the VALS/TFS/RVALS casts necessary for certain
compilers? Because I thought that arrays automatically decay to pointers
when needed
Anders Broman wrote:
> I'm sure the GSM/UMTS related dissectors would benefit especially if
> "index method" can be used. Asn2wrs
> should perhaps be changed to use the new method. I just don't have the
> traces nor time to so benchmarking.
> Regards
> Anders
Yes, going to O(1) will definitely m
Hi,
I did some benchmarking on the performance gains from the switch to
binary search in the SANC and ISPC arrays, that I want to share with the
list. The SANC array contains ~900 entries, while the 2 ISPC arrays
(signalling point and operator names) contain ~5k entries each.
For this experime
wouldn't it be better if we hid the MTP3 equivalent entries? As it is
now, the same information gets printed 2 or 3 times.
Regards,
Gerasimos
> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2748
>
> Jeff Morriss changed:
>
>What|Removed |Added
> ---
Hi Brian,
there is no need to add a text string as blurb, if it is the same as
the title of the field, so for example the ipv4 one would become:
{ &hf_helen_ipv4,
{ "IPv4", "helen.ipv4address", FT_IPv4, BASE_NONE,
NULL, 0x0,
NULL, HFILL}},
Almost all of the string constants are used for initializing data
structures, so an extra problem I think is that the contents of a
strings array cannot be directly used for initializing e.g. the
hf_register_info array, since constants are needed for that. A
solution for that would be to initialize
Yes... more reasonable to move them to new_packet_list.c. Thanks, Stig.
/Gerasimos
2010/1/27 Stig Bjørlykke :
> On 26. jan. 2010, at 19.21, di...@wireshark.org wrote:
>
>> Log:
>> Move underscore escaping/unscaping function to strutil.c;
>
> I think we have to move the usage of this functions to
Thank you for your help Jakub and Bill, just committed 31662 following
your advice.
2010/1/25 Bill Meier :
> Jakub Zawadzki wrote:
>> Hi,
>>
>> On Mon, Jan 25, 2010 at 10:52:55AM +0200, Gerasimos Dimitriadis wrote:
>>> These two functions were defined in e
Hi all,
yesterday I've checked in code for escaping/unescaping the underscores
in the column titles. I've tested it under linux, but the windows
buildbot fails at the linking stage with:
libui.lib(new_packet_list.obj) : error LNK2019: unresolved external
symbol _g_strdup_unescape_underscore refer
Thanks Stig... my first contribution in the gui turf was more than a
little bit sloppy. I just committed (rev 31649) a solution that takes
care of the escaping/unescaping of the column titles under the new
packet list. Will look at the main packet list tomorrow. Hope I got it
right this time.
/Ger
boun...@wireshark.org on behalf of Gerasimos Dimitriadis
> Sent: Wed 1/20/2010 12:21 PM
> To: wireshark-dev@wireshark.org
> Subject: [Wireshark-dev] Question on format_value variant
> ofproto_tree_add_bits_item function (Take 2)
>
> Hi all,
>
> I am writing again my question, b
Hi all,
I am writing again my question, because admittedly it was not very
clear what I was asking in the previous email :-[
I want to create a _format_value variant(s) of the
proto_tree_add_bits_item function. The easiest way to do so is to
create a single function that takes a void * pointer of
Hi all,
I've been looking for a _format_value variant of the proto_tree_add_bits_item
function, because of the increased flexibility.
My initial approach was to create a single function that can deal with
all (at least the most common)
types of header fields, so I was thinking of passing the refe
13 matches
Mail list logo
