Re: [Wireshark-dev] Missing text2pcap-scanner.l in repository

2022-08-23 Thread Jirka Novak
Hi,    By chance I noticed that there is text2pcap-scanner.c which is based on text2pcap-scanner.l, but the file is not in repository.    It was there, but was removed.    Was removal intended? Yes, ui/text_import_scanner.l now handles processing both for text2pcap and

Re: [Wireshark-dev] Future of extcap "API"

2022-08-23 Thread Tomasz Moń
On Tue, Aug 23, 2022 at 6:24 PM Jirka Novak wrote: > > The problem with GenerateConsoleCtrlEvent() is that the caller has to > > be attached to the target process console. While we could technically > > do so, it requires freeing any already open console because process > > can be attached to at m

Re: [Wireshark-dev] Missing text2pcap-scanner.l in repository

2022-08-23 Thread John Thacker
On Tue, Aug 23, 2022, 4:04 PM Jirka Novak wrote: > Hi, > >By chance I noticed that there is text2pcap-scanner.c which is based > on text2pcap-scanner.l, but the file is not in repository. >It was there, but was removed. > >Was removal intended? > Yes, ui/text_import_scanner.l now han

[Wireshark-dev] Missing text2pcap-scanner.l in repository

2022-08-23 Thread Jirka Novak
Hi, By chance I noticed that there is text2pcap-scanner.c which is based on text2pcap-scanner.l, but the file is not in repository. It was there, but was removed. Was removal intended? Best regards,

Re: [Wireshark-dev] Future of extcap "API"

2022-08-23 Thread Jirka Novak
Hi, Adding another helper may be helpful, as it would probably gives us greater control, and maybe also solve the "helper-script" issue in the future by putting that stuff inside Wireshark? I am just wondering if it is worth the effort. We can obviously strive for a perfect - no user interact

Re: [Wireshark-dev] Future of extcap "API"

2022-08-23 Thread Jirka Novak
Hi, What do you think about that options? I have no idea why you didn't even consider sending CTRL_BREAK_EVENT using GenerateConsoleCtrlEvent() as a graceful shutdown mechanism on Windows. Wireshark creates all extcaps with a hidden console window (CREATE_NEW_CONSOLE and SW_HIDE flags set). C

Re: [Wireshark-dev] display filter scanner.l possible weirdness

2022-08-23 Thread João Valverde
On 8/23/22 15:12, Richard Sharpe wrote: On Tue, Aug 23, 2022 at 6:56 AM João Valverde wrote: On 8/23/22 14:29, Richard Sharpe wrote: On Tue, Aug 23, 2022 at 2:30 AM João Valverde wrote: On 8/22/22 14:42, Richard Sharpe wrote: Hi folks, In trying to introduce my contexts approach for disp

Re: [Wireshark-dev] display filter scanner.l possible weirdness

2022-08-23 Thread Richard Sharpe
On Tue, Aug 23, 2022 at 6:56 AM João Valverde wrote: > > On 8/23/22 14:29, Richard Sharpe wrote: > > On Tue, Aug 23, 2022 at 2:30 AM João Valverde wrote: > >> On 8/22/22 14:42, Richard Sharpe wrote: > >>> Hi folks, > >>> > >>> In trying to introduce my contexts approach for display filters to > >

Re: [Wireshark-dev] display filter scanner.l possible weirdness

2022-08-23 Thread João Valverde
On 8/23/22 14:29, Richard Sharpe wrote: On Tue, Aug 23, 2022 at 2:30 AM João Valverde wrote: On 8/22/22 14:42, Richard Sharpe wrote: Hi folks, In trying to introduce my contexts approach for display filters to handle embedded/recursive structures in 802.11 Information Elements (TLVs) I came

Re: [Wireshark-dev] display filter scanner.l possible weirdness

2022-08-23 Thread Richard Sharpe
On Tue, Aug 23, 2022 at 2:30 AM João Valverde wrote: > > On 8/22/22 14:42, Richard Sharpe wrote: > > Hi folks, > > > > In trying to introduce my contexts approach for display filters to > > handle embedded/recursive structures in 802.11 Information Elements > > (TLVs) I came across this in epan/df

Re: [Wireshark-dev] Is there some way in gitlab that I can be automatically informed when merge requests are created for ieee80211?

2022-08-23 Thread chuck c
:In application notifications for code changes" https://gitlab.com/gitlab-org/gitlab/-/issues/1817 https://gitlab.com/gitlab-org/gitlab/-/issues/1817#note_268635153 "With this, you can use any RSS reader (I use RSSOwl) and subscribe to it. You can even modify the path and subscribe to any file or

Re: [Wireshark-dev] display filter scanner.l possible weirdness

2022-08-23 Thread João Valverde
On 8/22/22 14:42, Richard Sharpe wrote: Hi folks, In trying to introduce my contexts approach for display filters to handle embedded/recursive structures in 802.11 Information Elements (TLVs) I came across this in epan/dfilter/scanner.l: - - ([.][-+[:

Re: [Wireshark-dev] Future of extcap "API"

2022-08-23 Thread Roland Knall
Adding another helper may be helpful, as it would probably gives us greater control, and maybe also solve the "helper-script" issue in the future by putting that stuff inside Wireshark? I am just wondering if it is worth the effort. We can obviously strive for a perfect - no user interaction requir

Re: [Wireshark-dev] Future of extcap "API"

2022-08-23 Thread Tomasz Moń
On Mon, Aug 22, 2022 at 9:37 PM Jirka Novak wrote: > >> What do you think about that options? > > > > I have no idea why you didn't even consider sending CTRL_BREAK_EVENT > > using GenerateConsoleCtrlEvent() as a graceful shutdown mechanism on > > Windows. Wireshark creates all extcaps with a hidd