Re: [Wireshark-dev] Editor config and code formatting

2022-03-01 Thread Roland Knall
Policy always was and has been, that we try to achieve consistent guidelines for new files and in general the guidelines for each file should be reflecting that files style. Although I do appreciate applying consistent styles, I acknowledge the fact that we have a really old code base in some

Re: [Wireshark-dev] Editor config and code formatting

2022-03-01 Thread João Valverde
On 01/03/22 17:45, David Perry wrote: Hi all, Bottom line up front: how much do people care about the formatting of Wireshark's source code? I would like to have indentation harmonized (and enforced consistently) across the entire C code base. Preferably 4-space. Don't care so much about oth

[Wireshark-dev] Editor config and code formatting

2022-03-01 Thread David Perry
Hi all, Bottom line up front: how much do people care about the formatting of Wireshark's source code? Background: I'm looking into [#17253][1]. It's chiefly about removing editor modelines from the footer of each source file in favour of just using `.editorconfig` files. But by extension it

Re: [Wireshark-dev] Build breakage on master?

2022-03-01 Thread Martin Mathieson via Wireshark-dev
Thanks for the responses. Somehow, epan/dissectors/packet-ncp.c did exist in the build folder, but was empty. After deleting it and rebuilding the correct file was generated. Martin On Tue, Mar 1, 2022 at 12:02 AM Guy Harris wrote: > > On Mon, Feb 28, 2022 at 10:58 AM Martin Mathieson via