Re: [Wireshark-dev] Need help figuring out a large gap in trace | Windows 11

2021-12-22 Thread Jaap Keuter
Hi, Not sure what’s going on here, but there’s one thing I would like to point out. For long term capture I would *strongly* recommend using dumpcap instead. Reason behind this is that Tshark invokes the dissection engine for the captured packets, which in this case is not what’s needed, but sti

Re: [Wireshark-dev] pre-commit error: extcap.c: error: found these preference variables used in more than one prefs_register_*_preference:

2021-12-22 Thread Jirka Novak
Hi, I understand the check now. So I can propose to to add exceptions to check. checkAPIs.pl has exceptions for many other checks so it can be extended to e.g. ignore arg->pref_valptr in this case. Sure... it is a practical solution, at least until no one can understand anymore what checkAPI

[Wireshark-dev] Need help figuring out a large gap in trace | Windows 11

2021-12-22 Thread Adithya Krishna
Hi there! I am a new user of Wireshark and recently started logging packet traces on my Windows 11 computer using the tshark command prompt option. I am using a ring-buffer with a duration filter, and the tracing has been mostly fine. Below is the exact CLI prompt being used. [image: image.png]

Re: [Wireshark-dev] pre-commit error: extcap.c: error: found these preference variables used in more than one prefs_register_*_preference:

2021-12-22 Thread Jirka Novak
Hi, This was added in commit 1089bdb7d4911a5508f86a0eea59418b424b265c. Catches mistakes where the same variable is populated by multiple preferences: prefs_register_bool_preference(epl_module, "show_soc_flags", "text1", "desc1", &show_soc_flags); prefs_register_bool_p

Re: [Wireshark-dev] pre-commit error: extcap.c: error: found these preference variables used in more than one prefs_register_*_preference:

2021-12-22 Thread João Valverde
On 22/12/21 11:46, Jirka Novak wrote: Hi, This was added in commit 1089bdb7d4911a5508f86a0eea59418b424b265c. Catches mistakes where the same variable is populated by multiple preferences: prefs_register_bool_preference(epl_module, "show_soc_flags", "text1", "desc1", &sh

Re: [Wireshark-dev] pre-commit error: extcap.c: error: found these preference variables used in more than one prefs_register_*_preference:

2021-12-22 Thread Jirka Novak
Hi, This was added in commit 1089bdb7d4911a5508f86a0eea59418b424b265c.     Catches mistakes where the same variable is populated by multiple preferences:     prefs_register_bool_preference(epl_module, "show_soc_flags", "text1", "desc1",     &show_soc_flags);     prefs_register_bool_p

Re: [Wireshark-dev] pre-commit error: extcap.c: error: found these preference variables used in more than one prefs_register_*_preference:

2021-12-22 Thread João Valverde
This was added in commit 1089bdb7d4911a5508f86a0eea59418b424b265c.     Catches mistakes where the same variable is populated by multiple preferences:     prefs_register_bool_preference(epl_module, "show_soc_flags", "text1", "desc1",     &show_soc_flags);     prefs_register_bool_preference(

[Wireshark-dev] pre-commit error: extcap.c: error: found these preference variables used in more than one prefs_register_*_preference:

2021-12-22 Thread Jirka Novak
Hi, I'm working on !5519 - Prefs/Extcap: Added support for password which is never stored on the disk. It is done and working, but I can't pass pre-commit check. It says: $ bash ./tools/pre-commit 'HEAD^1' extcap.c: error: found these preference variables used in more than one prefs_regis