Re: [Wireshark-dev] pfcp ctag decode bug

2020-09-11 Thread Guy Harris
On Sep 11, 2020, at 7:04 PM, Ranjeet kumar singh wrote: > I am seeing following error > > [Dissector bug, protocol PFCP: > C:\buildbot\builders\wireshark-3.2-64\windows-2019-x64\build\epan\proto.c:11594: > field pfcp.c_tag.dei_flag is not of type FT_CHAR or an FT_{U}INTn > type] > > with a pfcp

[Wireshark-dev] pfcp ctag decode bug

2020-09-11 Thread Ranjeet kumar singh
Hi I am seeing following error [Dissector bug, protocol PFCP: C:\buildbot\builders\wireshark-3.2-64\windows-2019-x64\build\epan\proto.c:11594: field pfcp.c_tag.dei_flag is not of type FT_CHAR or an FT_{U}INTn type] with a pfcp session establishment request. Can someone please confirm if it is a

Re: [Wireshark-dev] Gitlab doesn't show all epan/dissectors/ files.

2020-09-11 Thread Graham Bloice
On Fri, 11 Sep 2020 at 12:47, Joakim Karlsson wrote: > Maybe it's time to split .h and .c files > > /include > /src > > //Joakim > > Apart from the oddness of altering our code layout due to the inadequacies of the review platform, there are nearly 1500 .c files so that won't fix the issue. >

Re: [Wireshark-dev] Gitlab doesn't show all epan/dissectors/ files.

2020-09-11 Thread Joakim Karlsson
Maybe it's time to split .h and .c files /include /src //Joakim On Wed, 9 Sep 2020 at 23:50, chuck c wrote: > It's not all bad. I've gotten much better at navigating the code using > VSCode since the migration. > :-) > > > On Wed, Sep 9, 2020 at 4:27 PM Graham Bloice > wrote: > >> >> >> On We