Re: [Wireshark-dev] Several small commits vs. one big

2019-07-09 Thread Tomasz Moń
On Tue, Jul 9, 2019 at 10:34 PM Thomas Wiens wrote: > If I split this, I hope there won't be a version in between which fails > to dissect all possible data without error. > As all my tests were done on the finished version. > Or is there an option to mark the single commits as consecutive patches

[Wireshark-dev] Several small commits vs. one big

2019-07-09 Thread Thomas Wiens
Hi, I've made a relative big change to the existing dissector for s7comm. I added further decoding of some functions, but first I had to implement packet reassembly. This also results in minor changes to some existing functions. Should I commit all changes at once (diff will look very messy, gitl