Re: [Wireshark-dev] Proper way to handle changes in the preferences

2019-06-16 Thread Pascal Quantin
Hi Sake, Le lun. 17 juin 2019 à 07:10, Sake Blok | SYN-bit a écrit : > Hi, > > I'm working on a patch to add the possibility to show times in milli- or > microsecond units. While working this out, I see a need to change the name > of certain preferences and/or change the values of other preferen

[Wireshark-dev] Proper way to handle changes in the preferences

2019-06-16 Thread Sake Blok | SYN-bit
Hi, I'm working on a patch to add the possibility to show times in milli- or microsecond units. While working this out, I see a need to change the name of certain preferences and/or change the values of other preferences. This will however break compatibility with older versions of Wireshark in

Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

2019-06-16 Thread Sake Blok | SYN-bit
> On 14 Jun 2019 (Fri), at 22:25, Roland Knall wrote: > > There is a patch currently waiting for inclusion. It would allow for > dissectors to easily make credentials (username/password) available and > present them in a tool window in Wireshark. > The main concern here is, that this could lead

Re: [Wireshark-dev] Conversation tracking in LUA dissector

2019-06-16 Thread Andreas
> I have a protocol with several versions. Dependent on the negotiated > protocol version at begin of the session the structure of the messages > is different. While writing C++ dissectors I used the conversation > member of pktinfo. How can I implement this in a LUA dissector? > > Corresponding t

Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

2019-06-16 Thread Richard Sharpe
On Sun, Jun 16, 2019 at 9:52 AM Jasper Bongertz wrote: > > Hi > > There is a patch currently waiting for inclusion. It would allow for > dissectors to easily make credentials (username/password) available and > present them in a tool window in Wireshark. > > The main concern here is, that this co

Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

2019-06-16 Thread Roland Knall
You can separate both. The dissectors tap can stay in there, and the UI can be implemented using the plugin_if interface, which allows for graphical UI plugins, that can receive tap data as well as any other data. It would work exactly as Guy had suggested it. cheers Am So., 16. Juni 2019 um 22:

Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

2019-06-16 Thread Dario Lombardo
On Sun, Jun 16, 2019 at 10:00 PM Guy Harris wrote: > > Would providing this capability as a "third-party" plugin (even if the > "third party" happens to be a Wireshark core developer) work? *Wireshark* > doesn't offer it as a built-in capability, but you can drop in a plugin to > get it. > > It

Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

2019-06-16 Thread Guy Harris
On Jun 16, 2019, at 9:52 AM, Jasper Bongertz wrote: > I have seen at least three occasions where the fact that credentials were > that easily accessed with a network analysis tool has resulted in a ban of > that exact tool by upper management. In one case this affected a freshly > bought licen

Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

2019-06-16 Thread Uli Heilmeier
> We would like your feedback on that topic * Speaking as the "application owner" of Wireshark in our group of companies I see no reason to ban Wireshark with such a function. => +1 to implement it * Speaking as a former network admin team lead, having a preference to disable the tool window w

Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

2019-06-16 Thread Jasper Bongertz
Title: Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted Hi There is a patch currently waiting for inclusion. It would allow for dissectors to easily make credentials (username/password) available and present them in a tool window in Wireshark. The main concern here is, t