Re: [Wireshark-dev] Gerrit problems ?

2018-08-08 Thread Gerald Combs
On 8/8/18 4:40 AM, Jaap Keuter wrote: > > > I’m not sure what to make of this but I noticed the following: > After having a (rather unremarkable) change (28995) accepted and merged by > Anders (thanks Anders!) I received the usual two emails about this > (Code-Review +2, Merged). The remarkabl

Re: [Wireshark-dev] New commit emails after gerrit update

2018-08-08 Thread Dario Lombardo
Perfect, thanks! On Wed, Aug 8, 2018 at 6:29 PM Gerald Combs wrote: > Over time Gerrit has been migrating its backend storage from SQL to git: > > https://gerrit.googlesource.com/homepage/+/md-pages/docs/Notedb.md > > For us this means that the commit email script gets triggered due to more > ki

Re: [Wireshark-dev] New commit emails after gerrit update

2018-08-08 Thread Gerald Combs
Over time Gerrit has been migrating its backend storage from SQL to git: https://gerrit.googlesource.com/homepage/+/md-pages/docs/Notedb.md For us this means that the commit email script gets triggered due to more kinds of activity. I updated it to send email only when refs/changes/* and refs/t

[Wireshark-dev] New commit emails after gerrit update

2018-08-08 Thread Dario Lombardo
I'm receiving emails like this for every commit email message for merged changes. What do they exactly mean? Are they useful or not? Maybe I'm missing something but they don't seem really useful to me. -- Forwarded message - From: Wireshark code review Date: Wed, Aug 8, 2018 at 5:

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

2018-08-08 Thread Dario Lombardo
On Wed, Aug 8, 2018 at 9:39 AM Martin Burnicki wrote: > So IMO it would make more sense to display such values with a fixed > floating point format similar to the Peer Clock Precision field, e.g. > > 0.00 instead of 0 > 0.944107 instead of 0.944107055664063 > 0.76 instead of 7.62939453125

Re: [Wireshark-dev] Gerrit problems ?

2018-08-08 Thread Dario Lombardo
On Wed, Aug 8, 2018 at 1:40 PM Jaap Keuter wrote: > I’m not sure what to make of this but I noticed the following: > After having a (rather unremarkable) change ( 28995) accepted and merged > by Anders (thanks Anders!) I received the usual two emails about this > (Code-Review +2, Merged). The rem

Re: [Wireshark-dev] Gerrit problems ?

2018-08-08 Thread Jaap Keuter
> On 8 Aug 2018, at 12:39, Peter Wu wrote: > > Hi Dylan. > > On Wed, Aug 08, 2018 at 10:01:38AM +0200, Peter Wu wrote: >> On Tue, Aug 07, 2018 at 09:30:38PM -0400, Dylan Ulis wrote: >>> Anybody else having Gerrit issues after the upgrade? Under Profile, my >>> username is blank. When I try to

Re: [Wireshark-dev] Gerrit problems ?

2018-08-08 Thread Peter Wu
Hi Dylan. On Wed, Aug 08, 2018 at 10:01:38AM +0200, Peter Wu wrote: > On Tue, Aug 07, 2018 at 09:30:38PM -0400, Dylan Ulis wrote: > > Anybody else having Gerrit issues after the upgrade? Under Profile, my > > username is blank. When I try to re-enter my old username I get "Code > > Review - Error.

Re: [Wireshark-dev] Gerrit problems ?

2018-08-08 Thread Peter Wu
Hi Dylan. On Tue, Aug 07, 2018 at 09:30:38PM -0400, Dylan Ulis wrote: > Anybody else having Gerrit issues after the upgrade? Under Profile, my > username is blank. When I try to re-enter my old username I get "Code > Review - Error. Username must contain only letters, numbers..." There appears to

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

2018-08-08 Thread Peter Wu
On Wed, Aug 08, 2018 at 09:48:46AM +0200, Martin Burnicki wrote: > > Eventually you (or the email admin) can find out why this happens. > > > > I don't have access to the infrastructure, but others can check.  > > Just FYI: Surprisingly, the confirmation emails for my private email > address

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

2018-08-08 Thread Martin Burnicki
Dario Lombardo wrote: > On Mon, Aug 6, 2018 at 1:20 PM Martin Burnicki > mailto:martin.burni...@meinberg.de>> wrote: [...] > Then I tried to create account on bugzilla with that private email > address, and bugzilla said a confirmation email had been sent. However, > that email never ar

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

2018-08-08 Thread Martin Burnicki
Guy Harris wrote: > On Aug 6, 2018, at 2:19 PM, Guy Harris wrote: > >> On Aug 6, 2018, at 4:20 AM, Martin Burnicki >> wrote: >> >>> As far as I have seen, proto_tree_add_double() seems to add a double >>> value to the output tree, >> >> *All* doubles use the same format string. The part of the