Re: [Wireshark-dev] Multiple TRANSUM fixes

2017-11-13 Thread Dario Lombardo
Apart from broken ability, how should gerrit behave with multiple "Bug:" tags? With one, once the change gets merged, it closes the bug on bugzilla. But what happens with multiple tags when just one gets merged? Just curious, if anyone knows... On Mon, Nov 13, 2017 at 8:00 PM, Michael Mann via Wir

[Wireshark-dev] Gerrit repository offline

2017-11-13 Thread Roland Knall
Hi It appears the gerrit repository is offline, we are working on the issue. cheers, Roland ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wire

Re: [Wireshark-dev] Multiple TRANSUM fixes

2017-11-13 Thread Paul Offord
Ok thanks Sent from Samsung Mobile on O2 Original message From: Michael Mann via Wireshark-dev Date: 13/11/2017 19:01 (GMT+00:00) To: wireshark-dev@wireshark.org Cc: Michael Mann Subject: Re: [Wireshark-dev] Multiple TRANSUM fixes You need separate line for each bug, ie.

Re: [Wireshark-dev] Multiple TRANSUM fixes

2017-11-13 Thread Michael Mann via Wireshark-dev
You need separate line for each bug, ie. Bug: 12345 Bug: 12346 Bug: 12347 When you do that on the initial push, gerrit will mark the bugs. If you do it after the initial commit, the bugs will only be notified when patch is submitted to master. The ability for Gerrit to actually move bug to

Re: [Wireshark-dev] Multiple TRANSUM fixes

2017-11-13 Thread Richard Sharpe
On Mon, Nov 13, 2017 at 10:32 AM, Paul Offord wrote: > Hi Richard, > > Yes that does sound best. You know when you enter the line: > > Bug: 12345 I suspect you can add multiple Bug: 12345 lines, but do not know. > into the commit comment, can I list the bugs? And if I do, will gerrit > updat

Re: [Wireshark-dev] Multiple TRANSUM fixes

2017-11-13 Thread Paul Offord
Hi Richard, Yes that does sound best. You know when you enter the line: Bug: 12345 into the commit comment, can I list the bugs? And if I do, will gerrit update Bugzilla? I'm guessing not for all, so what the best way to handle this? Thanks and regards...Paul -Original Message- Fr

Re: [Wireshark-dev] Multiple TRANSUM fixes

2017-11-13 Thread Richard Sharpe
On Mon, Nov 13, 2017 at 10:09 AM, Paul Offord wrote: > Hi, > > > > I want to submit a patched packet-transum.c file. It fixes three bugs, none > of which are currently on Bugzilla. Should I submit three bugs and then > refer to all three bugs in the patch commit comments? Or can I specify all >

[Wireshark-dev] Multiple TRANSUM fixes

2017-11-13 Thread Paul Offord
Hi, I want to submit a patched packet-transum.c file. It fixes three bugs, none of which are currently on Bugzilla. Should I submit three bugs and then refer to all three bugs in the patch commit comments? Or can I specify all three bugs in one Bugzilla report? What's the correct form? Che

Re: [Wireshark-dev] File load timing

2017-11-13 Thread Stig Bjørlykke
On Sat, Nov 11, 2017 at 8:05 PM, Paul Offord wrote: > Ah - we should spread the word. A couple of people mentioned it at #sf17eu It's stated in the release notes under "New and Updated Features", so when using the development version a good tip would probably be to regularly read the constantly u