Re: [Wireshark-dev] Filter expression aliases and parameterization ...

2017-11-08 Thread Maynard, Chris
Does a Wireshark Display Filter Macro[1] work for you? Analyze -> Display Filter Macros -> [+] Name: wlan_beacon Text: wlan.fc.type_subtype == 0x19 [OK] To use it: ${wlan_beacon} - Chris [1]: https://www.wireshark.org/docs/wsug_html_chunked/ChDisplayFilterMacrosSection.html >

Re: [Wireshark-dev] Filter expression aliases and parameterization ...

2017-11-08 Thread Richard Sharpe
On Wed, Nov 8, 2017 at 1:04 PM, Simon Barber via Wireshark-dev wrote: > I'd love to be able to add these, for example instead of writing > > wlan.fc.type_subtype == 0x19 > > write > > wlan.beacon OK, I'll mark you down as someone who is interested in aliasing of filter expressions. I will create

Re: [Wireshark-dev] Filter expression aliases and parameterization ...

2017-11-08 Thread Simon Barber via Wireshark-dev
I'd love to be able to add these, for example instead of writing wlan.fc.type_subtype == 0x19 write wlan.beacon Simon On Wed, Nov 8, 2017 at 12:27 AM, Richard Sharpe wrote: > Hi folks, > > At SharkFest Europe someone asked me about the possibility of the > filter expressions in the SMB2 diss

[Wireshark-dev] SPDX-License-Identifier blurbs

2017-11-08 Thread Gerald Combs
Earlier today I gave a short talk about navigating Wireshark's source code. One thing I mentioned is that we have quite a bit of boilerplate at the top and bottom of most files, and in the past this has confused git when copying and renaming files (for me, at least). I've uploaded a change at h

[Wireshark-dev] Can someone else test the fix to bug 6027?

2017-11-08 Thread Richard Sharpe
Hi folks, I have a review up to fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6027 and while I have tested it by downloading the capture and looking at the frames involved, it would good if others could do the same. Review is here: https://code.wireshark.org/review/#/c/24295/ -- Regar

Re: [Wireshark-dev] Who did this to master?

2017-11-08 Thread Richard Sharpe
On Wed, Nov 8, 2017 at 2:35 AM, Stig Bjørlykke wrote: > On Wed, Nov 8, 2017 at 10:43 AM, Richard Sharpe > wrote: >> My changes have not touched packet-btmesh.c >> >> CC packet-btmesh.lo >> packet-btmesh.c: In function 'uat_btmesh_record_update_cb': >> packet-btmesh.c:939:9: error: implicit

Re: [Wireshark-dev] Who did this to master?

2017-11-08 Thread Stig Bjørlykke
On Wed, Nov 8, 2017 at 10:43 AM, Richard Sharpe wrote: > My changes have not touched packet-btmesh.c > > CC packet-btmesh.lo > packet-btmesh.c: In function 'uat_btmesh_record_update_cb': > packet-btmesh.c:939:9: error: implicit declaration of function > 'create_master_security_keys' [-Werro

Re: [Wireshark-dev] Who did this to master?

2017-11-08 Thread Richard Sharpe
On Wed, Nov 8, 2017 at 2:00 AM, Dario Lombardo wrote: > When you want to blame someone, the proper command is git blame. > However, running > > git blame epan/dissectors/packet-btmesh.c Yeah, I should have done that ... > I don't get a straight answer, neither my master fails to compile. Hmmm,

Re: [Wireshark-dev] Who did this to master?

2017-11-08 Thread Dario Lombardo
When you want to blame someone, the proper command is git blame. However, running git blame epan/dissectors/packet-btmesh.c I don't get a straight answer, neither my master fails to compile. On Wed, Nov 8, 2017 at 10:43 AM, Richard Sharpe wrote: > My changes have not touched packet-btmesh.c >

[Wireshark-dev] Who did this to master?

2017-11-08 Thread Richard Sharpe
My changes have not touched packet-btmesh.c CC packet-btmesh.lo packet-btmesh.c: In function 'uat_btmesh_record_update_cb': packet-btmesh.c:939:9: error: implicit declaration of function 'create_master_security_keys' [-Werror=implicit-function-declaration] create_master_security_ke

[Wireshark-dev] Filter expression aliases and parameterization ...

2017-11-08 Thread Richard Sharpe
Hi folks, At SharkFest Europe someone asked me about the possibility of the filter expressions in the SMB2 dissector being prefixed with smb2 or smb3. That is: smb2.flags.replay or smb3.flags.replay. In addition, when I use dissector functions (through a dissector table) from another protocol, I