Re: [Wireshark-dev] packet-lorawan.c compile error because of stuff added yesterday ...

2017-06-14 Thread Erik de Jong
On Thu, Jun 15, 2017 at 3:09 AM, Guy Harris wrote: > On Jun 13, 2017, at 1:54 PM, Erik de Jong wrote: > > > Is it possible to have a petridish build for OSX as well? That's where > the issue came from originally and why it got into the master branch. > > That might be a good idea, but don't rely

Re: [Wireshark-dev] packet-lorawan.c compile error because of stuff added yesterday ...

2017-06-14 Thread Guy Harris
On Jun 13, 2017, at 1:54 PM, Erik de Jong wrote: > Is it possible to have a petridish build for OSX as well? That's where the > issue came from originally and why it got into the master branch. That might be a good idea, but don't rely on it to catch problems with older versions of libraries t

Re: [Wireshark-dev] Go to Qt 5.9 on Windows build bots?

2017-06-14 Thread Gerald Combs
The Windows builders are now using the following compiler and Qt versions: master: Visual Studio 2015 + Qt 5.9.0 master-2.4: Visual Studio 2015 + Qt 5.6.2 master-2.2: Visual Studio 2013 + Qt 5.6.2 master-2.0: Visual Studio 2013 + Qt 5.3.2 Qt 5.9.1 is scheduled to be released this month. We mi

Re: [Wireshark-dev] Fixing #12958 (Duplicated keys in -T json output)

2017-06-14 Thread Jaap Keuter
On 13-06-17 12:10, Daan De Meyer wrote: > Is creating the change on the code review site all I need to do or is some > other > step required before the patch can get reviewed? Hi, That is enough for the change to reviewed. Whenever that will be depend on interest and spare time availability of t

Re: [Wireshark-dev] Go to Qt 5.9 on Windows build bots?

2017-06-14 Thread Stig Bjørlykke
On Wed, Jun 14, 2017 at 1:49 PM, Anders Broman wrote: > I think Stig has tried it on MAC OS too if we want to update that too. I even committed fixes to the Qt code in 5.9 to allow us to use -Wshorten-64-to-32 for C++. I have not seen any issues so far. -- Stig Bjørlykke __

Re: [Wireshark-dev] Go to Qt 5.9 on Windows build bots?

2017-06-14 Thread Roland Knall
+1 Linux and Mac build fine already with 5.9 Regards > Am 14.06.2017 um 14:09 schrieb Graham Bloice : > > > >> On 14 June 2017 at 12:55, Pascal Quantin wrote: >> Hi Anders, >> >> Le 14 juin 2017 13:49, "Anders Broman" a écrit : >> Hi, >> >> Should we go to Qt 5.9 on the build bots before S

Re: [Wireshark-dev] Go to Qt 5.9 on Windows build bots?

2017-06-14 Thread Graham Bloice
On 14 June 2017 at 12:55, Pascal Quantin wrote: > Hi Anders, > > Le 14 juin 2017 13:49, "Anders Broman" a > écrit : > > Hi, > > Should we go to Qt 5.9 on the build bots before SharkFest? I have used t > without noticing any problems. > > > Given that it's the new LTS, it probably makes sense. ma

Re: [Wireshark-dev] Go to Qt 5.9 on Windows build bots?

2017-06-14 Thread Pascal Quantin
Hi Anders, Le 14 juin 2017 13:49, "Anders Broman" a écrit : Hi, Should we go to Qt 5.9 on the build bots before SharkFest? I have used t without noticing any problems. Given that it's the new LTS, it probably makes sense. master-2.0 and master-2.2 should stay on the previous Qt version to avo

[Wireshark-dev] Go to Qt 5.9 on Windows build bots?

2017-06-14 Thread Anders Broman
Hi, Should we go to Qt 5.9 on the build bots before SharkFest? I have used t without noticing any problems. This should allow us to decide if we want to switch to MSVC 2015 or 2017 easily. I think Stig has tried it on MAC OS too if we want to update that too. Regards Anders __