Re: [Wireshark-dev] Kasumi algorithm implementation

2017-02-27 Thread Joerg Mayer
On Mon, Feb 27, 2017 at 10:12:00PM +0100, Pascal Quantin wrote: > Nothing has changed since that time (except the fact that the link is > http://www.3gpp.org/specifications/60-confidentiality-algorithms). > As you said this was raised in the past so far not integrated to avoid > being potentially s

Re: [Wireshark-dev] Kasumi algorithm implementation

2017-02-27 Thread Pascal Quantin
Hi, Le 27 févr. 2017 21:43, "ss ws" a écrit : At the moment, there's a place holder file for the Kasumi algorithm found at: wireshark/epan/crypt/Kasumi.h And I found this dev thread form 2012 where the issue of Mitsubishi's patent on the algorithm (not the code) and the copyright issue with the

[Wireshark-dev] Kasumi algorithm implementation

2017-02-27 Thread ss ws
At the moment, there's a place holder file for the Kasumi algorithm found at: wireshark/epan/crypt/Kasumi.h And I found this dev thread form 2012 where the issue of Mitsubishi's patent on the algorithm (not the code) and the copyright issue with the Kasumi implementation found in ETSI's specificati

Re: [Wireshark-dev] Extcap version

2017-02-27 Thread Stig Bjørlykke
On Mon, Feb 27, 2017 at 11:42 AM, Dario Lombardo wrote: > "help" seems to be in the same position: lives in extcap_info and in > extcap_interface at the same time. I don't think we need both: I hardly > figure out how we'd need to different help pages/files for 2 different > intefaces of the same

Re: [Wireshark-dev] Extcap version

2017-02-27 Thread Roland Knall
With help I see it differently. It makes sense, that interfaces provided by the same tool may have different help pages, as they can have different parameters as well. Regarding those leaks, if you can send me some valgrind logs, I might close them while I am doing the other stuff? regards On Mo

Re: [Wireshark-dev] Extcap version

2017-02-27 Thread Dario Lombardo
Ok. Since I was on my way of cleaning up some leaks in extcap, I'll wait until you finish, maybe some of them will be gone. "help" seems to be in the same position: lives in extcap_info and in extcap_interface at the same time. I don't think we need both: I hardly figure out how we'd need to diffe

Re: [Wireshark-dev] Extcap version

2017-02-27 Thread Roland Knall
That is an early design flaw - still going strong to that very day. It stems from the fact, that the version query was introduced later on, and the interface list query basically covered that as well. Additionally, parsed extcap interfaces where not parsed on a tool (meaning executable) level, but

[Wireshark-dev] Extcap version

2017-02-27 Thread Dario Lombardo
Hi In extcap structs I've found 2 entries for "version". In typedef struct _extcap_interface { gchar * call; gchar * display; gchar * version; gchar * help; gchar * extcap_path; extcap_sentence_type if_type; } extcap_interface; and typedef struct _extcap_info { gchar