On Sep 24, 2015, at 11:42 AM, Simon Barber wrote:
> I am porting my radiotap only timeline code over to use the new radio
> dissector, and found the use of the flags aesthetically unpleasing (since I
> refer to them a lot). Would you object to me converting them to single bit
> fields, and me
I am porting my radiotap only timeline code over to use the new radio
dissector, and found the use of the flags aesthetically unpleasing (since I
refer to them a lot). Would you object to me converting them to single bit
fields, and memsetting the whole union to 0 to clear them?
On Thu, Sep 24, 20
> On Sep 24, 2015, at 10:53 AM, Simon Barber wrote:
>
> Is there any reason that the presence_flags in these structs are done as a
> single flags field, requiring separate #defines to define the individual
> flags, rather than individual single bit members of the struct?
(Presumably the singl
Is there any reason that the presence_flags in these structs are done as a
single flags field, requiring separate #defines to define the individual
flags, rather than individual single bit members of the struct?
Simon
___
Sent
On 9/24/15 6:51 AM, Jeff Morriss wrote:
> On 09/24/2015 05:04 AM, Alexis La Goutte wrote:
>> Hi Balint
>>
>> No a problem for me to add PIE on Wireshark
>> But no need to check if lib (Qt) use also PIE ?
>
> We already do--at least with autofoo (cmake seems to pick up the PIE flags
> from Qt's con
On 09/24/2015 05:04 AM, Alexis La Goutte wrote:
Hi Balint
No a problem for me to add PIE on Wireshark
But no need to check if lib (Qt) use also PIE ?
We already do--at least with autofoo (cmake seems to pick up the PIE
flags from Qt's config directly).
But I don't think there's a problem if
Hi Balint
No a problem for me to add PIE on Wireshark
But no need to check if lib (Qt) use also PIE ?
Regards,
On Thu, Sep 24, 2015 at 10:49 AM, Bálint Réczey
wrote:
> Hi All,
>
> I have just created a review to add PIE when it is available to default
> flags:
> https://code.wireshark.org/revi
Hi All,
I have just created a review to add PIE when it is available to default flags:
https://code.wireshark.org/review/#/c/10635
I think this matter is worth discussion here, too.
Should we enable more compiler flags which make Wireshark more secure
by default?
I Debian I will enable all harde
