Re: [Wireshark-dev] Put back closing } accidentally removed in previous commit.

2015-07-07 Thread Hadriel Kaplan
It was only failing on windows builds (it was inside a #ifdef Q_OS_WIN), so unless you built for windows, you wouldn’t have seen it. -hadriel > On Jul 8, 2015, at 2:12 AM, Joerg Mayer wrote: > > On Wed, Jul 08, 2015 at 05:18:06AM +, Wireshark code review wrote: >> URL: >> https://code.wir

Re: [Wireshark-dev] Put back closing } accidentally removed in previous commit.

2015-07-07 Thread Joerg Mayer
On Wed, Jul 08, 2015 at 05:18:06AM +, Wireshark code review wrote: > URL: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d7f0118a74d540d3c8b07296c2c7b248ed13b464 > Commits: > d7f0118 by Guy Harris (g...@alum.mit.edu): > Put back closing } accidentally removed in prev

Re: [Wireshark-dev] Plan to make NPcap available for Wireshark

2015-07-07 Thread Yang Luo
On Wed, Jul 8, 2015 at 12:56 AM, Guy Harris wrote: > > On Jul 7, 2015, at 8:56 AM, Joerg Mayer wrote: > > > While I understand the logic behind our argument, I don't agree with it: > > With the possibility of winpcap and npcap diverging, that may at one > point > > in time mean diverging and inc

Re: [Wireshark-dev] Plan to make NPcap available for Wireshark

2015-07-07 Thread Yang Luo
> The Wireshark suite doesn't hard-code npf.sys per se, it just uses the > Service Control Manager (SCM) to check the state of the "npf" service. To > allow co-existence of both WinPCap and NPcap on the same machine that > service name should be different for the two libraries. > > Arguably that c

Re: [Wireshark-dev] Plan to make NPcap available for Wireshark

2015-07-07 Thread Yang Luo
On Tue, Jul 7, 2015 at 11:56 PM, Joerg Mayer wrote: > On Mon, Jul 06, 2015 at 10:42:50AM +0800, Yang Luo wrote: > > The first reason is causing more efforts for apps. Nearly all apps I know > > have hard-coded the DLL file name, wpcap.dll by implicitly linking the > .lib > > or LoadLibrary call.

Re: [Wireshark-dev] Plan to make NPcap available for Wireshark

2015-07-07 Thread Joerg Mayer
On Tue, Jul 07, 2015 at 09:56:24AM -0700, Guy Harris wrote: > > On Jul 7, 2015, at 8:56 AM, Joerg Mayer wrote: > > > While I understand the logic behind our argument, I don't agree with it: > > With the possibility of winpcap and npcap diverging, that may at one point > > in time mean diverging

Re: [Wireshark-dev] Plan to make NPcap available for Wireshark

2015-07-07 Thread Guy Harris
On Jul 7, 2015, at 8:56 AM, Joerg Mayer wrote: > While I understand the logic behind our argument, I don't agree with it: > With the possibility of winpcap and npcap diverging, that may at one point > in time mean diverging and incompatible APIs. Also, what happens if a user > wants to use Wires

Re: [Wireshark-dev] Plan to make NPcap available for Wireshark

2015-07-07 Thread Graham Bloice
On 7 July 2015 at 16:56, Joerg Mayer wrote: > On Mon, Jul 06, 2015 at 10:42:50AM +0800, Yang Luo wrote: > > The first reason is causing more efforts for apps. Nearly all apps I know > > have hard-coded the DLL file name, wpcap.dll by implicitly linking the > .lib > > or LoadLibrary call. If I cha

Re: [Wireshark-dev] Plan to make NPcap available for Wireshark

2015-07-07 Thread Joerg Mayer
On Mon, Jul 06, 2015 at 10:42:50AM +0800, Yang Luo wrote: > The first reason is causing more efforts for apps. Nearly all apps I know > have hard-coded the DLL file name, wpcap.dll by implicitly linking the .lib > or LoadLibrary call. If I changed this name, all apps will need > modification for NP

Re: [Wireshark-dev] Plan to make NPcap available for Wireshark

2015-07-07 Thread Joerg Mayer
On Sat, Jul 04, 2015 at 10:26:13AM +0800, Yang Luo wrote: > Given that current Wireshark can't make use of NPcap because of the DLL > search path problem mentioned in > https://www.wireshark.org/lists/wireshark-dev/201506/msg00030.html, I'd > like to make a patch for Wireshark. As it is a security