Re: [Wireshark-dev] [RFC-PATCH] IB: Create single conversation for Infiniband connections whenever possible

2015-07-05 Thread Pascal Quantin
Le 6 juil. 2015 8:01 AM, "Slava Shwartsman" a écrit : > > Hi Pascal, > > Seems like my concerns become true. > > I uploaded the patch more than a week ago, and no reviews were made. > > https://code.wireshark.org/review/#/c/9210/ > > > > Would you like to assist please? > > Hi Slava, This is ex

Re: [Wireshark-dev] [RFC-PATCH] IB: Create single conversation for Infiniband connections whenever possible

2015-07-05 Thread Slava Shwartsman
Hi Pascal, Seems like my concerns become true. I uploaded the patch more than a week ago, and no reviews were made. https://code.wireshark.org/review/#/c/9210/ Would you like to assist please? Thanks in advance, Slava From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@w

Re: [Wireshark-dev] Enabling/disabling ANY heuristic dissector

2015-07-05 Thread Hadriel Kaplan
My 2 cents: > On Jul 5, 2015, at 11:32 PM, Guy Harris wrote: > > "Heuristic Protocol" or "Heuristic Dissector”? While “Dissector” makes more sense to me personally, do most users/IT-folks understand what a “Dissector” is? I think we’ve been conditioned to think of that word because we look a

Re: [Wireshark-dev] Enabling/disabling ANY heuristic dissector

2015-07-05 Thread mmann78
I think there's a mixture of both "Heuristic Protocols" and "Heuristic dissectors" and I'm not sure how clean the list would look if you merged the two into a single list (this just being anecdotal evidence browsing the lists in both tabs). The original motivation for this patch came from bug

Re: [Wireshark-dev] Enabling/disabling ANY heuristic dissector

2015-07-05 Thread Guy Harris
On Jul 5, 2015, at 8:14 PM, Hadriel Kaplan wrote: > BTW, in case someone’s curious, attached is a screenshot of the dialog window > tab Michael’s change adds. > > "Heuristic Protocol" or "Heuristic Dissector"? Should we have a single table, listing protocols, with up to two checkboxes, one

Re: [Wireshark-dev] Enabling/disabling ANY heuristic dissector

2015-07-05 Thread Hadriel Kaplan
> On Jul 5, 2015, at 7:02 PM, mman...@netscape.net wrote: > > I uploaded a patch to Gerrit that allows enabling/disabling of any heuristic > dissector (https://code.wireshark.org/review/9508/). > > Some comments about the patch (others are welcome to add more): > 1. Not sure how to best expres

Re: [Wireshark-dev] Plan to make NPcap available for Wireshark

2015-07-05 Thread Yang Luo
The first reason is causing more efforts for apps. Nearly all apps I know have hard-coded the DLL file name, wpcap.dll by implicitly linking the .lib or LoadLibrary call. If I changed this name, all apps will need modification for NPcap. LoadLibrary is easy to change, just add another file name for

Re: [Wireshark-dev] Enabling/disabling ANY heuristic dissector

2015-07-05 Thread mmann78
I uploaded a patch to Gerrit that allows enabling/disabling of any heuristic dissector (https://code.wireshark.org/review/9508/). Some comments about the patch (others are welcome to add more): 1. Not sure how to best express the relationship between the "name" of the heuristic dissector and i

Re: [Wireshark-dev] Plan to make NPcap available for Wireshark

2015-07-05 Thread Graham Bloice
As WinPcap and NPcap seem to be diverging, in the short-term at least, should the dll's be named differently? The following is just an observation, not intended as any criticism. As NPCap has chosen to co-exist with WinPCap by using a (non-standard) Windows directory, although that (currently) do

Re: [Wireshark-dev] Plan to make NPcap available for Wireshark

2015-07-05 Thread Yang Luo
Good question, Graham. This is simply because WinPcap has taken the System32\SysWow64 dirs and NPcap wants to coexist with WinPcap. As NPcap has the same file names (wpcap.dll and packet.dll) for compatibility, we just can't put the the-same-name files in the same folder with WinPcap. Though I pers