Re: [Wireshark-dev] Mailing List Discussions for Patches

2015-02-09 Thread Bill Meier
On 2/9/2015 5:29 PM, Kevin Grigorenko wrote: Hi there. I wrote a patch to add a "Sum" column to the Service Response Time window which I've found useful in some customer work. I've reviewed § 3.9 "Contribute your changes" in the Developer's Guide and I didn't find any notes about whether or not m

[Wireshark-dev] Mailing List Discussions for Patches

2015-02-09 Thread Kevin Grigorenko
Hi there. I wrote a patch to add a "Sum" column to the Service Response Time window which I've found useful in some customer work. I've reviewed § 3.9 "Contribute your changes" in the Developer's Guide and I didn't find any notes about whether or not mailing list discussion is required, which is

Re: [Wireshark-dev] lua_bitop.c: MSVC2013 Code Analysis Warning

2015-02-09 Thread Hadriel Kaplan
This appears to be a false positive. According to: https://msdn.microsoft.com/en-us/library/9t02bbsx.aspx ...the warning is generated because "If the shift overflowed the 32-bit value, bits are lost." But that's what is actually intended in bitop (it's a 32-bit bit operations library). I bel

[Wireshark-dev] Problem with Gerrit and Wordpress

2015-02-09 Thread Bryant Eastham
All: I am having problems setting up a new Gerrit account using Wordpress. Tracing the interaction it appears that code.wireshark.org tries to do a post to Wordpress using http that gets redirected to https, but the next request is a get instead of a post and the process stalls at that point.

Re: [Wireshark-dev] Script used to automatically delete unused #includes

2015-02-09 Thread Martin Mathieson
I will try to get it into a state where it will at least run under Windows or an Ubuntu VM and check it in with a licence header and warnings... Martin On Sun, Feb 8, 2015 at 6:01 PM, Alexis La Goutte wrote: > > > On Mon, Jan 5, 2015 at 12:56 AM, Martin Mathieson < > martin.r.mathie...@googlema