Re: [Wireshark-dev] address to string optimization

2015-02-07 Thread mmann78
Made a "first draft" at https://code.wireshark.org/review/7019/ -Original Message- From: Guy Harris To: Developer support list for Wireshark Sent: Fri, Jan 16, 2015 10:55 pm Subject: Re: [Wireshark-dev] address to string optimization On Jan 16, 2015, at 11:34 AM, mman...@netscape.

Re: [Wireshark-dev] lua_bitop.c: MSVC2013 Code Analysis Warning

2015-02-07 Thread Hadriel Kaplan
I'll take a look. -hadriel On Feb 7, 2015, at 4:54 PM, Bill Meier wrote: > Hadriel: > > MSVC2013 Code Analysis is giving the following warning: > > > ...\ws-git\epan\wslua\lua_bitop.c(116) : warning C6297: Arithmetic overflow: > 32-bit value is shifted, then cast to 64-bit value. Results

[Wireshark-dev] lua_bitop.c: MSVC2013 Code Analysis Warning

2015-02-07 Thread Bill Meier
Hadriel: MSVC2013 Code Analysis is giving the following warning: ...\ws-git\epan\wslua\lua_bitop.c(116) : warning C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value. Results might not be an expected value. After quick look at the code, my reaction: Uh Oh... T