One more hint: if push patch as draft then add reviewer, because draft
is invisible for anyone (expect author and reviewers)
Alternative command(s) to send to gerrit:
git push origin HEAD:refs/drafts/master
git push origin HEAD:refs/publish/master
By the way: I vote for adding expert info. Someti
On Feb 5, 2015, at 1:02 PM, Ed Beroset wrote:
>> Shouldn't it be
>> https://bero...@code.wireshark.org/wireshark/tools/hooks/commit-msg
>>
>> What does git remote -v show?
>
> originhttps://bero...@code.wireshark.org/review/wireshark (fetch)
> originhttps://bero...@code.wiresha
On 5 February 2015 at 18:02, Ed Beroset wrote:
> Graham Bloice wrote:
> >On 5 February 2015 at 17:48, Ed Beroset wrote:
> >
>
> >> Problems encountered installing commit-msg hook
> >> The following command failed with exit code 104
> >> "GET https://bero...@code.wireshark.org/tools/hooks/com
Please just upload it Gerrit - it's much easier to review there. You
can upload it as a draft (pass the -D flag to git-review) if you want
to avoid cluttering up the main review list yet.
On Thu, Feb 5, 2015 at 11:49 AM, Dario Lombardo
wrote:
> Evan,
> please find attached a patch that implements
Graham Bloice wrote:
>On 5 February 2015 at 17:48, Ed Beroset wrote:
>
>> Problems encountered installing commit-msg hook
>> The following command failed with exit code 104
>> "GET https://bero...@code.wireshark.org/tools/hooks/commit-msg";
>> ---
[...]
>>
>> I don't real
On 5 February 2015 at 17:48, Ed Beroset wrote:
> I've followed the steps here:
> https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcObtain.html
>
> And I've successfully gotten to the step where it says to run "git review
> -s" but then it fails. The full error dump is:
>
> Traceback (most re
I've followed the steps here:
https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcObtain.html
And I've successfully gotten to the step where it says to run "git review -s"
but then it fails. The full error dump is:
Traceback (most recent call last):
File "/usr/bin/git-review", line 10, in
Evan,
please find attached a patch that implements what I was trying to do. I'd
like to share it here with you and other devels in order to understand if
it goes in the right direction and maybe to open discussions on it. If it
seems good, I'll move it to gerrit for code review.
To test it, simply
On Thu, Feb 5, 2015 at 9:41 AM, Jeff Morriss wrote:
> On 02/05/15 03:51, Wireshark code review wrote:
>>
>> URL:
>> https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2bcd38fec409357d463193b55cecc446b5065b3f
>> Submitter: Anders Broman (a.broma...@gmail.com)
>> Changed: branch: ma
On 02/05/15 03:51, Wireshark code review wrote:
URL:
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2bcd38fec409357d463193b55cecc446b5065b3f
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark
Commits:
2bcd38f by Evan Huus (eapa...
On Thu, Feb 5, 2015 at 1:19 PM, Evan Huus wrote:
> I believe g_log and friends go to standard out, but maybe not on all
> platforms. An expert info under conditional compilation would probably
> be enough though, I hadn't thought of that.
>
Another question. I've found a promising point to put t
I believe g_log and friends go to standard out, but maybe not on all
platforms. An expert info under conditional compilation would probably
be enough though, I hadn't thought of that.
On Thu, Feb 5, 2015 at 5:49 AM, Dario Lombardo
wrote:
> On Wed, Feb 4, 2015 at 7:28 PM, Evan Huus wrote:
>>
>> I
On Wed, Feb 4, 2015 at 7:28 PM, Evan Huus wrote:
> I suppose you could add a an expert info, but I think that might be
> overkill, most users probably don't care that much.
Expert infos could be added under conditional compilation. If enabled it
would allow to filter packets that has expert inf
13 matches
Mail list logo
