Re: [Wireshark-dev] The possibility of a curses based Wireshark

2014-11-29 Thread Edwin Groothuis
On 29/11/2014 6:23 am, Stephen Fisher wrote: > I've started tinkering with the possibility of making a curses text > based GUI for Wireshark (cshark, I suppose). I started by making a new > directory under ui/ for it and creating dummy functions for things that > the main code base runs (such a

Re: [Wireshark-dev] PSA: QString.toUtf8().constData() pattern is unsafe

2014-11-29 Thread Peter Wu
On Saturday 29 November 2014 00:38:34 John Sullivan wrote: > On Friday, November 28, 2014, 7:13:26 PM, Peter Wu wrote: > > Hi all, > > > I mostly use Wireshark GTK, but just tried the Qt UI again. A recurring > > problem was an ASAN crash on shutdown. It turns out that there are many > > users of

[Wireshark-dev] [RANAP truncated] - 1.10.5

2014-11-29 Thread Michal Mazurek (mimazure)
Hello, While trying to create a fake RANAP packet I experience a problem that if a RANAP packet is longer than 1 octet (i.e. RANAP SCCP parameter is longer than 1 octet) Wireshark fails to decode the whole RANAP content. It does not take into account 2 octet length 017A, dissector is provided on

Re: [Wireshark-dev] Support dissecting REAL (BER) data values

2014-11-29 Thread Maarten Bezemer
Hi, I noticed that the function was indeed used by packet-ber.c as well. I do not have means to test whether my changes are compatible with PER. But if the encoding indeed is identical, it should be working... Although the dissect_per_real() function (or what ever its name is), does probably ne

Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt

2014-11-29 Thread Bálint Réczey
Hi Jeff, 2014-11-26 19:26 GMT+01:00 Jeff Morriss : > On 11/26/14 13:01, Stephen Fisher wrote: >> >> Is there any reason a user would have both GTK3 and GTK2 installed and >> not want to use GTK3 for wireshark-gtk builds? We could simplify it to >> be --with-gtk/--without-gtk and --with-qt/--witho

Re: [Wireshark-dev] PSA: QString.toUtf8().constData() pattern is unsafe

2014-11-29 Thread Alexis La Goutte
May be add a check (in checkAPI) to detect this mistake ? On Sat, Nov 29, 2014 at 1:38 AM, John Sullivan wrote: > On Friday, November 28, 2014, 7:13:26 PM, Peter Wu wrote: >> Hi all, > >> I mostly use Wireshark GTK, but just tried the Qt UI again. A recurring >> problem was an ASAN crash on shutd