Le 27 août 2014 02:25, "Stalley, Sean" a écrit :
>
> Martin,
>
> I was able to set up a notification via the web interface.
>
> Under "Username"->Settings->Watched Projects
> Set project to: wireshark
> and the conditional to: file:"epan/dissectors/packet-usb.c"
>
> I think we should discuss how t
Martin,
I was able to set up a notification via the web interface.
Under "Username"->Settings->Watched Projects
Set project to: wireshark
and the conditional to: file:"epan/dissectors/packet-usb.c"
I think we should discuss how to clean up the usb dissector. It seems like we
are running into th
Gerald, dunno if this is possible or not, but the Gerrit integration
probably shouldn't be marking bugs as "FIXED" when they've already been
resolved into some other state...
Don't think it's a big deal though, just seems odd.
Evan
-- Forwarded message --
From:
Date: Tue, Aug 26
On Aug 26, 2014, at 6:57 AM, Martin Kaiser wrote:
> at the moment, the directory for the extcap binaries is defined at
> compile time.
>
> When I first tried extcap a year ago, I created a patch to make the
> extcap directory a preference. This was much easier for me to handle
> when I played w
On Tue, Aug 26, 2014 at 4:31 PM, Pascal Quantin
wrote:
> M
> Le 26 août 2014 15:59, "Martin Kaiser" a écrit :
>
>
>>
>> Hi,
>>
>> at the moment, the directory for the extcap binaries is defined at
>> compile time.
>>
>> When I first tried extcap a year ago, I created a patch to make the
>> extcap
Le 26 août 2014 20:00, "Alexis La Goutte" a
écrit :
>
> On Tue, Aug 26, 2014 at 4:31 PM, Pascal Quantin
> wrote:
> > M
> > Le 26 août 2014 15:59, "Martin Kaiser" a écrit :
> >
> >
> >>
> >> Hi,
> >>
> >> at the moment, the directory for the extcap binaries is defined at
> >> compile time.
> >>
>
On Tue, Aug 26, 2014 at 12:14 PM, Graham Bloice
wrote:
> On 26 August 2014 11:05, Martin Kaiser wrote:
>>
>>
>> Is there a way to "subscribe" to gerrit change requests so that I'm
>> notified when a new USB-related change is uploaded?
>>
>
> I have no idea if this will do what you want, but there
Yes it's true assuming "ti_channel" isn't otherwise used.
-Original Message-
From: Juan Jose Martin Carrascosa
To: Developer support list for Wireshark
Sent: Tue, Aug 26, 2014 11:32 am
Subject: Re: [Wireshark-dev] Equivalency between APIs
Thanks for your reply. Regarding the last
Thanks for your reply. Regarding the last comment, just to double check
since I am not very experienced on this... it would be like:
channel_tree = proto_tree_add_subtree_format(rtps_parameter_tree, tvb,
off, 0,
ett_rtps_locator_filter_channel, NULL, "Channel[%u]", ch);
True?
- Juanj
You are correct. proto_tree_add_subtree is for no printf-style arguments,
proto_tree_add_subtree_format is for when you need printf-style arguments for
your subtree.
One thing to check (if you're compiler doesn't do it for you because somebody's
will) is that you may no longer need the proto
M
Le 26 août 2014 15:59, "Martin Kaiser" a écrit :
>
> Hi,
>
> at the moment, the directory for the extcap binaries is defined at
> compile time.
>
> When I first tried extcap a year ago, I created a patch to make the
> extcap directory a preference. This was much easier for me to handle
> when I
Hi all,
I need to remove the proto_tree_add_text calls, and I wanted to know if
this is equivalent:
Before:
ti_channel = proto_tree_add_text(rtps_parameter_tree, tvb, off, 0,
"Channel[%u]", ch);
channel_tree = proto_item_add_subtree(ti_channel,
ett_rtps_locator_filter_channel);
Hi,
at the moment, the directory for the extcap binaries is defined at
compile time.
When I first tried extcap a year ago, I created a patch to make the
extcap directory a preference. This was much easier for me to handle
when I played with several extcaps that needed frequent recompiling.
I'd l
Hi Pascal,
Thus wrote Pascal Quantin (pascal.quan...@gmail.com):
> I spotted a regression myself (that seems similar to what you report) and
> proposed https://code.wireshark.org/review/#/c/3858/ to fix it. Could you
> give it a try on your sample?
looks good to me, I just merged it.
Best regar
On 26 August 2014 11:05, Martin Kaiser wrote:
>
> Is there a way to "subscribe" to gerrit change requests so that I'm
> notified when a new USB-related change is uploaded?
>
>
I have no idea if this will do what you want, but there does appear to be
email notification from Gerrit:
https://code.wi
Hi Martin,
2014-08-26 12:05 GMT+02:00 Martin Kaiser :
>
> The new req_type is the same as the existing type. There's a
> switch(type) {...} followed by in if (req_type==...).
>
> My goal is to have only one call to try_dissect_next_protocol(). In
> dissect_usb_common(), we dissect the standard fi
The new req_type is the same as the existing type. There's a
switch(type) {...} followed by in if (req_type==...).
My goal is to have only one call to try_dissect_next_protocol(). In
dissect_usb_common(), we dissect the standard fields in the main
switch-statement and call try_dissect_next_protoc
> -Original Message-
> From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-
> boun...@wireshark.org] On Behalf Of Evan Huus
> Sent: den 25 augusti 2014 19:32
> To: Developer support list for Wireshark
> Subject: Re: [Wireshark-dev] Gerrit patches with trailing whitespace
>
> On
Hi all,
I attempted to get my wireshark dev env updated to git today, and ran into an
issue with the 'git review -s' part of the instructions.
The error message was:
Problems encountered installing commit-msg hook
The following command failed with exit code 104
"GET https://d...@code.wiresh
19 matches
Mail list logo
