Hi,
On Mon, Jul 28, 2014 at 10:47:43PM +0200, Martin Kaiser wrote:
> However, I don't quite understand why for tree!=NULL but not visible,
> proto_tree_add_text() returns tree. I can see this in the code, we call
> TRY_TO_FAKE_THIS_ITEM(), which returns the tree itself when it's not
> visible. But
I think a lot of similar refactoring can be done in the area of "statistics
taps". The GUI layer for many of them is (or should be) fairly thin, mostly
separated by number and types of columns. By using epan (and ui) directory as
a "middle layer", we can achieve more standard usage of "stati
On Mon, Jul 28, 2014 at 06:17:37PM -0400, Jeff Morriss wrote:
> On 07/26/14 16:59, Wireshark code review wrote:
> >URL:
> >https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=31ecdf5b06bff3bb2e706e840c28c519698e6f67
> >Submitter: Gerald Combs (ger...@wireshark.org)
> >Changed: bran
On 07/26/14 16:59, Wireshark code review wrote:
URL:
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=31ecdf5b06bff3bb2e706e840c28c519698e6f67
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark
Commits:
31ecdf5 by Michael Mann (mman.
Hi all,
I'm sending out some unsorted thoughts, hoping that you can help me
understand the issue I'm seeing.
After the switch to proto_tree_add_subtree(), I found that some output
of the DVB-CI dissector was different than before.
Replacing
ti = proto_tree_add_text(tree, tvb, offset, tvb_data_le
-Original Message-
From: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Bill Meier
Sent: den 28 juli 2014 15:24
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] O2 compile option makes it difficult to debug.
>> Hi,
>> I
On 07/27/14 13:34, Bálint Réczey wrote:
2014-07-25 23:49 GMT+02:00 Jeff Morriss :
On 07/22/14 16:27, Wireshark announcements wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I'm proud to announce the release of Wireshark 1.12.0rc3. This is a
public release candidate for Wireshark 1.12.0.
Hi,
It seems like the O2 option interferes with running the debugger. Would
it be better to only use O2 on release builds?
I'm not sure how to do that, add nmake -f makefile.nmake release option?
What I've done is to alter config.nmake slightly to allow the
specification of WIRESHARK_ENVIRONMEN
On 28 July 2014 13:35, wrote:
> +1
>
> I was trying to hold out until the CMake stuff for Windows is complete.
> Since it sounds close, I thought I could just deal with merging the removal
> of O2 option for awhile.
>
>
>
Feedback on the latest CMake changes I added to Gerrit wold be handy :-)
What issues are you facing? I debug O2 code all the time, including
profile guided optimised builds as well without too much difficulty. The
most common problem is frame pointer omission making local variables and
function parameters tough to locate. The /d2Zi+ switch (or /Zo for VS2013
Update 3
+1
I was trying to hold out until the CMake stuff for Windows is complete. Since
it sounds close, I thought I could just deal with merging the removal of O2
option for awhile.
-Original Message-
From: Anders Broman
To: Developer support list for Wireshark
Sent: Mon, Jul 28, 20
Hi,
It seems like the O2 option interferes with running the debugger. Would it
be better to only use O2 on release builds?
I'm not sure how to do that, add nmake -f makefile.nmake release option?
Regards
Anders
___
Sent via:
12 matches
Mail list logo
