[Wireshark-dev] How to define HAVE_SSE42 with autotools?

2014-06-09 Thread Anders Broman
Hi, I found this macro but I have no experience with autoconf so I'm not surer how to use it... http://www.gnu.org/software/autoconf-archive/ax_ext.html Regards Anders ___ Sent via:Wireshark-dev mailing list Archives:

Re: [Wireshark-dev] master 97e1491: Sync .deb packaging from Debian

2014-06-09 Thread Joerg Mayer
On Sun, Jun 08, 2014 at 11:16:27PM +0700, Réczey Bálint wrote: > Ok, I'm fine with removing them. In Debian they are needed by netexpect. > BTW may I ask why are they not welcomed? You could probably google that :-) but here's the summary: The library was only created to share the code between the

Re: [Wireshark-dev] [PATCH] reduce scope of and close a file descriptor in wsutil/sha1.c

2014-06-09 Thread Guy Harris
On Jun 9, 2014, at 1:43 PM, Jakub Zawadzki wrote: > On Mon, Jun 09, 2014 at 07:32:49PM +0200, Toralf Förster wrote: > >> +ws_close(f); > > ^^^ fclose(f) ? Yes. > ws_close() seems to be taking file descriptor. Yes, it's just a #define for close on UN*X and for _close on Win

Re: [Wireshark-dev] [PATCH] reduce scope of and close a file descriptor in wsutil/sha1.c

2014-06-09 Thread Jakub Zawadzki
On Mon, Jun 09, 2014 at 07:32:49PM +0200, Toralf Förster wrote: > spotted by cppcheck > > Signed-off-by: Toralf Förster > --- > wsutil/sha1.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/wsutil/sha1.c b/wsutil/sha1.c > index fcafd2b..081881a 100644 > --- a/wsutil

[Wireshark-dev] [PATCH] reduce scope of and close a file descriptor in wsutil/sha1.c

2014-06-09 Thread Toralf Förster
spotted by cppcheck Signed-off-by: Toralf Förster --- wsutil/sha1.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/wsutil/sha1.c b/wsutil/sha1.c index fcafd2b..081881a 100644 --- a/wsutil/sha1.c +++ b/wsutil/sha1.c @@ -362,7 +362,6 @@ static const char *val[] = int ma

Re: [Wireshark-dev] Windows cmake

2014-06-09 Thread Graham Bloice
On 5 June 2014 10:00, Graham Bloice wrote: > On 5 June 2014 07:18, Joerg Mayer wrote: > >> Hello (at least Graham), >> >> I'd like to get as far with the cmake on Windows stuff as possible during >> Sharkfest I thought we might as well start early ;-) >> >> What do we need to address in the cmak

Re: [Wireshark-dev] [Wireshark-commits] master 97e1491: Sync .deb packaging from Debian

2014-06-09 Thread Jeff Morriss
Historically it's been because "we" want people doing Wireshark development against the SVN trunk^W^Wgit master rather than against a release. Though I think the argument that the -dev package allows 3rd party packages (like netexpect) that use Wireshark's headers/libraries is a good one. O

Re: [Wireshark-dev] [BMR #93974] ipmi-trace dissector

2014-06-09 Thread Dmitry Bazhenov
Hello, all, The PCAP library maintainers have reserved the DLT_/LINKTYPE_ value for the recently proposed IPMI Trace encapsulation format. The proposed for review patch adds a mapping between DLT_IPMI_HPM_2 link-layer header type to the IPMI Trace Wiretap encapsulation. https://code.wiresha

Re: [Wireshark-dev] Profiling tshark

2014-06-09 Thread Anders Broman
From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Evan Huus Sent: den 9 juni 2014 13:29 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Profiling tshark On Jun 9, 2014, at 4:02 AM, Anders Broman mailto:anders.bro...@erics

Re: [Wireshark-dev] Profiling tshark

2014-06-09 Thread Evan Huus
> On Jun 9, 2014, at 4:02 AM, Anders Broman wrote: > > Hi, > As can be seen we have managed to make a significant improvement from 1.10.6 > > wireshark 1.10.6 (v1.10.6 from master-1.10) > ==44865== Callgrind, a call-graph generating cache profiler > ==44865== Copyright (C) 2002-2013, and GNU G

Re: [Wireshark-dev] [Wireshark-commits] master 97e1491: Sync .deb packaging from Debian

2014-06-09 Thread Réczey Bálint
Hi Jörg, 2014-06-08 23:16 GMT+07:00 Réczey Bálint : > Ok, I'm fine with removing them. In Debian they are needed by netexpect. > BTW may I ask why are they not welcomed? > > 2014.06.08. 22:43, "Joerg Mayer" ezt írta: > >> On Sun, Jun 08, 2014 at 03:32:12PM +, Wireshark code review wrote: >> >

Re: [Wireshark-dev] [BMR #93974] ipmi-trace dissector

2014-06-09 Thread Dmitry Bazhenov
Hello, all, The PCAP library maintainers have reserved the DLT_/LINKTYPE_ value for the recently proposed IPMI Trace encapsulation format. The proposed for review patch adds a mapping between DLT_IPMI_HPM_2 link-layer header type to the IPMI Trace Wiretap encapsulation. https://code.wiresha

[Wireshark-dev] Profiling tshark

2014-06-09 Thread Anders Broman
Hi, As can be seen we have managed to make a significant improvement from 1.10.6 wireshark 1.10.6 (v1.10.6 from master-1.10) ==44865== Callgrind, a call-graph generating cache profiler ==44865== Copyright (C) 2002-2013, and GNU GPL'd, by Josef Weidendorfer et al. ==44865== Using Valgrind-3.10.0.SV

Re: [Wireshark-dev] [Bug 10139] Wireshark PEEKREMOTE incorrectly decoding QoS data packets from Cisco Sniffer APs

2014-06-09 Thread Guy Harris
On Jun 8, 2014, at 10:29 PM, Vignesh Viswanathan -X (vignevis - EMBED UR SYSTEMS at Cisco) wrote: > Thank you fixing this issue with PEEKREMOTE dissector. > > When could we possibly expect the next build with this fix included, so that > we can give it a try with our setup and resolve our bu