Re: [Wireshark-dev] $Id$ and git

2014-02-13 Thread Alexis La Goutte
On Thu, Feb 13, 2014 at 10:24 PM, Jeff Morriss wrote: > It seems that putting $Id$ in files stored in Git is pointless and > discouraged. > > Should we remove $Id$ from all the files (and remove the check from > checkAPIs)? > For checkAPIs, may be revert/change the code... to display a error if t

Re: [Wireshark-dev] $Id$ and git

2014-02-13 Thread Guy Harris
On Feb 13, 2014, at 1:24 PM, Jeff Morriss wrote: > It seems that putting $Id$ in files stored in Git is pointless and > discouraged. > > Should we remove $Id$ from all the files (and remove the check from > checkAPIs)? ...and modify all our tools that generate code not to add $Id$ to the gen

Re: [Wireshark-dev] Ubuntu Cmake Build Failing

2014-02-13 Thread Guy Harris
On Feb 13, 2014, at 2:43 PM, Gerald Combs wrote: > It looks like we're creating tshark-tap-register.c for both tshark and > tfshark at the same time: > > [ 86%] Generating tshark-tap-register.c > [ 86%] Generating tshark-tap-register.c Methinks the file for the tap registration routine for tfs

Re: [Wireshark-dev] Ubuntu Cmake Build Failing

2014-02-13 Thread Gerald Combs
On 2/11/14 6:01 PM, Evan Huus wrote: > So I finally got the licensecheck passing (woohoo!) and noticed while > I was doing it that the cmake build has been failing for a while: > > Traceback (most recent call last): > File > "/home/wireshark/builders/trunk/ubuntu1204x64/build/tools/make-tap-reg

Re: [Wireshark-dev] 802.1qinq/802.1ad ethertypes

2014-02-13 Thread Jaap Keuter
On 02/12/2014 07:40 PM, Florian Lohoff wrote: > On Wed, Feb 12, 2014 at 05:30:20PM +0100, Alexis La Goutte wrote: >> Hi, >> >> >From old conversation on -users : >> >> Check the VLAN preferences. There is an entry for the 802.1QinQ Ethertype, >> which by default is 9100. >> >> http://www.wireshark.

Re: [Wireshark-dev] Automatically Expiring Old Gerrit Reviews

2014-02-13 Thread Evan Huus
On Thu, Feb 13, 2014 at 12:36 PM, Hadriel Kaplan wrote: > > Speaking of old reviews, anything going on with the Michael Labedzki's > omnivorous-shark one? (https://code.wireshark.org/review/#/c/16) At one point he was talking with Michael Mann since they were working on closely-related (and poss

Re: [Wireshark-dev] $Id$ and git

2014-02-13 Thread Evan Huus
On Thu, Feb 13, 2014 at 4:24 PM, Jeff Morriss wrote: > It seems that putting $Id$ in files stored in Git is pointless and > discouraged. > > Should we remove $Id$ from all the files (and remove the check from > checkAPIs)? Agreed, they serve no purpose now. I've been removing them ad-hoc as I tou

Re: [Wireshark-dev] $Id$ and git

2014-02-13 Thread Guy Harris
On Feb 13, 2014, at 1:24 PM, Jeff Morriss wrote: > It seems that putting $Id$ in files stored in Git is pointless and > discouraged. > > Should we remove $Id$ from all the files (and remove the check from > checkAPIs)? Denis Ovsienko recently got around to removing them from libpcap and tcpd

[Wireshark-dev] $Id$ and git

2014-02-13 Thread Jeff Morriss
It seems that putting $Id$ in files stored in Git is pointless and discouraged. Should we remove $Id$ from all the files (and remove the check from checkAPIs)? ___ Sent via:Wireshark-dev mailing list Archives:http

Re: [Wireshark-dev] Automatically Expiring Old Gerrit Reviews

2014-02-13 Thread Hadriel Kaplan
Speaking of old reviews, anything going on with the Michael Labedzki's omnivorous-shark one? (https://code.wireshark.org/review/#/c/16) I ask because I've implemented a feature whose code will change quite a bit if/when the omnivorous-shark one gets merged, so I've been waiting for that merge

[Wireshark-dev] tshark - z follow aborts after missing or broken package

2014-02-13 Thread Toni Valac
Hello everybody,   when using tshark with -z "follow,tcp,ascii," option to read a pcap file the output data is incomplete if there's a package missing or broken in the stream. (NOTE: This applies to Wiresharks "follow tcp stream" as well) I spent a lot time trying to figure out why this happens a

Re: [Wireshark-dev] Unable to recognise DTLS packets

2014-02-13 Thread Pascal Quantin
Hi, 2014-02-13 8:43 GMT+01:00 Tulika Bose : > Hi > Thanx a lot.I used the 'Decode as' option,and the DTLS header is getting > parsed correctly.But it caused an issue,that for some some of the DTLS > packets,the pprotocol field showed DTLSv1,while the other packets showed it > as DTLS,although a