Re: [Wireshark-dev] Gently migrating to Git + Gerrit

2013-09-19 Thread Guy Harris
On Aug 8, 2013, at 11:21 AM, Evan Huus wrote: > Similarly on Mac, it would be nice if the macosx-setup.sh script could > as much as possible be replaced with a set of homebrew packages (or > some other equivalent). On OS X and Windows, it would be nice if people doing Wireshark development wer

Re: [Wireshark-dev] Gerrit sandbox available for testing

2013-09-19 Thread Gerald Combs
On 9/18/13 11:57 PM, Dirk Jagdmann wrote: >> A few months ago we discussed migrating from SVN to Git + Gerrit. I >> managed to get Gerrit[1] sandbox up and running at >> >> http://test.code.wireshark.org/review/ > > will this Git be kept in sync with SVN trunk? Or will it be just a snapshot >

Re: [Wireshark-dev] Multiple commits per topic branch

2013-09-19 Thread Alexis La Goutte
Thanks for this information... (i search this information about "topic branch" this afternoon...) On Thu, Sep 19, 2013 at 7:38 PM, Marc Petit-Huguenin < m...@petit-huguenin.org> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > It is possible to have more than one commit per topic b

Re: [Wireshark-dev] Tool Ownership and Licensing

2013-09-19 Thread Evan Huus
On 2013-09-19, at 3:41 PM, Jeff Morriss wrote: > On 09/18/13 17:38, Guy Harris wrote: >> >> On Sep 17, 2013, at 10:12 PM, Gilbert Ramirez wrote: >> >>> I admit to authoring pkt-from-core.py, but I doubt it actually still works. >>> Nevertheless, I have updated the license in the file. >>> >>

Re: [Wireshark-dev] Shell scripts for building *register*.c files

2013-09-19 Thread Guy Harris
On Sep 19, 2013, at 12:18 PM, Joerg Mayer wrote: > If I understand things for windows builds correctly, we require python for > windows builds as well nowadays. If that's correct we should get rid of the > shell script. For UN*X builds from SVN, you need Python (to build the Netware NCP dissect

Re: [Wireshark-dev] Tool Ownership and Licensing - log history of renamed files

2013-09-19 Thread Jeff Morriss
On 09/19/13 16:09, Evan Huus wrote: On 2013-09-19, at 3:41 PM, Jeff Morriss wrote: On 09/18/13 17:38, Guy Harris wrote: On Sep 17, 2013, at 10:12 PM, Gilbert Ramirez wrote: I admit to authoring pkt-from-core.py, but I doubt it actually still works. Nevertheless, I have updated the licens

Re: [Wireshark-dev] Tool Ownership and Licensing

2013-09-19 Thread Jeff Morriss
On 09/18/13 17:38, Guy Harris wrote: On Sep 17, 2013, at 10:12 PM, Gilbert Ramirez wrote: I admit to authoring pkt-from-core.py, but I doubt it actually still works. Nevertheless, I have updated the license in the file. I don't remember the others, though. [...] doc/dfilter2pod.pl Gilber

Re: [Wireshark-dev] Tool Ownership and Licensing

2013-09-19 Thread Joerg Mayer
On Wed, Sep 18, 2013 at 02:34:26PM -0700, Guy Harris wrote: > > On Sep 13, 2013, at 11:45 AM, Evan Huus wrote: > > > We have the following tools in our source tree without appropriate > > license headers, > > There's also tools/make-dissector-reg.py, which was written by Gilbert > Ramirez: >

[Wireshark-dev] Multiple commits per topic branch

2013-09-19 Thread Marc Petit-Huguenin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 It is possible to have more than one commit per topic branch. If it is the case, git push will create one patchset per commit in the Gerrit server, with a dependency between successive commits. In most case, this is not a good idea to have multiple

Re: [Wireshark-dev] Quick start instructions for Gerrit

2013-09-19 Thread Alexis La Goutte
Thanks for the How To :-) On Thu, Sep 19, 2013 at 2:52 AM, Marc Petit-Huguenin < m...@petit-huguenin.org> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Thess quick start instructions assume that you know about git, that you > already have an ssh key pair configured and that ss

Re: [Wireshark-dev] Quick start instructions for Gerrit

2013-09-19 Thread Marc Petit-Huguenin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 09/19/2013 07:02 AM, Evan Huus wrote: > Thanks for the information, it is very useful. I am a bit confused though. > Am I understanding correctly that every open review must be rebased after > one is landed in master? This is order of n^2 rebases

Re: [Wireshark-dev] Quick start instructions for Gerrit

2013-09-19 Thread Evan Huus
Thanks for the information, it is very useful. I am a bit confused though. Am I understanding correctly that every open review must be rebased after one is landed in master? This is order of n^2 rebases to land n revisions, which really doesn't scale. What am I missing? Thanks, Evan On 2013-09